All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Weiping Zhang <zhangweiping@didiglobal.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: add documentation for io_timeout
Date: Wed, 28 Nov 2018 09:06:51 -0800	[thread overview]
Message-ID: <1543424811.185366.106.camel@acm.org> (raw)
In-Reply-To: <20181128165415.GA38237@192.168.3.9>

On Thu, 2018-11-29 at 00:54 +0800, Weiping Zhang wrote:
> add documentation for /sys/block/<disk>/queue/io_timeout
> 
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
>  Documentation/ABI/testing/sysfs-block | 9 +++++++++
>  Documentation/block/queue-sysfs.txt   | 6 ++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-block b/Documentation/ABI/testing/sysfs-block
> index dea212db9df3..f37c0000ca16 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -271,3 +271,12 @@ Description:
>  		size of 512B sectors of the zones of the device, with
>  		the eventual exception of the last zone of the device
>  		which may be smaller.
> +
> +What:		/sys/block/<disk>/queue/io_timeout
> +Date:		November 2018
> +Contact:	Weiping Zhang <zhangweiping@didiglobal.com>
> +Description:
> +		io_timeout is the timeout in millisecods of a request in
> +		block layer. The block layer will start a timer when low
> +		level device driver start the request, and cancle timer
> +		when request completes.
> diff --git a/Documentation/block/queue-sysfs.txt b/Documentation/block/queue-sysfs.txt
> index 2c1e67058fd3..cbd44fe056fa 100644
> --- a/Documentation/block/queue-sysfs.txt
> +++ b/Documentation/block/queue-sysfs.txt
> @@ -67,6 +67,12 @@ If set to a value larger than 0, the kernel will put the process issuing
>  IO to sleep for this amont of microseconds before entering classic
>  polling.
>  
> +io_timeout (RW)
> +---------------
> +This is the timeout in millisecods of a request in block layer.
> +The block layer will start a timer when low level device driver start
> +the request, and cancle timer when request completes.
> +
>  iostats (RW)
>  -------------
>  This file is used to control (on/off) the iostats accounting of the

Please run this patch through a spelling checker. I think "millisecods" should
be changed into "milliseconds" and also that "cancle" should be changed into
"cancel".

Thanks,

Bart.

      reply	other threads:[~2018-11-28 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 16:54 [PATCH] block: add documentation for io_timeout Weiping Zhang
2018-11-28 17:06 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543424811.185366.106.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=zhangweiping@didiglobal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.