From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v4 7/7] target: use printf width specifier for t10_wwn field dumps
Date: Thu, 29 Nov 2018 16:37:13 +0000 [thread overview]
Message-ID: <1543509433.185366.131.camel@acm.org> (raw)
In-Reply-To: <20181129010157.12687-8-ddiss@suse.de>
On Thu, 2018-11-29 at 02:01 +-0100, David Disseldorp wrote:
+AD4 The existing for loops step over null-terminators for right-padding.
+AD4 Padding can be achieved in a much simpler way using printf width
+AD4 specifiers.
How about squashing patches 2, 3, 4 and 7 into a single patch? I think
that would make the entire patch series easier to review.
Thanks,
Bart.
prev parent reply other threads:[~2018-11-29 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 1:01 [PATCH v4 7/7] target: use printf width specifier for t10_wwn field dumps David Disseldorp
2018-11-29 1:33 ` Lee Duncan
2018-11-29 16:37 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543509433.185366.131.camel@acm.org \
--to=bvanassche@acm.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.