From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v4 3/7] target: consistently null-terminate t10_wwn.model
Date: Thu, 29 Nov 2018 20:46:48 +0000 [thread overview]
Message-ID: <1543524408.99748.1.camel@acm.org> (raw)
In-Reply-To: <20181129010157.12687-4-ddiss@suse.de>
On Thu, 2018-11-29 at 21:31 +-0100, David Disseldorp wrote:
+AD4 On Thu, 29 Nov 2018 08:24:38 -0800, Bart Van Assche wrote:
+AD4 +AD4 On Thu, 2018-11-29 at 02:01 +-0100, David Disseldorp wrote:
+AD4 +AD4 +AD4 +AFs ... +AF0
+AD4 +AD4 Additionally, have you considered to use strlcpy()
+AD4 +AD4 instead of snprintf()?
+AD4
+AD4 Happy to change the logic below over if you find it easier to follow.
It would make the code shorter without hurting readability, so I think
it would be better to use strlcpy(). But it's not that important to me.
Bart.
prev parent reply other threads:[~2018-11-29 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 1:01 [PATCH v4 3/7] target: consistently null-terminate t10_wwn.model David Disseldorp
2018-11-29 1:19 ` Ly, Bryant
2018-11-29 1:26 ` Lee Duncan
2018-11-29 16:24 ` Bart Van Assche
2018-11-29 20:31 ` David Disseldorp
2018-11-29 20:46 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543524408.99748.1.camel@acm.org \
--to=bvanassche@acm.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.