All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix include reference
Date: Fri, 19 May 2017 14:47:25 +0200	[thread overview]
Message-ID: <1543991.PRPgxyxrAr@phil> (raw)
In-Reply-To: <20170519121434.1118129-1-arnd-r2nGTMty4D4@public.gmane.org>

Hi Arnd,

Am Freitag, 19. Mai 2017, 14:14:34 CEST schrieb Arnd Bergmann:
> The way we handle include paths for DT has changed a bit, which
> broke a file that had an unconventional way to reference a common
> header file:
> 
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:10: fatal error: include/dt-bindings/input/linux-event-codes.h: No such file or directory
> 
> This removes the leading "include/" from the path name, which fixes it.
> 
> Fixes: d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory")
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

This mimics the patch from Ian Campbell [0], which I also pointed at in
the "devicetree: Move include prefixes from arch to separate directory"
thread and I had originally hoped that both would get applied together.

In any case, both patches look good, so this as well gets a
Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>

The other one also got a
Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

It seems I don't have any other fixes for 4.12 at the moment, so
do you want to apply any of the two yourself, or should this make
a round through my tree? (Both ways are fine by me)


Heiko

[0] https://patchwork.kernel.org/patch/9724957/

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> index 658bb9dc9dfd..7bd31066399b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -44,7 +44,7 @@
>  
>  /dts-v1/;
>  #include "rk3399-gru.dtsi"
> -#include <include/dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/input/linux-event-codes.h>
>  
>  /*
>   * Kevin-specific things
> 

  parent reply	other threads:[~2017-05-19 12:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 12:14 [PATCH] arm64: dts: rockchip: fix include reference Arnd Bergmann
     [not found] ` <20170519121434.1118129-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-05-19 12:47   ` Heiko Stuebner [this message]
2017-05-19 15:11     ` Arnd Bergmann
2017-05-19 15:11       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543991.PRPgxyxrAr@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.