From: Krzysztof Kozlowski <krzk@kernel.org>
To: stable@vger.kernel.org
Cc: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH stable v4.4+ 1/3] leds: call led_pwm_set() in leds-pwm to enforce default LED_OFF
Date: Thu, 6 Dec 2018 10:47:00 +0100 [thread overview]
Message-ID: <1544089622-23982-1-git-send-email-krzk@kernel.org> (raw)
From: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>
commit f16703360da7731a057df2ffa902306819c22398 upstream.
Some PWMs are disabled by default or the default pin setting
does not match the LED_OFF state (e.g., active-low leds).
Hence, the driver may end up reporting 0 brightness, but
the leds are actually on using full brightness, because
it never enforces its default configuration.
So enforce it by calling led_pwm_set() after successfully
registering the device.
Tested on a Phytec phyFLEX i.MX6Q board based on kernel
v3.19.5.
Signed-off-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>
Tested-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/leds/leds-pwm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 1d07e3e83d29..3149dbece146 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -132,6 +132,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
ret = led_classdev_register(dev, &led_data->cdev);
if (ret == 0) {
priv->num_leds++;
+ led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
} else {
dev_err(dev, "failed to register PWM led for %s: %d\n",
led->name, ret);
--
2.7.4
next reply other threads:[~2018-12-06 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 9:47 Krzysztof Kozlowski [this message]
2018-12-06 9:47 ` [PATCH stable v4.4+ 2/3] leds: turn off the LED and wait for completion on unregistering LED class device Krzysztof Kozlowski
2018-12-06 9:47 ` [PATCH stable v4.4+ 3/3] leds: leds-gpio: Fix return value check in create_gpio_led() Krzysztof Kozlowski
2018-12-06 10:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544089622-23982-1-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=markus.hofstaetter@ait.ac.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.