From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:55416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727806AbeLFJrf (ORCPT ); Thu, 6 Dec 2018 04:47:35 -0500 From: Krzysztof Kozlowski To: stable@vger.kernel.org Cc: Wei Yongjun , Jacek Anaszewski , Krzysztof Kozlowski Subject: [PATCH stable v4.4+ 3/3] leds: leds-gpio: Fix return value check in create_gpio_led() Date: Thu, 6 Dec 2018 10:47:02 +0100 Message-Id: <1544089622-23982-3-git-send-email-krzk@kernel.org> In-Reply-To: <1544089622-23982-1-git-send-email-krzk@kernel.org> References: <1544089622-23982-1-git-send-email-krzk@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: From: Wei Yongjun commit 2d88a331e48095cf60ad9bdf3177bd401bf99727 upstream. In case of error, the function gpio_to_desc() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun Signed-off-by: Jacek Anaszewski Signed-off-by: Krzysztof Kozlowski --- drivers/leds/leds-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 5db4515a4fd7..df186b38da78 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -118,8 +118,8 @@ static int create_gpio_led(const struct gpio_led *template, return ret; led_dat->gpiod = gpio_to_desc(template->gpio); - if (IS_ERR(led_dat->gpiod)) - return PTR_ERR(led_dat->gpiod); + if (!led_dat->gpiod) + return -EINVAL; } led_dat->cdev.name = template->name; -- 2.7.4