From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Paul Mackerras <paulus@ozlabs.org>,
Juergen Gross <jgross@suse.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 8/9] scsi: remove the use_clustering flag
Date: Thu, 06 Dec 2018 09:13:24 -0800 [thread overview]
Message-ID: <1544116404.185366.256.camel@acm.org> (raw)
In-Reply-To: <20181206155258.11465-9-hch@lst.de>
On Thu, 2018-12-06 at 07:52 -0800, Christoph Hellwig wrote:
> The same effects can be archived by setting the dma_boundary to
^^^^^^^^
achieved?
> PAGE_SIZE - 1 and the max_segment_size to PAGE_SIZE, so shift those
> settings into the drivers. Note that in many cases the setting might
> be bogus, but this keeps the status quo.
[ ... ]
> Documentation/scsi/scsi_mid_low_api.txt | 2 --
> arch/ia64/hp/sim/simscsi.c | 3 ++-
> drivers/scsi/a2091.c | 3 ++-
> drivers/scsi/advansys.c | 4 ++--
> drivers/scsi/aha152x.c | 3 ++-
> drivers/scsi/arm/acornscsi.c | 3 ++-
> drivers/scsi/arm/arxescsi.c | 3 ++-
> drivers/scsi/arm/cumana_1.c | 3 ++-
> drivers/scsi/arm/cumana_2.c | 3 ++-
> drivers/scsi/arm/eesox.c | 3 ++-
> drivers/scsi/arm/oak.c | 3 ++-
> drivers/scsi/atari_scsi.c | 3 ++-
> drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 3 ++-
> drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 3 ++-
> drivers/scsi/dc395x.c | 3 ++-
> drivers/scsi/dmx3191d.c | 3 ++-
> drivers/scsi/g_NCR5380.c | 3 ++-
> drivers/scsi/gvp11.c | 3 ++-
> drivers/scsi/hosts.c | 1 -
> drivers/scsi/ips.c | 1 -
> drivers/scsi/iscsi_tcp.c | 3 ++-
> drivers/scsi/mac_esp.c | 3 ++-
> drivers/scsi/mac_scsi.c | 3 ++-
> drivers/scsi/mvumi.c | 3 ++-
> drivers/scsi/nsp32.c | 3 ++-
> drivers/scsi/pcmcia/nsp_cs.c | 3 ++-
> drivers/scsi/pcmcia/qlogic_stub.c | 3 ++-
> drivers/scsi/qlogicfas.c | 3 ++-
> drivers/scsi/scsi_debug.c | 6 ++++--
> drivers/scsi/scsi_lib.c | 3 ---
> drivers/scsi/sgiwd93.c | 3 ++-
> drivers/scsi/stex.c | 3 ++-
> drivers/scsi/sun3_scsi.c | 3 ++-
> drivers/scsi/ufs/ufshcd.c | 3 ++-
> drivers/target/loopback/tcm_loop.c | 3 ++-
> drivers/usb/storage/uas.c | 3 ++-
> include/scsi/scsi_host.h | 13 -------------
> 37 files changed, 66 insertions(+), 54 deletions(-)
Please split this patch into two patches: one that affects SCSI LLD drivers
and another patch that affects the SCSI core. That will make both reviewing
and bisecting easier.
Thanks,
Bart.
next prev parent reply other threads:[~2018-12-06 17:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:52 remove the "clustering" flag Christoph Hellwig
2018-12-06 15:52 ` [PATCH 1/9] scsi: flip the default on use_clustering Christoph Hellwig
2018-12-06 17:05 ` Bart Van Assche
2018-12-06 15:52 ` [PATCH 2/9] scsi: introduce a max_segment_size host_template parameters Christoph Hellwig
2018-12-06 17:15 ` Bart Van Assche
2018-12-11 2:02 ` Ming Lei
2018-12-11 14:05 ` Christoph Hellwig
2018-12-06 15:52 ` [PATCH 3/9] myrb: remove the DISABLE_CLUSTERING flag Christoph Hellwig
2018-12-06 15:52 ` [PATCH 4/9] myrs: " Christoph Hellwig
2018-12-06 15:52 ` [PATCH 5/9] xen-scsifront: remove DISABLE_CLUSTERING Christoph Hellwig
2018-12-06 15:52 ` [PATCH 6/9] mesh: " Christoph Hellwig
2018-12-06 22:07 ` Paul Mackerras
2018-12-06 15:52 ` [PATCH 7/9] mac53c94: " Christoph Hellwig
2018-12-06 22:07 ` Paul Mackerras
2018-12-06 15:52 ` [PATCH 8/9] scsi: remove the use_clustering flag Christoph Hellwig
2018-12-06 17:13 ` Bart Van Assche [this message]
2018-12-08 17:51 ` Christoph Hellwig
2018-12-06 15:52 ` [PATCH 9/9] block: remove the cluster flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544116404.185366.256.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.