From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXOPN-0002JK-Bg for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:58:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXOPK-0005jr-6A for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:58:37 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:58940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXOPJ-0005ja-Uq for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:58:34 -0400 Date: Wed, 10 Aug 2016 03:58:31 -0400 (EDT) From: Paolo Bonzini Message-ID: <1544442155.776193.1470815911587.JavaMail.zimbra@redhat.com> In-Reply-To: <20160810094614.3a26b0a5.cornelia.huck@de.ibm.com> References: <1470757664-25161-1-git-send-email-pbonzini@redhat.com> <1470757664-25161-3-git-send-email-pbonzini@redhat.com> <20160810094614.3a26b0a5.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, thuth@redhat.com, famz@redhat.com, armbru@redhat.com ----- Original Message ----- > From: "Cornelia Huck" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, thuth@redhat.com, famz@redhat.com, armbru@redhat.com > Sent: Wednesday, August 10, 2016 9:46:14 AM > Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors > > On Tue, 9 Aug 2016 17:47:43 +0200 > Paolo Bonzini wrote: > > > This only leaves a warning-level message for extra-long lines, which > > are relatively common and cause patchew to send email that will likely > > be ignored. > > > > Signed-off-by: Paolo Bonzini > > --- > > scripts/checkpatch.pl | 66 > > +++++++++++++++++++++++++-------------------------- > > 1 file changed, 33 insertions(+), 33 deletions(-) > > > > > # no volatiles please > > my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; > > if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { > > - WARN("Use of volatile is usually wrong: see > > Documentation/volatile-considered-harmful.txt\n" . $herecurr); > > + ERROR("Use of volatile is usually wrong: see > > Documentation/volatile-considered-harmful.txt\n" . $herecurr); > > It's a bit weird to have this refer to a Linux file :) Right. We should include the explanation in docs/atomics.txt and point to that. Paolo