From: Laurence Oberman <loberman@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Todd Aiken <taiken@mvtech.ca>,
Keith Busch <keith.busch@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: Restore tape support
Date: Mon, 10 Dec 2018 10:11:51 -0500 [thread overview]
Message-ID: <1544454711.18488.1.camel@redhat.com> (raw)
In-Reply-To: <20181210111729.GA21553@lst.de>
On Mon, 2018-12-10 at 12:17 +0100, Christoph Hellwig wrote:
> On Sun, Dec 09, 2018 at 07:08:14PM -0800, Bart Van Assche wrote:
> > According to what I found in
> > https://bugzilla.kernel.org/show_bug.cgi?id=201935 patch "block:
> > Clear
> > kernel memory before copying to user" broke tape access. Hence
> > revert
> > that patch.
>
> This looks wrong. The patch from Keith is obviously correct for
> normal usage of bio_copy_user_iov. The SCSI tape drivers use the
> somewhat odd null_mapped case, so we probably need to refine the
> checks
> for that a bit.
I am going to look into that, just connected a tape device so I can
reproduce and then see what we need to make it more specific in the st
driver.
I may need help from folks who understand the bio stuff better than I
do.
Back when I have more.
Regards
Laurence
next prev parent reply other threads:[~2018-12-10 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 3:08 [PATCH] block: Restore tape support Bart Van Assche
2018-12-10 11:17 ` Christoph Hellwig
2018-12-10 15:11 ` Laurence Oberman [this message]
2018-12-10 15:32 ` Keith Busch
2018-12-10 15:36 ` Jens Axboe
2018-12-10 16:17 ` Laurence Oberman
2018-12-10 20:06 ` Laurence Oberman
2018-12-10 20:26 ` Keith Busch
2018-12-10 20:38 ` Todd Aiken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544454711.18488.1.camel@redhat.com \
--to=loberman@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=taiken@mvtech.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.