Re: [PATCH v2] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely

[Oscar Salvador <osalvador@suse.de>]

On Wed, 2018-12-12 at 03:35 +0000, Wei Yang wrote:
> I see the above code is wrapped with CONFIG_DEBUG_VM on current Linus
> tree.
> This is removed by someone else?

Yes, e8abbd69957288 ("mm, memory_hotplug: be more verbose for memory
offline failures") got rid of the CONFIG_DEBUG_VM.
This commit is sitting in the -mmotm tree.

> 
> > -			put_page(page);
> > -			/* Because we don't have big zone->lock.
> > we should
> > -			   check this again here. */
> > -			if (page_count(page)) {
> > -				not_managed++;
> > -				ret = -EBUSY;
> > -				break;
> > -			}
> > 		}
> > +		put_page(page);
> > 	}
> > 	if (!list_empty(&source)) {
> > -		if (not_managed) {
> > -			putback_movable_pages(&source);
> > -			goto out;
> > -		}
> > -
> > 		/* Allocate a new page from the nearest neighbor node
> > */
> > 		ret = migrate_pages(&source, new_node_page, NULL, 0,
> > 					MIGRATE_SYNC,
> > MR_MEMORY_HOTPLUG);
> > @@ -1426,7 +1412,7 @@ do_migrate_range(unsigned long start_pfn,
> > unsigned long end_pfn)
> > 			putback_movable_pages(&source);
> > 		}
> > 	}
> > -out:
> > +
> > 	return ret;
> > }
> > 
> > -- 
> > 2.13.7
> 
> 
-- 
Oscar Salvador
SUSE L3