From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXRDb-0000FE-Mq for kexec@lists.infradead.org; Thu, 13 Dec 2018 13:40:01 +0000 Received: by mail-qk1-x744.google.com with SMTP id a1so1061943qkc.5 for ; Thu, 13 Dec 2018 05:39:49 -0800 (PST) Message-ID: <1544708386.18411.13.camel@lca.pw> Subject: Re: [PATCH] arm64: invalidate TLB before turning MMU on From: Qian Cai Date: Thu, 13 Dec 2018 08:39:46 -0500 In-Reply-To: References: <1544654224.18411.11.camel@lca.pw> <20181213052259.56352-1-cai@lca.pw> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Bhupesh Sharma Cc: Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Linux Kernel Mailing List , AKASHI Takahiro , James Morse , Bhupesh SHARMA , kexec mailing list , linux-arm-kernel T24gVGh1LCAyMDE4LTEyLTEzIGF0IDExOjEwICswNTMwLCBCaHVwZXNoIFNoYXJtYSB3cm90ZToK PiBIaSBRaWFuIENhaSwKPiAKPiBPbiBUaHUsIERlYyAxMywgMjAxOCBhdCAxMDo1MyBBTSBRaWFu IENhaSA8Y2FpQGxjYS5wdz4gd3JvdGU6Cj4gPiAKPiA+IE9uIHRoaXMgSFBFIEFwb2xsbyA3MCBh cm02NCBzZXJ2ZXIgd2l0aCAyNTYgQ1BVcywgdHJpZ2dlcmluZyBhIGNyYXNoCj4gPiBkdW1wIGp1 c3QgaHVuZy4gSXQgaGFzIDQgdGhyZWFkcyBvbiBlYWNoIGNvcmUuIEVhY2ggMi1jb3JlIHNoYXJl IGEgc2FtZQo+ID4gTDEgYW5kIEwyIGNhY2hlcywgc28gdGhhdCBpcyA4IENQVXMgc2hhcmVzIHRo b3NlLiBBbGwgQ1BVcyBzaGFyZSBhIHNhbWUKPiA+IEwzIGNhY2hlLgo+ID4gCj4gPiBJdCB0dXJu ZWQgb3V0IHRoYXQgdGhpcyB3YXMgZHVlIHRvIHRoZSBUTEIgY29udGFpbmVkIHN0YWxlIGVudHJp ZXMgKG9yCj4gPiB1bmluaXRpYWxpemVkIGp1bmsgd2hpY2gganVzdCBoYXBwZW5lZCB0byBsb29r IHZhbGlkKSBmcm9tIHRoZSBmaXJzdAo+ID4ga2VybmVsIGJlZm9yZSB0dXJuaW5nIHRoZSBNTVUg b24gaW4gdGhlIHNlY29uZCBrZXJuZWwgd2hpY2ggY2F1c2VkIHRoaXMKPiA+IGluc3RydWN0aW9u IGh1bmcsCj4gPiAKPiA+IG1zcsKgwqDCoMKgwqBzY3Rscl9lbDEsIHgwCj4gPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IFFpYW4gQ2FpIDxjYWlAbGNhLnB3Pgo+ID4gLS0tCj4gPiDCoGFyY2gvYXJtNjQv a2VybmVsL2hlYWQuUyB8IDQgKysrKwo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9oZWFkLlMgYi9hcmNo L2FybTY0L2tlcm5lbC9oZWFkLlMKPiA+IGluZGV4IDQ0NzFmNTcwYTI5NS4uNTE5NmYzZDcyOWRl IDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvaGVhZC5TCj4gPiArKysgYi9hcmNo L2FybTY0L2tlcm5lbC9oZWFkLlMKPiA+IEBAIC03NzEsNiArNzcxLDEwIEBAIEVOVFJZKF9fZW5h YmxlX21tdSkKPiA+IMKgwqDCoMKgwqDCoMKgwqBtc3LCoMKgwqDCoMKgdHRicjBfZWwxLCB4MsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgLy8gbG9hZCBUVEJSMAo+ID4gwqDC oMKgwqDCoMKgwqDCoG1zcsKgwqDCoMKgwqB0dGJyMV9lbDEsIHgxwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAvLyBsb2FkIFRUQlIxCj4gPiDCoMKgwqDCoMKgwqDCoMKgaXNi Cj4gPiArwqDCoMKgwqDCoMKgwqBkc2LCoMKgwqDCoMKgbnNoc3QKPiA+ICvCoMKgwqDCoMKgwqDC oHRsYmnCoMKgwqDCoHZtYWxsZTHCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoC8vIGludmFsaWRhdGUgVExCCj4gPiArwqDCoMKgwqDCoMKgwqBkc2LCoMKg wqDCoMKgbnNoCj4gPiArwqDCoMKgwqDCoMKgwqBpc2IKPiAKPiBUaGlzIHdpbGwgYmUgZXhlY3V0 ZWQgYm90aCBmb3IgdGhlIHByaW1hcnkgYW5kIGtkdW1wIGtlcm5lbCwgcmlnaHQ/IEkKPiBkb24n dCB0aGluayB3ZSByZWFsbHkgd2FudCB0byBpbnZhbGlkYXRlIHRoZSBUTEIgd2hlbiBib290aW5n IHRoZQo+IHByaW1hcnkga2VybmVsLgo+IEl0IHdvdWxkIGJlIHRvbyBzbG93IGFuZCBjb25zaWRl cmluZyB0aGF0IHdlIG5lZWQgdG8gbWluaW1pemUgYm9vdAo+IHRpbWluZ3Mgb24gZW1iZWRkZWQg YXJtNjQgZGV2aWNlcywgSSB0aGluayBpdCB3b3VsZCBub3QgYmUgYSBnb29kCj4gaWRlYS4KClll cywgaXQgd2lsbCBiZSBleGVjdXRlZCBmb3IgdGhlIGZpcnN0IGtlcm5lbCBhcyB3ZWxsLiBBcyBK YW1lcyBtZW50aW9uZWQsIGl0Cm5lZWRzIHRvIGJlIGRvbmUgdG8gaW52YWxpZGF0ZSBUTEIgdGhh dCBtaWdodCBiZSB1c2VkIGJ5IGJvb3Rsb2FkZXIgYW55d2F5LgoKPiAKPiA+IMKgwqDCoMKgwqDC oMKgwqBtc3LCoMKgwqDCoMKgc2N0bHJfZWwxLCB4MAo+ID4gwqDCoMKgwqDCoMKgwqDCoGlzYgo+ ID4gwqDCoMKgwqDCoMKgwqDCoC8qCj4gPiAtLQo+ID4gMi4xNy4yIChBcHBsZSBHaXQtMTEzKQo+ ID4gCj4gCj4gQWxzbyBkaWQgeW91IGNoZWNrIHRoaXMgaXNzdWUgSSByZXBvcnRlZCBvbiB0aGUg SFBFIGFwb2xsbyBtYWNoaW5lcwo+IHNvbWUgZGF5cyBiYWNrIHdpdGggdGhlIGtkdW1wIGtlcm5l bCBib290Cj4gPGh0dHBzOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2tleGVjL21zZzIxNzUwLmh0 bWw+Lgo+IENhbiB5b3UgcGxlYXNlIGNvbmZpcm0gdGhhdCB5b3UgYXJlIG5vdCBmYWNpbmcgdGhl IHNhbWUgaXNzdWUgKGFzIEkKPiBzdXNwZWN0IGZyb20gcmVhZGluZyB5b3VyIGVhcmxpZXIgQnVn IFJlcG9ydCkgb24gdGhlIEhQRSBhcG9sbG8KPiBtYWNoaW5lLiBBbHNvIGFkZGluZyAnZWFybHlj b24nIHRvIHRoZSBib290YXJncyBiZWluZyBwYXNzZWQgdG8gdGhlCj4ga2R1bXAga2VybmVsIHlv dSBjYW4gc2VlIGlmIHlvdSBhcmUgYWJsZSB0byBhdGxlYXN0IGdldCBzb21lIGNvbnNvbGUKPiBv dXRwdXQgZnJvbSB0aGUga2R1bXAga2VybmVsLgoKTm8sIGhlcmUgZGlkIG5vdCBlbmNvdW50ZXIg dGhlIHByb2JsZW0geW91IG1lbnRpb25lZC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFC0C65BAE for ; Thu, 13 Dec 2018 13:40:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A97120880 for ; Thu, 13 Dec 2018 13:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DZmXOzpa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="MGR+n7w0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A97120880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qw1bgrx7HOYnx3Zs1mYgYe3Wjvk/zZu6KOAB2a96nW0=; b=DZmXOzpapjAblG Fb7Jlxe49sjz3XT/VwM4wuyA8TnzBJLb9ngQcg9MZawLAz4hK/SblE535vILvjV6yf9XYxxszQCyX o3MvWSEGDfIla1FJFYXDpJFm5Pg8mqubbEmWzS3pOpb3R1cvZ7IiES7NB3bTv6cQabApwzmzw1NP/ uZ58TKJALmimeygTEVtantGh3+FDhf4Ccv4dUYa+79ZW5tRP87P3dw4t+QKodKk4Wnt3O6f41td8q H5BbXvJS5lrS1VWvvHm3E97DWOG/fMhdbs+GmRf2AA5elrk2UN4GJIcb02KmdHESUXiSxFwlJSHen oJ09CCWRVn1TEmvdUrYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXRDf-0000M3-GS; Thu, 13 Dec 2018 13:40:03 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXRDb-0000FD-Ms for linux-arm-kernel@lists.infradead.org; Thu, 13 Dec 2018 13:40:01 +0000 Received: by mail-qk1-x743.google.com with SMTP id 189so1102437qkj.8 for ; Thu, 13 Dec 2018 05:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=4E2Bwb5DUkf0C1vvdBwNjevr4g1q0gVM6ZGu5vUMw7I=; b=MGR+n7w0Q8ma9b1TeaeKXpvJnPdVxmm8gV3L0huy3O+/XUPhE59Yci9CMHqfz6FToy mWw99E14cEvwJJX5AC9GMHfVbkWso6/KaGmhhIwLCFwTQYbqBOKLLbqb5o88JlVrYYBA az7kmNSkHfHcVmim8SE3Uu3OvtdyjrWyAD2TqZmlI8+oDjyRSX84z5PCgZXtNeFi7RzY 1OQo5P/4NpKPtB5aENfVRdosLq/jadMz3Z351JyVOJarb7I+edkMeV0aRWdSzwpgBKnw /eeFj1BqYKaDgnV53xsB9Qa5mriHIjLbXzgw5yJrizBYd7N28TPBUU4dUsJkBAdWT/7/ ZSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=4E2Bwb5DUkf0C1vvdBwNjevr4g1q0gVM6ZGu5vUMw7I=; b=Osax+/+VETKLEzd6rUE6PB5/I9HVNCE85Jxq/6IAlG6e2darBEG4N9W11lobYxWalk LgKO/ankfYAEWDtXS9vn+9Cma9/efeDw3SdywfCeWLlS0KP0rDnJR7O+qoy3LbMS0LBn pBirethaAjZjYTJkqdVESMVv/JubQl2h0PjWQC1aDU80Bx3XIGrqOOqiAsKUldFlCqgL Gaotq9teWoU4xQFgnV+pNEH1tpdjBheuOzmR/XMFBz0mGlRS3H90q+W1+qszMiz0K37l GjSy/9YXMtNEMKXZjc0NvYWx596VUnl0mRo/AkU19vu341+UXA/DbKqEqbRzkBx3juRo 4pzw== X-Gm-Message-State: AA+aEWZaclv/9th0M2pMdK736sPOGNOUJLR7/yc93I3eWjVKzVMEkfnG GLolALYIsal6WOkww6z65v0ccA== X-Google-Smtp-Source: AFSGD/UxO/Aat1EAOtmJEujgR6feGpGNSuBWD69clE1pwoPEgfF3IASTk2RptGzoT0ocmoGrKtvwRA== X-Received: by 2002:a37:52d6:: with SMTP id g205mr22340313qkb.335.1544708388593; Thu, 13 Dec 2018 05:39:48 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m1sm1285923qkh.15.2018.12.13.05.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 05:39:48 -0800 (PST) Message-ID: <1544708386.18411.13.camel@lca.pw> Subject: Re: [PATCH] arm64: invalidate TLB before turning MMU on From: Qian Cai To: Bhupesh Sharma Date: Thu, 13 Dec 2018 08:39:46 -0500 In-Reply-To: References: <1544654224.18411.11.camel@lca.pw> <20181213052259.56352-1-cai@lca.pw> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181213_053959_798263_4FCFCCAA X-CRM114-Status: GOOD ( 25.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Linux Kernel Mailing List , AKASHI Takahiro , James Morse , Bhupesh SHARMA , kexec mailing list , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMDE4LTEyLTEzIGF0IDExOjEwICswNTMwLCBCaHVwZXNoIFNoYXJtYSB3cm90ZToK PiBIaSBRaWFuIENhaSwKPiAKPiBPbiBUaHUsIERlYyAxMywgMjAxOCBhdCAxMDo1MyBBTSBRaWFu IENhaSA8Y2FpQGxjYS5wdz4gd3JvdGU6Cj4gPiAKPiA+IE9uIHRoaXMgSFBFIEFwb2xsbyA3MCBh cm02NCBzZXJ2ZXIgd2l0aCAyNTYgQ1BVcywgdHJpZ2dlcmluZyBhIGNyYXNoCj4gPiBkdW1wIGp1 c3QgaHVuZy4gSXQgaGFzIDQgdGhyZWFkcyBvbiBlYWNoIGNvcmUuIEVhY2ggMi1jb3JlIHNoYXJl IGEgc2FtZQo+ID4gTDEgYW5kIEwyIGNhY2hlcywgc28gdGhhdCBpcyA4IENQVXMgc2hhcmVzIHRo b3NlLiBBbGwgQ1BVcyBzaGFyZSBhIHNhbWUKPiA+IEwzIGNhY2hlLgo+ID4gCj4gPiBJdCB0dXJu ZWQgb3V0IHRoYXQgdGhpcyB3YXMgZHVlIHRvIHRoZSBUTEIgY29udGFpbmVkIHN0YWxlIGVudHJp ZXMgKG9yCj4gPiB1bmluaXRpYWxpemVkIGp1bmsgd2hpY2gganVzdCBoYXBwZW5lZCB0byBsb29r IHZhbGlkKSBmcm9tIHRoZSBmaXJzdAo+ID4ga2VybmVsIGJlZm9yZSB0dXJuaW5nIHRoZSBNTVUg b24gaW4gdGhlIHNlY29uZCBrZXJuZWwgd2hpY2ggY2F1c2VkIHRoaXMKPiA+IGluc3RydWN0aW9u IGh1bmcsCj4gPiAKPiA+IG1zcsKgwqDCoMKgwqBzY3Rscl9lbDEsIHgwCj4gPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IFFpYW4gQ2FpIDxjYWlAbGNhLnB3Pgo+ID4gLS0tCj4gPiDCoGFyY2gvYXJtNjQv a2VybmVsL2hlYWQuUyB8IDQgKysrKwo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9oZWFkLlMgYi9hcmNo L2FybTY0L2tlcm5lbC9oZWFkLlMKPiA+IGluZGV4IDQ0NzFmNTcwYTI5NS4uNTE5NmYzZDcyOWRl IDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvaGVhZC5TCj4gPiArKysgYi9hcmNo L2FybTY0L2tlcm5lbC9oZWFkLlMKPiA+IEBAIC03NzEsNiArNzcxLDEwIEBAIEVOVFJZKF9fZW5h YmxlX21tdSkKPiA+IMKgwqDCoMKgwqDCoMKgwqBtc3LCoMKgwqDCoMKgdHRicjBfZWwxLCB4MsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgLy8gbG9hZCBUVEJSMAo+ID4gwqDC oMKgwqDCoMKgwqDCoG1zcsKgwqDCoMKgwqB0dGJyMV9lbDEsIHgxwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAvLyBsb2FkIFRUQlIxCj4gPiDCoMKgwqDCoMKgwqDCoMKgaXNi Cj4gPiArwqDCoMKgwqDCoMKgwqBkc2LCoMKgwqDCoMKgbnNoc3QKPiA+ICvCoMKgwqDCoMKgwqDC oHRsYmnCoMKgwqDCoHZtYWxsZTHCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoC8vIGludmFsaWRhdGUgVExCCj4gPiArwqDCoMKgwqDCoMKgwqBkc2LCoMKg wqDCoMKgbnNoCj4gPiArwqDCoMKgwqDCoMKgwqBpc2IKPiAKPiBUaGlzIHdpbGwgYmUgZXhlY3V0 ZWQgYm90aCBmb3IgdGhlIHByaW1hcnkgYW5kIGtkdW1wIGtlcm5lbCwgcmlnaHQ/IEkKPiBkb24n dCB0aGluayB3ZSByZWFsbHkgd2FudCB0byBpbnZhbGlkYXRlIHRoZSBUTEIgd2hlbiBib290aW5n IHRoZQo+IHByaW1hcnkga2VybmVsLgo+IEl0IHdvdWxkIGJlIHRvbyBzbG93IGFuZCBjb25zaWRl cmluZyB0aGF0IHdlIG5lZWQgdG8gbWluaW1pemUgYm9vdAo+IHRpbWluZ3Mgb24gZW1iZWRkZWQg YXJtNjQgZGV2aWNlcywgSSB0aGluayBpdCB3b3VsZCBub3QgYmUgYSBnb29kCj4gaWRlYS4KClll cywgaXQgd2lsbCBiZSBleGVjdXRlZCBmb3IgdGhlIGZpcnN0IGtlcm5lbCBhcyB3ZWxsLiBBcyBK YW1lcyBtZW50aW9uZWQsIGl0Cm5lZWRzIHRvIGJlIGRvbmUgdG8gaW52YWxpZGF0ZSBUTEIgdGhh dCBtaWdodCBiZSB1c2VkIGJ5IGJvb3Rsb2FkZXIgYW55d2F5LgoKPiAKPiA+IMKgwqDCoMKgwqDC oMKgwqBtc3LCoMKgwqDCoMKgc2N0bHJfZWwxLCB4MAo+ID4gwqDCoMKgwqDCoMKgwqDCoGlzYgo+ ID4gwqDCoMKgwqDCoMKgwqDCoC8qCj4gPiAtLQo+ID4gMi4xNy4yIChBcHBsZSBHaXQtMTEzKQo+ ID4gCj4gCj4gQWxzbyBkaWQgeW91IGNoZWNrIHRoaXMgaXNzdWUgSSByZXBvcnRlZCBvbiB0aGUg SFBFIGFwb2xsbyBtYWNoaW5lcwo+IHNvbWUgZGF5cyBiYWNrIHdpdGggdGhlIGtkdW1wIGtlcm5l bCBib290Cj4gPGh0dHBzOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2tleGVjL21zZzIxNzUwLmh0 bWw+Lgo+IENhbiB5b3UgcGxlYXNlIGNvbmZpcm0gdGhhdCB5b3UgYXJlIG5vdCBmYWNpbmcgdGhl IHNhbWUgaXNzdWUgKGFzIEkKPiBzdXNwZWN0IGZyb20gcmVhZGluZyB5b3VyIGVhcmxpZXIgQnVn IFJlcG9ydCkgb24gdGhlIEhQRSBhcG9sbG8KPiBtYWNoaW5lLiBBbHNvIGFkZGluZyAnZWFybHlj b24nIHRvIHRoZSBib290YXJncyBiZWluZyBwYXNzZWQgdG8gdGhlCj4ga2R1bXAga2VybmVsIHlv dSBjYW4gc2VlIGlmIHlvdSBhcmUgYWJsZSB0byBhdGxlYXN0IGdldCBzb21lIGNvbnNvbGUKPiBv dXRwdXQgZnJvbSB0aGUga2R1bXAga2VybmVsLgoKTm8sIGhlcmUgZGlkIG5vdCBlbmNvdW50ZXIg dGhlIHByb2JsZW0geW91IG1lbnRpb25lZC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C32C65BAE for ; Thu, 13 Dec 2018 13:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9988D2087F for ; Thu, 13 Dec 2018 13:39:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="MGR+n7w0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9988D2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729545AbeLMNju (ORCPT ); Thu, 13 Dec 2018 08:39:50 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40658 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729402AbeLMNjt (ORCPT ); Thu, 13 Dec 2018 08:39:49 -0500 Received: by mail-qk1-f193.google.com with SMTP id y16so1106086qki.7 for ; Thu, 13 Dec 2018 05:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=4E2Bwb5DUkf0C1vvdBwNjevr4g1q0gVM6ZGu5vUMw7I=; b=MGR+n7w0Q8ma9b1TeaeKXpvJnPdVxmm8gV3L0huy3O+/XUPhE59Yci9CMHqfz6FToy mWw99E14cEvwJJX5AC9GMHfVbkWso6/KaGmhhIwLCFwTQYbqBOKLLbqb5o88JlVrYYBA az7kmNSkHfHcVmim8SE3Uu3OvtdyjrWyAD2TqZmlI8+oDjyRSX84z5PCgZXtNeFi7RzY 1OQo5P/4NpKPtB5aENfVRdosLq/jadMz3Z351JyVOJarb7I+edkMeV0aRWdSzwpgBKnw /eeFj1BqYKaDgnV53xsB9Qa5mriHIjLbXzgw5yJrizBYd7N28TPBUU4dUsJkBAdWT/7/ ZSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=4E2Bwb5DUkf0C1vvdBwNjevr4g1q0gVM6ZGu5vUMw7I=; b=RcOFVgNlaeJQ+ujTLFbmWIglysi9BM6+5iHjZyaQDgi7qDSoUGSaCT9yrEFZoz50Hx pyJXGMD3GZ7vmeaJ2Fc7ojF5hcHQwfivYpF9w2KrzLPdwY6NStPz+fegvJeFi4xUqS5U rVxRY0WrmJcX2smnM65Nj+s05pzAPT3y+6OyCQJgCJvoMKQ6JgAmOqosfn0ho8GV6Aiz Jyx1Zg4ygPzPWsWdUnV69nqL8PjAM+cHUdxhopZXoDjqkmvqn/AYCp/LL2vY+RFHlfAE mUp1vPf/J+k5Tq/XI7eERDRR2NUZvo0qSpk/PKnH7/vE+VFiWgWqpXUkWXQUBUMz8auV xlrg== X-Gm-Message-State: AA+aEWbDPcgczaa5Td4e+1gpHjSS6I4C37hicFU44IbQ0rSylHzGfGmG ZfmU2eFqUGJxS0RNd58iBY69y6aVbuDRfg== X-Google-Smtp-Source: AFSGD/UxO/Aat1EAOtmJEujgR6feGpGNSuBWD69clE1pwoPEgfF3IASTk2RptGzoT0ocmoGrKtvwRA== X-Received: by 2002:a37:52d6:: with SMTP id g205mr22340313qkb.335.1544708388593; Thu, 13 Dec 2018 05:39:48 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m1sm1285923qkh.15.2018.12.13.05.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 05:39:48 -0800 (PST) Message-ID: <1544708386.18411.13.camel@lca.pw> Subject: Re: [PATCH] arm64: invalidate TLB before turning MMU on From: Qian Cai To: Bhupesh Sharma Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , kexec mailing list , Linux Kernel Mailing List , AKASHI Takahiro , James Morse , linux-arm-kernel , Bhupesh SHARMA Date: Thu, 13 Dec 2018 08:39:46 -0500 In-Reply-To: References: <1544654224.18411.11.camel@lca.pw> <20181213052259.56352-1-cai@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-12-13 at 11:10 +0530, Bhupesh Sharma wrote: > Hi Qian Cai, > > On Thu, Dec 13, 2018 at 10:53 AM Qian Cai wrote: > > > > On this HPE Apollo 70 arm64 server with 256 CPUs, triggering a crash > > dump just hung. It has 4 threads on each core. Each 2-core share a same > > L1 and L2 caches, so that is 8 CPUs shares those. All CPUs share a same > > L3 cache. > > > > It turned out that this was due to the TLB contained stale entries (or > > uninitialized junk which just happened to look valid) from the first > > kernel before turning the MMU on in the second kernel which caused this > > instruction hung, > > > > msr     sctlr_el1, x0 > > > > Signed-off-by: Qian Cai > > --- > >  arch/arm64/kernel/head.S | 4 ++++ > >  1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > > index 4471f570a295..5196f3d729de 100644 > > --- a/arch/arm64/kernel/head.S > > +++ b/arch/arm64/kernel/head.S > > @@ -771,6 +771,10 @@ ENTRY(__enable_mmu) > >         msr     ttbr0_el1, x2                   // load TTBR0 > >         msr     ttbr1_el1, x1                   // load TTBR1 > >         isb > > +       dsb     nshst > > +       tlbi    vmalle1                         // invalidate TLB > > +       dsb     nsh > > +       isb > > This will be executed both for the primary and kdump kernel, right? I > don't think we really want to invalidate the TLB when booting the > primary kernel. > It would be too slow and considering that we need to minimize boot > timings on embedded arm64 devices, I think it would not be a good > idea. Yes, it will be executed for the first kernel as well. As James mentioned, it needs to be done to invalidate TLB that might be used by bootloader anyway. > > >         msr     sctlr_el1, x0 > >         isb > >         /* > > -- > > 2.17.2 (Apple Git-113) > > > > Also did you check this issue I reported on the HPE apollo machines > some days back with the kdump kernel boot > . > Can you please confirm that you are not facing the same issue (as I > suspect from reading your earlier Bug Report) on the HPE apollo > machine. Also adding 'earlycon' to the bootargs being passed to the > kdump kernel you can see if you are able to atleast get some console > output from the kdump kernel. No, here did not encounter the problem you mentioned.