From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH 09/18] drm/mediatek: add component DITHER Date: Wed, 26 Dec 2018 17:13:19 +0800 Message-ID: <1545815599.20265.3.camel@mtksdaap41> References: <1545638931-24938-1-git-send-email-yongqiang.niu@mediatek.com> <1545638931-24938-10-git-send-email-yongqiang.niu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1545638931-24938-10-git-send-email-yongqiang.niu@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFlvbmdxaWFuZzoKCk9uIE1vbiwgMjAxOC0xMi0yNCBhdCAxNjowOCArMDgwMCwgWW9uZ3Fp YW5nIE5pdSB3cm90ZToKPiBUaGlzIHBhdGNoIGFkZCBjb21wb25lbnQgRElUSEVSCj4gCgpSZXZp ZXdlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4KCj4gU2lnbmVkLW9mZi1ieTogWW9u Z3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBtZWRpYXRlay5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCAzMiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29t cC5oIHwgIDIgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgYi9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jCj4gaW5kZXggNjNmNGIx ZS4uYTk3ZTI3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9kZHBfY29tcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw X2NvbXAuYwo+IEBAIC00Nyw2ICs0NywxMiBAQAo+ICAjZGVmaW5lIENDT1JSX1JFTEFZX01PREUJ CQlCSVQoMCkKPiAgI2RlZmluZSBESVNQX0NDT1JSX1NJWkUJCQkJMHgwMDMwCj4gIAo+ICsjZGVm aW5lIERJU1BfRElUSEVSX0VOCQkJCTB4MDAwMAo+ICsjZGVmaW5lIERJVEhFUl9FTgkJCQlCSVQo MCkKPiArI2RlZmluZSBESVNQX0RJVEhFUl9DRkcgICAgICAgICAgICAgICAgICAgICAgICAweDAw MjAKPiArI2RlZmluZSBESVRIRVJfUkVMQVlfTU9ERQkJCUJJVCgwKQo+ICsjZGVmaW5lIERJU1Bf RElUSEVSX1NJWkUJCQkweDAwMzAKPiArCj4gICNkZWZpbmUgRElTUF9HQU1NQV9FTgkJCQkweDAw MDAKPiAgI2RlZmluZSBESVNQX0dBTU1BX0NGRwkJCQkweDAwMjAKPiAgI2RlZmluZSBESVNQX0dB TU1BX1NJWkUJCQkJMHgwMDMwCj4gQEAgLTE1NSw2ICsxNjEsMjQgQEAgc3RhdGljIHZvaWQgbXRr X2Njb3JyX3N0b3Aoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkKPiAgCXdyaXRlbF9yZWxheGVk KDB4MCwgY29tcC0+cmVncyArIERJU1BfQ0NPUlJfRU4pOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9p ZCBtdGtfZGl0aGVyX2NvbmZpZyhzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBp bnQgdywKPiArCQkJICAgICAgdW5zaWduZWQgaW50IGgsIHVuc2lnbmVkIGludCB2cmVmcmVzaCwK PiArCQkJICAgICAgdW5zaWduZWQgaW50IGJwYykKPiArewo+ICsJd3JpdGVsKGggPDwgMTYgfCB3 LCBjb21wLT5yZWdzICsgRElTUF9ESVRIRVJfU0laRSk7Cj4gKwl3cml0ZWwoRElUSEVSX1JFTEFZ X01PREUsIGNvbXAtPnJlZ3MgKyBESVNQX0RJVEhFUl9DRkcpOwo+ICt9Cj4gKwo+ICtzdGF0aWMg dm9pZCBtdGtfZGl0aGVyX3N0YXJ0KHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXApCj4gK3sKPiAr CXdyaXRlbChESVRIRVJfRU4sIGNvbXAtPnJlZ3MgKyBESVNQX0RJVEhFUl9FTik7Cj4gK30KPiAr Cj4gK3N0YXRpYyB2b2lkIG10a19kaXRoZXJfc3RvcChzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21w KQo+ICt7Cj4gKwl3cml0ZWxfcmVsYXhlZCgweDAsIGNvbXAtPnJlZ3MgKyBESVNQX0RJVEhFUl9F Tik7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIG10a19nYW1tYV9jb25maWcoc3RydWN0IG10a19k ZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50IHcsCj4gIAkJCSAgICAgdW5zaWduZWQgaW50IGgs IHVuc2lnbmVkIGludCB2cmVmcmVzaCwKPiAgCQkJICAgICB1bnNpZ25lZCBpbnQgYnBjKQo+IEBA IC0yMDksNiArMjMzLDEyIEBAIHN0YXRpYyB2b2lkIG10a19nYW1tYV9zZXQoc3RydWN0IG10a19k ZHBfY29tcCAqY29tcCwKPiAgCS5zdG9wID0gbXRrX2Njb3JyX3N0b3AsCj4gIH07Cj4gIAo+ICtz dGF0aWMgY29uc3Qgc3RydWN0IG10a19kZHBfY29tcF9mdW5jcyBkZHBfZGl0aGVyID0gewo+ICsJ LmNvbmZpZyA9IG10a19kaXRoZXJfY29uZmlnLAo+ICsJLnN0YXJ0ID0gbXRrX2RpdGhlcl9zdGFy dCwKPiArCS5zdG9wID0gbXRrX2RpdGhlcl9zdG9wLAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBtdGtfZGRwX2NvbXBfZnVuY3MgZGRwX2dhbW1hID0gewo+ICAJLmdhbW1hX3NldCA9 IG10a19nYW1tYV9zZXQsCj4gIAkuY29uZmlnID0gbXRrX2dhbW1hX2NvbmZpZywKPiBAQCAtMjMz LDYgKzI2Myw3IEBAIHN0YXRpYyB2b2lkIG10a19nYW1tYV9zZXQoc3RydWN0IG10a19kZHBfY29t cCAqY29tcCwKPiAgCVtNVEtfRElTUF9DQ09SUl0gPSAiY2NvcnIiLAo+ICAJW01US19ESVNQX0FB TF0gPSAiYWFsIiwKPiAgCVtNVEtfRElTUF9HQU1NQV0gPSAiZ2FtbWEiLAo+ICsJW01US19ESVNQ X0RJVEhFUl0gPSAiZGl0aGVyIiwKPiAgCVtNVEtfRElTUF9VRk9FXSA9ICJ1Zm9lIiwKPiAgCVtN VEtfRFNJXSA9ICJkc2kiLAo+ICAJW01US19EUEldID0gImRwaSIsCj4gQEAgLTI1NSw2ICsyODYs NyBAQCBzdHJ1Y3QgbXRrX2RkcF9jb21wX21hdGNoIHsKPiAgCVtERFBfQ09NUE9ORU5UX0NDT1JS XQk9IHsgTVRLX0RJU1BfQ0NPUlIsCTAsICZkZHBfY2NvcnIgfSwKPiAgCVtERFBfQ09NUE9ORU5U X0NPTE9SMF0JPSB7IE1US19ESVNQX0NPTE9SLAkwLCBOVUxMIH0sCj4gIAlbRERQX0NPTVBPTkVO VF9DT0xPUjFdCT0geyBNVEtfRElTUF9DT0xPUiwJMSwgTlVMTCB9LAo+ICsJW0REUF9DT01QT05F TlRfRElUSEVSXQk9IHsgTVRLX0RJU1BfRElUSEVSLAkwLCAmZGRwX2RpdGhlciB9LAo+ICAJW0RE UF9DT01QT05FTlRfRFBJMF0JPSB7IE1US19EUEksCQkwLCBOVUxMIH0sCj4gIAlbRERQX0NPTVBP TkVOVF9EUEkxXQk9IHsgTVRLX0RQSSwJCTEsIE5VTEwgfSwKPiAgCVtERFBfQ09NUE9ORU5UX0RT STBdCT0geyBNVEtfRFNJLAkJMCwgTlVMTCB9LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5oIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fZGRwX2NvbXAuaAo+IGluZGV4IDY5MDU2NDcuLmIwMDY0YzUyIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5oCj4gQEAgLTI5LDYgKzI5 LDcgQEAgZW51bSBtdGtfZGRwX2NvbXBfdHlwZSB7Cj4gIAlNVEtfRElTUF9XRE1BLAo+ICAJTVRL X0RJU1BfQ09MT1IsCj4gIAlNVEtfRElTUF9DQ09SUiwKPiArCU1US19ESVNQX0RJVEhFUiwKPiAg CU1US19ESVNQX0FBTCwKPiAgCU1US19ESVNQX0dBTU1BLAo+ICAJTVRLX0RJU1BfVUZPRSwKPiBA QCAtNDgsNiArNDksNyBAQCBlbnVtIG10a19kZHBfY29tcF9pZCB7Cj4gIAlERFBfQ09NUE9ORU5U X0NDT1JSLAo+ICAJRERQX0NPTVBPTkVOVF9DT0xPUjAsCj4gIAlERFBfQ09NUE9ORU5UX0NPTE9S MSwKPiArCUREUF9DT01QT05FTlRfRElUSEVSLAo+ICAJRERQX0NPTVBPTkVOVF9EUEkwLAo+ICAJ RERQX0NPTVBPTkVOVF9EUEkxLAo+ICAJRERQX0NPTVBPTkVOVF9EU0kwLAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A85C43387 for ; Wed, 26 Dec 2018 09:13:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A127921741 for ; Wed, 26 Dec 2018 09:13:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mKgMYx2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A127921741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VpA+bkA5Vk8dxWAyuHO6+fVW2z0Xf/4H8XJlCk3BRos=; b=mKgMYx2WpyHoyP lgqblCPBFZrjllQ+ElpAwM50suK7/DDdOcytQqg5FDzqP/qpNcYxngywUf7FVXkXX0leM8BqMZt8G o927senRozn2oxnDc8buMwZ+u2X/DY6PaC1BIyNK4woGE3HGT+LEeEjSKY7bxW4A/2YfhxxWuq+5h 2f/cQyaDhvVg70kWvHarYpZtX94dD4wbl86jysYF4a4akR4PSUNZp77XptpG7wO+j+8xgp0FrgnH/ rsXHztItvywhYsyl5aZwzROzsUcduOzY20r0By8HBqFPUypYqqAhOI7RwNjminOQUzrwa3e5n8df1 tvh6m1k2mbksYcYZJ8Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gc5Fz-00007R-2M; Wed, 26 Dec 2018 09:13:39 +0000 Received: from [1.203.163.78] (helo=mailgw01.mediatek.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gc5Fv-00006G-PN; Wed, 26 Dec 2018 09:13:37 +0000 X-UUID: 8be6071c9e6a40d5a276a25421a8e802-20181226 X-UUID: 8be6071c9e6a40d5a276a25421a8e802-20181226 Received: from mtkcas35.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 550822703; Wed, 26 Dec 2018 17:13:22 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 26 Dec 2018 17:13:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 26 Dec 2018 17:13:19 +0800 Message-ID: <1545815599.20265.3.camel@mtksdaap41> Subject: Re: [PATCH 09/18] drm/mediatek: add component DITHER From: CK Hu To: Yongqiang Niu Date: Wed, 26 Dec 2018 17:13:19 +0800 In-Reply-To: <1545638931-24938-10-git-send-email-yongqiang.niu@mediatek.com> References: <1545638931-24938-1-git-send-email-yongqiang.niu@mediatek.com> <1545638931-24938-10-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181226_011336_251357_9D9FD2EE X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Mon, 2018-12-24 at 16:08 +0800, Yongqiang Niu wrote: > This patch add component DITHER > Reviewed-by: CK Hu > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 32 +++++++++++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 ++ > 2 files changed, 34 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 63f4b1e..a97e27b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -47,6 +47,12 @@ > #define CCORR_RELAY_MODE BIT(0) > #define DISP_CCORR_SIZE 0x0030 > > +#define DISP_DITHER_EN 0x0000 > +#define DITHER_EN BIT(0) > +#define DISP_DITHER_CFG 0x0020 > +#define DITHER_RELAY_MODE BIT(0) > +#define DISP_DITHER_SIZE 0x0030 > + > #define DISP_GAMMA_EN 0x0000 > #define DISP_GAMMA_CFG 0x0020 > #define DISP_GAMMA_SIZE 0x0030 > @@ -155,6 +161,24 @@ static void mtk_ccorr_stop(struct mtk_ddp_comp *comp) > writel_relaxed(0x0, comp->regs + DISP_CCORR_EN); > } > > +static void mtk_dither_config(struct mtk_ddp_comp *comp, unsigned int w, > + unsigned int h, unsigned int vrefresh, > + unsigned int bpc) > +{ > + writel(h << 16 | w, comp->regs + DISP_DITHER_SIZE); > + writel(DITHER_RELAY_MODE, comp->regs + DISP_DITHER_CFG); > +} > + > +static void mtk_dither_start(struct mtk_ddp_comp *comp) > +{ > + writel(DITHER_EN, comp->regs + DISP_DITHER_EN); > +} > + > +static void mtk_dither_stop(struct mtk_ddp_comp *comp) > +{ > + writel_relaxed(0x0, comp->regs + DISP_DITHER_EN); > +} > + > static void mtk_gamma_config(struct mtk_ddp_comp *comp, unsigned int w, > unsigned int h, unsigned int vrefresh, > unsigned int bpc) > @@ -209,6 +233,12 @@ static void mtk_gamma_set(struct mtk_ddp_comp *comp, > .stop = mtk_ccorr_stop, > }; > > +static const struct mtk_ddp_comp_funcs ddp_dither = { > + .config = mtk_dither_config, > + .start = mtk_dither_start, > + .stop = mtk_dither_stop, > +}; > + > static const struct mtk_ddp_comp_funcs ddp_gamma = { > .gamma_set = mtk_gamma_set, > .config = mtk_gamma_config, > @@ -233,6 +263,7 @@ static void mtk_gamma_set(struct mtk_ddp_comp *comp, > [MTK_DISP_CCORR] = "ccorr", > [MTK_DISP_AAL] = "aal", > [MTK_DISP_GAMMA] = "gamma", > + [MTK_DISP_DITHER] = "dither", > [MTK_DISP_UFOE] = "ufoe", > [MTK_DSI] = "dsi", > [MTK_DPI] = "dpi", > @@ -255,6 +286,7 @@ struct mtk_ddp_comp_match { > [DDP_COMPONENT_CCORR] = { MTK_DISP_CCORR, 0, &ddp_ccorr }, > [DDP_COMPONENT_COLOR0] = { MTK_DISP_COLOR, 0, NULL }, > [DDP_COMPONENT_COLOR1] = { MTK_DISP_COLOR, 1, NULL }, > + [DDP_COMPONENT_DITHER] = { MTK_DISP_DITHER, 0, &ddp_dither }, > [DDP_COMPONENT_DPI0] = { MTK_DPI, 0, NULL }, > [DDP_COMPONENT_DPI1] = { MTK_DPI, 1, NULL }, > [DDP_COMPONENT_DSI0] = { MTK_DSI, 0, NULL }, > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index 6905647..b0064c52 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -29,6 +29,7 @@ enum mtk_ddp_comp_type { > MTK_DISP_WDMA, > MTK_DISP_COLOR, > MTK_DISP_CCORR, > + MTK_DISP_DITHER, > MTK_DISP_AAL, > MTK_DISP_GAMMA, > MTK_DISP_UFOE, > @@ -48,6 +49,7 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_CCORR, > DDP_COMPONENT_COLOR0, > DDP_COMPONENT_COLOR1, > + DDP_COMPONENT_DITHER, > DDP_COMPONENT_DPI0, > DDP_COMPONENT_DPI1, > DDP_COMPONENT_DSI0, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel