Re: [B.A.T.M.A.N.] [PATCH 1/1] batman-adv: Always flood IGMP/MLD reports

[Simon Wunderlich <sw@simonwunderlich.de>]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sunday 21 June 2015 15:36:17 Linus Lüssing wrote:
> With this patch IGMP or MLD reports are always flooded. This is
> necessary for the upcoming bridge integration:
> 
> An IGMPv2/MLDv1 querier does not actively join the multicast group the
> reports are sent to. Because of this, this would lead to snooping
> bridges/switches not being able to learn of multicast listeners in the
> mesh and wrongly shutting down ports for multicast traffic to the mesh,
> leading to packet loss.
> 
> This patch increments the multicast tvlv version number to 2.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>

After discussing with Linus, I agree that we should use the more simple 
approach and focus our optimizations effort on actual multicast traffic instead 
of the reports. I think this approach is much more simpler and easier to debug 
- since the multicast subject itself is complex enough on its own.

The patch is pretty much straight forward, most of the code is actually 
adopted from the Linux kernel. Therefore:

Acked-by: Simon Wunderlich <sw@simonwunderlich.de>

Thank you!
    Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]