From: Bart Van Assche <bvanassche@acm.org>
To: Weiping Zhang <zhangweiping@didiglobal.com>, axboe@kernel.dk
Cc: hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v4] block: add documentation for io_timeout
Date: Thu, 03 Jan 2019 09:13:12 -0800 [thread overview]
Message-ID: <1546535592.163063.7.camel@acm.org> (raw)
In-Reply-To: <20181226035613.GA16642@192.168.3.9>
On Wed, 2018-12-26 at 11:56 +0800, Weiping Zhang wrote:
> Add documentation for /sys/block/<disk>/queue/io_timeout.
>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> Documentation/ABI/testing/sysfs-block | 9 +++++++++
> Documentation/block/queue-sysfs.txt | 7 +++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-block b/Documentation/ABI/testing/sysfs-block
> index 7710d4022b19..dfad7427817c 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -279,3 +279,12 @@ Description:
> size in 512B sectors of the zones of the device, with
> the eventual exception of the last zone of the device
> which may be smaller.
> +
> +What: /sys/block/<disk>/queue/io_timeout
> +Date: November 2018
> +Contact: Weiping Zhang <zhangweiping@didiglobal.com>
> +Description:
> + io_timeout is the request timeout in milliseconds. If a request
> + does not complete in this time then the block driver timeout
> + handler is invoked. That timeout handler can decide to retry
> + the request, to fail it or to start a device recovery strategy.
> diff --git a/Documentation/block/queue-sysfs.txt b/Documentation/block/queue-sysfs.txt
> index 39e286d7afc9..83b457e24bba 100644
> --- a/Documentation/block/queue-sysfs.txt
> +++ b/Documentation/block/queue-sysfs.txt
> @@ -67,6 +67,13 @@ If set to a value larger than 0, the kernel will put the process issuing
> IO to sleep for this amount of microseconds before entering classic
> polling.
>
> +io_timeout (RW)
> +---------------
> +io_timeout is the request timeout in milliseconds. If a request does not
> +complete in this time then the block driver timeout handler is invoked.
> +That timeout handler can decide to retry the request, to fail it or to start
> +a device recovery strategy.
> +
> iostats (RW)
> -------------
> This file is used to control (on/off) the iostats accounting of the
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-01-03 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 3:56 [PATCH v4] block: add documentation for io_timeout Weiping Zhang
2019-01-03 17:13 ` Bart Van Assche [this message]
2019-01-05 2:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546535592.163063.7.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.