From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller Date: Fri, 4 Jan 2019 11:00:07 +0800 Message-ID: <1546570807.585.31.camel@mhfsdcap03> References: <1545896066-897-1-git-send-email-min.guo@mediatek.com> <1545896066-897-2-git-send-email-min.guo@mediatek.com> <20190103221414.GA14639@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190103221414.GA14639@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Thu, 2019-01-03 at 16:14 -0600, Rob Herring wrote: > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > > > Signed-off-by: Min Guo > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 49 ++++++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..e899c9b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,49 @@ > > +MediaTek musb DRC/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,-musb", > > + "mediatek,mtk-musb", soc-model is the name of SoC, such as > > + mt2701, when using "mediatek,mtk-musb" compatible string, you > > + need SoC specific ones in addition, one of: > > + - "mediatek,mt2701-musb" > > This isn't very clear. Just drop the > compatible: should be one of: > "mediatek,mt2701-musb" > ... > followed by "mediatek,mtk-musb" I will modify it in the next patch. > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > -names is pointless when there is only one. The MUSB core driver has two interrupts, one is for MAC, another for DMA, but on MTK platform, there is only a MAC interrupt, here following the binding of MUSB core driver. > > + - phys : PHY specifier for the OTG phy > > + - phy-names : should be "usb2-phy" > > Same here. I will modify it in the next patch. > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main","mcu","univpll" > > space needed after each comma. I will modify it in the next patch. > > + for clocks of controller > > + > > +Optional properties: > > + - extcon : external connector for VBUS and IDPIN changes detection, > > + needed when supports dual-role mode. > > Don't use extcon for new bindings. The usb-connector binding should be > used instead. This is used to detect the changes of the IDPIN and VBUS, the change events are provided by other drivers, such as extcon-usb-gpio.c, and then switch MUSB controller to host or device mode, but the usb-connector can't detect these changes. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode. > > The controller is powered from Vbus? Probably not. This belongs in the > connector or maybe the phy (if the phy is powered from Vbus). The Vbus is used to provide 5V voltage to the connected device when the controller works as host mode. > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb"; > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + phy-names = "usb2-phy"; > > + vbus-supply = <&usb_vbus>; > > + extcon = <&extcon_usb>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > +}; > > -- > > 1.9.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1546570807.585.31.camel@mhfsdcap03> Date: Fri, 4 Jan 2019 11:00:07 +0800 To: Rob Herring Cc: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: T24gVGh1LCAyMDE5LTAxLTAzIGF0IDE2OjE0IC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBUaHUsIERlYyAyNywgMjAxOCBhdCAwMzozNDoyM1BNICswODAwLCBtaW4uZ3VvQG1lZGlhdGVr LmNvbSB3cm90ZToKPiA+IEZyb206IE1pbiBHdW8gPG1pbi5ndW9AbWVkaWF0ZWsuY29tPgo+ID4g Cj4gPiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgTWVkaWFUZWsgbXVzYiBjb250cm9sbGVyIGluCj4g PiBob3N0LCBwZXJpcGhlcmFsIGFuZCBvdGcgbW9kZQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBN aW4gR3VvIDxtaW4uZ3VvQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4gIC4uLi9kZXZpY2V0cmVl L2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4dCAgICAgIHwgNDkgKysrKysrKysrKysrKysr KysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRl IG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0 ZWssbXVzYi50eHQKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWssbXVzYi50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG11c2IudHh0Cj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+ID4gaW5kZXggMDAwMDAwMC4uZTg5OWM5Ygo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4dAo+ ID4gQEAgLTAsMCArMSw0OSBAQAo+ID4gK01lZGlhVGVrIG11c2IgRFJDL09URyBjb250cm9sbGVy Cj4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gKwo+ ID4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiArIC0gY29tcGF0aWJsZSAgICAgIDogc2hvdWxk IGJlICJtZWRpYXRlayw8c29jLW1vZGVsPi1tdXNiIiwKPiA+ICsgICAibWVkaWF0ZWssbXRrLW11 c2IiLCBzb2MtbW9kZWwgaXMgdGhlIG5hbWUgb2YgU29DLCBzdWNoIGFzCj4gPiArICAgbXQyNzAx LCB3aGVuIHVzaW5nICJtZWRpYXRlayxtdGstbXVzYiIgY29tcGF0aWJsZSBzdHJpbmcsIHlvdQo+ ID4gKyAgIG5lZWQgU29DIHNwZWNpZmljIG9uZXMgaW4gYWRkaXRpb24sIG9uZSBvZjoKPiA+ICsg ICAtICJtZWRpYXRlayxtdDI3MDEtbXVzYiIKPiAKPiBUaGlzIGlzbid0IHZlcnkgY2xlYXIuIEp1 c3QgZHJvcCB0aGUgPHNvYy1tb2RlbCBhbmQgZW51bWVyYXRlIHRoZSBTb0NzOgo+IAo+IGNvbXBh dGlibGU6IHNob3VsZCBiZSBvbmUgb2Y6Cj4gICAgICJtZWRpYXRlayxtdDI3MDEtbXVzYiIKPiAg ICAgLi4uCj4gICBmb2xsb3dlZCBieSAibWVkaWF0ZWssbXRrLW11c2IiCkkgd2lsbCBtb2RpZnkg aXQgaW4gdGhlIG5leHQgcGF0Y2guCgo+ID4gKyAtIHJlZyAgICAgICAgICAgICA6IHNwZWNpZmll cyBwaHlzaWNhbCBiYXNlIGFkZHJlc3MgYW5kIHNpemUgb2YKPiA+ICsgICB0aGUgcmVnaXN0ZXJz Cj4gPiArIC0gaW50ZXJydXB0cyAgICAgIDogaW50ZXJydXB0IHVzZWQgYnkgbXVzYiBjb250cm9s bGVyCj4gPiArIC0gaW50ZXJydXB0LW5hbWVzIDogbXVzdCBiZSAibWMiCj4gCj4gLW5hbWVzIGlz IHBvaW50bGVzcyB3aGVuIHRoZXJlIGlzIG9ubHkgb25lLgpUaGUgTVVTQiBjb3JlIGRyaXZlciBo YXMgdHdvIGludGVycnVwdHMsIG9uZSBpcyBmb3IgTUFDLCBhbm90aGVyIGZvciBETUEsCmJ1dCBv biBNVEsgcGxhdGZvcm0sIHRoZXJlIGlzIG9ubHkgYSBNQUMgaW50ZXJydXB0LCBoZXJlIGZvbGxv d2luZyB0aGUgYmluZGluZwpvZiBNVVNCIGNvcmUgZHJpdmVyLgoKPiA+ICsgLSBwaHlzICAgICAg ICAgICAgOiBQSFkgc3BlY2lmaWVyIGZvciB0aGUgT1RHIHBoeQo+ID4gKyAtIHBoeS1uYW1lcyAg ICAgICA6IHNob3VsZCBiZSAidXNiMi1waHkiCj4gCj4gU2FtZSBoZXJlLgpJIHdpbGwgbW9kaWZ5 IGl0IGluIHRoZSBuZXh0IHBhdGNoLgoKPiA+ICsgLSBkcl9tb2RlICAgICAgICAgOiBzaG91bGQg YmUgb25lIG9mICJob3N0IiwgInBlcmlwaGVyYWwiIG9yICJvdGciLAo+ID4gKyAgIHJlZmVyIHRv IHVzYi9nZW5lcmljLnR4dAo+ID4gKyAtIGNsb2NrcyAgICAgICAgICA6IGEgbGlzdCBvZiBwaGFu ZGxlICsgY2xvY2stc3BlY2lmaWVyIHBhaXJzLCBvbmUgZm9yCj4gPiArICAgZWFjaCBlbnRyeSBp biBjbG9jay1uYW1lcwo+ID4gKyAtIGNsb2NrLW5hbWVzICAgICA6IG11c3QgY29udGFpbiAibWFp biIsIm1jdSIsInVuaXZwbGwiCj4gCj4gc3BhY2UgbmVlZGVkIGFmdGVyIGVhY2ggY29tbWEuCkkg d2lsbCBtb2RpZnkgaXQgaW4gdGhlIG5leHQgcGF0Y2guCgo+ID4gKyAgIGZvciBjbG9ja3Mgb2Yg Y29udHJvbGxlcgo+ID4gKwo+ID4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPiArIC0gZXh0Y29u IDogZXh0ZXJuYWwgY29ubmVjdG9yIGZvciBWQlVTIGFuZCBJRFBJTiBjaGFuZ2VzIGRldGVjdGlv biwKPiA+ICsgICBuZWVkZWQgd2hlbiBzdXBwb3J0cyBkdWFsLXJvbGUgbW9kZS4KPiAKPiBEb24n dCB1c2UgZXh0Y29uIGZvciBuZXcgYmluZGluZ3MuIFRoZSB1c2ItY29ubmVjdG9yIGJpbmRpbmcg c2hvdWxkIGJlIAo+IHVzZWQgaW5zdGVhZC4KVGhpcyBpcyB1c2VkIHRvIGRldGVjdCB0aGUgY2hh bmdlcyBvZiB0aGUgSURQSU4gYW5kIFZCVVMsIHRoZSBjaGFuZ2UKZXZlbnRzIGFyZSBwcm92aWRl ZCBieSBvdGhlciBkcml2ZXJzLCBzdWNoIGFzIGV4dGNvbi11c2ItZ3Bpby5jLCBhbmQKdGhlbiBz d2l0Y2ggTVVTQiBjb250cm9sbGVyIHRvIGhvc3Qgb3IgZGV2aWNlIG1vZGUsIGJ1dCB0aGUKdXNi LWNvbm5lY3RvciBjYW4ndCBkZXRlY3QgdGhlc2UgY2hhbmdlcy4KCj4gPiArIC0gdmJ1cy1zdXBw bHkgOiByZWZlcmVuY2UgdG8gdGhlIFZCVVMgcmVndWxhdG9yLCBuZWVkZWQgd2hlbiBzdXBwb3J0 cwo+ID4gKyAgIGR1YWwtcm9sZSBtb2RlLgo+IAo+IFRoZSBjb250cm9sbGVyIGlzIHBvd2VyZWQg ZnJvbSBWYnVzPyBQcm9iYWJseSBub3QuIFRoaXMgYmVsb25ncyBpbiB0aGUgCj4gY29ubmVjdG9y IG9yIG1heWJlIHRoZSBwaHkgKGlmIHRoZSBwaHkgaXMgcG93ZXJlZCBmcm9tIFZidXMpLgpUaGUg VmJ1cyBpcyB1c2VkIHRvIHByb3ZpZGUgNVYgdm9sdGFnZSB0byB0aGUgY29ubmVjdGVkIGRldmlj ZSB3aGVuIHRoZQpjb250cm9sbGVyIHdvcmtzIGFzIGhvc3QgbW9kZS4KCj4gPiArIC0gcG93ZXIt ZG9tYWlucyAgIDogYSBwaGFuZGxlIHRvIFVTQiBwb3dlciBkb21haW4gbm9kZSB0byBjb250cm9s IFVTQidzCj4gPiArICAgTVRDTU9TCj4gPiArCj4gPiArRXhhbXBsZToKPiA+ICsKPiA+ICt1c2Iy OiB1c2JAMTEyMDAwMDAgewo+ID4gKwljb21wYXRpYmxlID0gIm1lZGlhdGVrLG10MjcwMS1tdXNi IjsKPiA+ICsJCSJtZWRpYXRlayxtdGstbXVzYiI7Cj4gPiArCXJlZyA9IDwwIDB4MTEyMDAwMDAg MCAweDEwMDA+Owo+ID4gKwlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzIgSVJRX1RZUEVfTEVWRUxf TE9XPjsKPiA+ICsJaW50ZXJydXB0LW5hbWVzID0gIm1jIjsKPiA+ICsJcGh5cyA9IDwmdTJwb3J0 MiBQSFlfVFlQRV9VU0IyPjsKPiA+ICsJcGh5LW5hbWVzID0gInVzYjItcGh5IjsKPiA+ICsJdmJ1 cy1zdXBwbHkgPSA8JnVzYl92YnVzPjsKPiA+ICsJZXh0Y29uID0gPCZleHRjb25fdXNiPjsKPiA+ ICsJZHJfbW9kZSA9ICJvdGciOwo+ID4gKwljbG9ja3MgPSA8JnBlcmljZmcgQ0xLX1BFUklfVVNC MD4sCj4gPiArCQkgPCZwZXJpY2ZnIENMS19QRVJJX1VTQjBfTUNVPiwKPiA+ICsJCSA8JnBlcmlj ZmcgQ0xLX1BFUklfVVNCX1NMVj47Cj4gPiArCWNsb2NrLW5hbWVzID0gIm1haW4iLCJtY3UiLCJ1 bml2cGxsIjsKPiA+ICsJcG93ZXItZG9tYWlucyA9IDwmc2Nwc3lzIE1UMjcwMV9QT1dFUl9ET01B SU5fSUZSX01TQz47Cj4gPiArfTsKPiA+IC0tIAo+ID4gMS45LjEKPiA+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF297C43387 for ; Fri, 4 Jan 2019 03:00:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF3EF2184B for ; Fri, 4 Jan 2019 03:00:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m8B4mO7V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF3EF2184B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SbQKui7Mtj/uXd64aczOXeK2euTi316pC52C8h2jtGk=; b=m8B4mO7VK65u+2 NKLvjRctOBRRo83jqXv0fV9BNFbmlIuKOSF2/9OZgOCD6my4Kjqh56FCxeMO3dtkVcb0HzzvXsFac Ewo8NpyRYmA9aWHcIDhnVN/FFZavWwarbM3PDJTNOus5XdODDCSXFceH8UplsRMvvpg9CPrqHe+3Y s5Jd5pMV7aiU4YCEdUmjGo2MngdXf+HJsBrPVhdA7djM40dATJwqRfR5Y7GrN1xsCVXxEDRzP8Ijv LFuQfI65DsE7afb/1aAEdaXN4RUvlly1+7DRXqn/bMLt49Dgmm7qiKt+p0Jb75+K5cDupuGphOy0x CBb2rM4d9nEKhTgnElZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gfFip-0002aK-IQ; Fri, 04 Jan 2019 03:00:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gfFij-0002YT-5N; Fri, 04 Jan 2019 03:00:27 +0000 X-UUID: b72bcc1349d5406a9c1c499cab1e5e2a-20190103 X-UUID: b72bcc1349d5406a9c1c499cab1e5e2a-20190103 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 745304877; Thu, 03 Jan 2019 19:00:12 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 3 Jan 2019 19:00:10 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 4 Jan 2019 11:00:08 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 4 Jan 2019 11:00:07 +0800 Message-ID: <1546570807.585.31.camel@mhfsdcap03> Subject: Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring Date: Fri, 4 Jan 2019 11:00:07 +0800 In-Reply-To: <20190103221414.GA14639@bogus> References: <1545896066-897-1-git-send-email-min.guo@mediatek.com> <1545896066-897-2-git-send-email-min.guo@mediatek.com> <20190103221414.GA14639@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190103_190025_205822_A355DCAF X-CRM114-Status: GOOD ( 26.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, Bin Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-01-03 at 16:14 -0600, Rob Herring wrote: > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > > > Signed-off-by: Min Guo > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 49 ++++++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..e899c9b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,49 @@ > > +MediaTek musb DRC/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,-musb", > > + "mediatek,mtk-musb", soc-model is the name of SoC, such as > > + mt2701, when using "mediatek,mtk-musb" compatible string, you > > + need SoC specific ones in addition, one of: > > + - "mediatek,mt2701-musb" > > This isn't very clear. Just drop the > compatible: should be one of: > "mediatek,mt2701-musb" > ... > followed by "mediatek,mtk-musb" I will modify it in the next patch. > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > -names is pointless when there is only one. The MUSB core driver has two interrupts, one is for MAC, another for DMA, but on MTK platform, there is only a MAC interrupt, here following the binding of MUSB core driver. > > + - phys : PHY specifier for the OTG phy > > + - phy-names : should be "usb2-phy" > > Same here. I will modify it in the next patch. > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main","mcu","univpll" > > space needed after each comma. I will modify it in the next patch. > > + for clocks of controller > > + > > +Optional properties: > > + - extcon : external connector for VBUS and IDPIN changes detection, > > + needed when supports dual-role mode. > > Don't use extcon for new bindings. The usb-connector binding should be > used instead. This is used to detect the changes of the IDPIN and VBUS, the change events are provided by other drivers, such as extcon-usb-gpio.c, and then switch MUSB controller to host or device mode, but the usb-connector can't detect these changes. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode. > > The controller is powered from Vbus? Probably not. This belongs in the > connector or maybe the phy (if the phy is powered from Vbus). The Vbus is used to provide 5V voltage to the connected device when the controller works as host mode. > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb"; > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + phy-names = "usb2-phy"; > > + vbus-supply = <&usb_vbus>; > > + extcon = <&extcon_usb>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > +}; > > -- > > 1.9.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel