From: Laurence Oberman <loberman@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
John Pittman <jpittman@redhat.com>,
axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] null_blk: add zoned config support information
Date: Fri, 04 Jan 2019 11:58:42 -0500 [thread overview]
Message-ID: <1546621122.2666.4.camel@redhat.com> (raw)
In-Reply-To: <1546620417.163063.45.camel@acm.org>
On Fri, 2019-01-04 at 08:46 -0800, Bart Van Assche wrote:
> On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> > static inline int null_zone_init(struct nullb_device *dev)
> > {
> > + pr_info("CONFIG_BLK_DEV_ZONED not enabled\n");
> > return -EINVAL;
> > }
>
> Have you considered to use pr_err() instead of pr_info()?
>
> Thanks,
>
> Bart.
Bart, good point, Thank you
Laurence
next prev parent reply other threads:[~2019-01-04 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 15:42 [PATCH] null_blk: add zoned config support information John Pittman
2019-01-04 15:59 ` Laurence Oberman
2019-01-04 16:46 ` Bart Van Assche
2019-01-04 16:58 ` Laurence Oberman [this message]
2019-01-04 20:37 ` John Pittman
2019-01-04 20:49 ` Bart Van Assche
2019-01-04 21:07 ` John Pittman
2019-01-06 19:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546621122.2666.4.camel@redhat.com \
--to=loberman@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jpittman@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.