Re: [PATCH 4.9] libceph: fix CEPH_FEATURE_CEPHX_V2 check in calc_signature()

[Ben Hutchings <ben.hutchings@codethink.co.uk>]

On Wed, 2019-01-09 at 15:17 +0100, Ilya Dryomov wrote:
> Upstream commit cc255c76c70f ("libceph: implement CEPHX_V2 calculation
> mode") was adjusted incorrectly: CEPH_FEATURE_CEPHX_V2 if condition got
> inverted, thus breaking 4.9.144 and later kernels for all setups that
> use cephx.

Whoa, sorry about that.

Ben.

> Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> ---
>  net/ceph/auth_x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ceph/auth_x.c b/net/ceph/auth_x.c
> index 29e23b5cb2ed..a4896e4a1c9a 100644
> --- a/net/ceph/auth_x.c
> +++ b/net/ceph/auth_x.c
> @@ -804,7 +804,7 @@ static int calc_signature(struct ceph_x_authorizer *au, struct ceph_msg *msg,
>  	void *enc_buf = au->enc_buf;
>  	int ret;
>  
> -	if (msg->con->peer_features & CEPH_FEATURE_CEPHX_V2) {
> +	if (!(msg->con->peer_features & CEPH_FEATURE_CEPHX_V2)) {
>  		struct {
>  			__le32 len;
>  			__le32 header_crc;
-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom