From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v9,1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support From: Long Cheng Message-Id: <1547110225.3831.24.camel@mhfsdcap03> Date: Thu, 10 Jan 2019 16:50:25 +0800 To: Randy Dunlap Cc: Nicolas Boichat , Vinod Koul , Rob Herring , Mark Rutland , Ryder Lee , Sean Wang , Matthias Brugger , Dan Williams , Greg Kroah-Hartman , Jiri Slaby , Sean Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm Mailing List , linux-mediatek@lists.infradead.org, lkml , linux-serial@vger.kernel.org, srv_heupstream@mediatek.com, Yingjoe Chen , YT Shen , Zhenbao Liu List-ID: T24gV2VkLCAyMDE5LTAxLTAyIGF0IDE4OjAzIC0wODAwLCBSYW5keSBEdW5sYXAgd3JvdGU6Cj4g SGksCj4gCj4gV2hpbGUgeW91IGFyZSBtYWtpbmcgY2hhbmdlcywgaGVyZSBhcmUgYSBmZXcgbW9y ZToKPiAKCmhpCgpPSywgdGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLgoKPiAKPiBPbiAxLzIvMTkg NTozOSBQTSwgTmljb2xhcyBCb2ljaGF0IHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv ZG1hL21lZGlhdGVrL0tjb25maWcgYi9kcml2ZXJzL2RtYS9tZWRpYXRlay9LY29uZmlnCj4gPiBp bmRleCAyN2JhYzBiLi4xYTUyM2M4NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZG1hL21lZGlh dGVrL0tjb25maWcKPiA+ICsrKyBiL2RyaXZlcnMvZG1hL21lZGlhdGVrL0tjb25maWcKPiA+IEBA IC0xLDQgKzEsMTUgQEAKPiA+IAo+ID4gK2NvbmZpZyBETUFfTVRLX1VBUlQKPiA+ICsgICAgICAg dHJpc3RhdGUgIk1lZGlhVGVrIFNvQ3MgQVBETUEgc3VwcG9ydCBmb3IgVUFSVCIKPiA+ICsgICAg ICAgZGVwZW5kcyBvbiBPRiAmJiBTRVJJQUxfODI1MF9NVDY1NzcKPiA+ICsgICAgICAgc2VsZWN0 IERNQV9FTkdJTkUKPiA+ICsgICAgICAgc2VsZWN0IERNQV9WSVJUVUFMX0NIQU5ORUxTCj4gPiAr ICAgICAgIGhlbHAKPiA+ICsgICAgICAgICBTdXBwb3J0IGZvciB0aGUgVUFSVCBETUEgZW5naW5l IGZvdW5kIG9uIE1lZGlhVGVrIE1USyBTb0NzLgo+ID4gKyAgICAgICAgIHdoZW4gU0VSSUFMXzgy NTBfTVQ2NTc3IGlzIGVuYWJsZWQsIGFuZCBpZiB5b3Ugd2FudCB0byB1c2UgRE1BLAo+IAo+IAkg ICAgV2hlbgo+IAo+ID4gKyAgICAgICAgIHlvdSBjYW4gZW5hYmxlIHRoZSBjb25maWcuIHRoZSBE TUEgZW5naW5lIGNhbiBvbmx5IGJlIHVzZWQKPiAKPiAJICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFRoZQo+IAo+ID4gKyAgICAgICAgIHdpdGggTWVkaWFUZWsgU29Dcy4KPiA+ICsKPiAK CmFib3ZlLCBpIHdpbGwgbW9kaWZ5LgoKPiBBbHNvLCB1c2UgdGFicyB0byBpbmRlbnQgaW5zdGVh ZCBvZiBzcGFjZXMuCj4gVGhlIGxpbmVzICh0cmlzdGF0ZSwgZGVwZW5kcywgc2VsZWN0LCBhbmQg aGVscCkgc2hvdWxkIGJlIGluZGVudGVkIHdpdGggb25lIHRhYi4KPiBUaGUgaGVscCB0ZXh0IGxp bmVzIHNob3VsZCBiZSBpbmRlbnRlZCB3aXRoIG9uZSB0YWIgKyAyIHNwYWNlcy4KPiAKCmluIG15 IHBhdGNoLCBpIGFscmVhZHkgZG8gdGhpcy4gU28gZG9uJ3QgbmVlZCBtb2RpZnkuCgo+ID4gIGNv bmZpZyBNVEtfSFNETUEKPiA+ICAgICAgICAgdHJpc3RhdGUgIk1lZGlhVGVrIEhpZ2gtU3BlZWQg RE1BIGNvbnRyb2xsZXIgc3VwcG9ydCIKPiA+ICAgICAgICAgZGVwZW5kcyBvbiBBUkNIX01FRElB VEVLIHx8IENPTVBJTEVfVEVTVAo+IAo+IAo+IHRoYW5rcywK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Long Cheng Subject: Re: [PATCH v9 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support Date: Thu, 10 Jan 2019 16:50:25 +0800 Message-ID: <1547110225.3831.24.camel@mhfsdcap03> References: <1546395178-8880-1-git-send-email-long.cheng@mediatek.com> <1546395178-8880-2-git-send-email-long.cheng@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Nicolas Boichat , Vinod Koul , Rob Herring , Mark Rutland , Ryder Lee , Sean Wang , Matthias Brugger , Dan Williams , Greg Kroah-Hartman , Jiri Slaby , Sean Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm Mailing List , linux-mediatek@lists.infradead.org, lkml , linux-serial@vger.kernel.org, srv_heupstream@mediatek.com, Yingjoe Chen , YT Shen , Zhen List-Id: linux-mediatek@lists.infradead.org On Wed, 2019-01-02 at 18:03 -0800, Randy Dunlap wrote: > Hi, > > While you are making changes, here are a few more: > hi OK, thanks for your comments. > > On 1/2/19 5:39 PM, Nicolas Boichat wrote: > > diff --git a/drivers/dma/mediatek/Kconfig b/drivers/dma/mediatek/Kconfig > > index 27bac0b..1a523c87 100644 > > --- a/drivers/dma/mediatek/Kconfig > > +++ b/drivers/dma/mediatek/Kconfig > > @@ -1,4 +1,15 @@ > > > > +config DMA_MTK_UART > > + tristate "MediaTek SoCs APDMA support for UART" > > + depends on OF && SERIAL_8250_MT6577 > > + select DMA_ENGINE > > + select DMA_VIRTUAL_CHANNELS > > + help > > + Support for the UART DMA engine found on MediaTek MTK SoCs. > > + when SERIAL_8250_MT6577 is enabled, and if you want to use DMA, > > When > > > + you can enable the config. the DMA engine can only be used > > The > > > + with MediaTek SoCs. > > + > above, i will modify. > Also, use tabs to indent instead of spaces. > The lines (tristate, depends, select, and help) should be indented with one tab. > The help text lines should be indented with one tab + 2 spaces. > in my patch, i already do this. So don't need modify. > > config MTK_HSDMA > > tristate "MediaTek High-Speed DMA controller support" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > > thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4391AC43387 for ; Thu, 10 Jan 2019 08:50:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1322620879 for ; Thu, 10 Jan 2019 08:50:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="guDXwI2N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1322620879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=46iQEaEhvPfA6IzsxgsknPM5RAR97ZXYZida6TnIqSY=; b=guDXwI2Niktvxa iHpcgJSx7epswjXPDIAbu2NGRvonFiq/VrXctdbpIoJRIcKWIBoZs5oifGlopzMkZsRwX2UHVzw6S 4tzKHebU5hgWGbp4i85DZOzPmCJrvpyGGswXbFhg3qveEuoXSGOQcxMxYF+VJeR8GtFMUsG9ZPkU0 ENIa4WTVzQcaXuRH2QAfDvDBG0IscKbwr3Rk6Km+w2RfilFY/rmR3rHQiOrfGXBgb3rYG9z0JjVv8 u6CZRRmpEsrrJFcUTKsWcOyaPKuvUAv/Ar3vvPVVVVqY2pfe0oMjW1SZLVktDKufOAmSxQP2W8Tda 4yb2nb5weafxihW8bOtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghW2t-0005vs-4a; Thu, 10 Jan 2019 08:50:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghW2p-0005vK-Ru; Thu, 10 Jan 2019 08:50:33 +0000 X-UUID: bda1fd1629bf4020b590c8eacdd9c33a-20190110 X-UUID: bda1fd1629bf4020b590c8eacdd9c33a-20190110 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1920418038; Thu, 10 Jan 2019 00:50:30 -0800 Received: from mtkmbs03n2.mediatek.inc (172.21.101.182) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 00:50:28 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 16:50:26 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 10 Jan 2019 16:50:25 +0800 Message-ID: <1547110225.3831.24.camel@mhfsdcap03> Subject: Re: [PATCH v9 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support From: Long Cheng To: Randy Dunlap Date: Thu, 10 Jan 2019 16:50:25 +0800 In-Reply-To: References: <1546395178-8880-1-git-send-email-long.cheng@mediatek.com> <1546395178-8880-2-git-send-email-long.cheng@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: C0E1301CD85C79D6C4D6D9D004E32AB58BE59366EFE59482B05044DE530829012000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190110_005031_910497_8B3D862A X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Nicolas Boichat , Zhenbao Liu , linux-serial@vger.kernel.org, srv_heupstream@mediatek.com, Greg Kroah-Hartman , Sean Wang , lkml , Rob Herring , YT Shen , dmaengine@vger.kernel.org, Vinod Koul , Ryder Lee , linux-mediatek@lists.infradead.org, Sean Wang , Jiri Slaby , Matthias Brugger , Yingjoe Chen , Dan Williams , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2019-01-02 at 18:03 -0800, Randy Dunlap wrote: > Hi, > > While you are making changes, here are a few more: > hi OK, thanks for your comments. > > On 1/2/19 5:39 PM, Nicolas Boichat wrote: > > diff --git a/drivers/dma/mediatek/Kconfig b/drivers/dma/mediatek/Kconfig > > index 27bac0b..1a523c87 100644 > > --- a/drivers/dma/mediatek/Kconfig > > +++ b/drivers/dma/mediatek/Kconfig > > @@ -1,4 +1,15 @@ > > > > +config DMA_MTK_UART > > + tristate "MediaTek SoCs APDMA support for UART" > > + depends on OF && SERIAL_8250_MT6577 > > + select DMA_ENGINE > > + select DMA_VIRTUAL_CHANNELS > > + help > > + Support for the UART DMA engine found on MediaTek MTK SoCs. > > + when SERIAL_8250_MT6577 is enabled, and if you want to use DMA, > > When > > > + you can enable the config. the DMA engine can only be used > > The > > > + with MediaTek SoCs. > > + > above, i will modify. > Also, use tabs to indent instead of spaces. > The lines (tristate, depends, select, and help) should be indented with one tab. > The help text lines should be indented with one tab + 2 spaces. > in my patch, i already do this. So don't need modify. > > config MTK_HSDMA > > tristate "MediaTek High-Speed DMA controller support" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > > thanks, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B17C43387 for ; Thu, 10 Jan 2019 08:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79DC720879 for ; Thu, 10 Jan 2019 08:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727702AbfAJIue (ORCPT ); Thu, 10 Jan 2019 03:50:34 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:56657 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727372AbfAJIue (ORCPT ); Thu, 10 Jan 2019 03:50:34 -0500 X-UUID: 70060d12bb194ef7b0aeb2f78d44d92e-20190110 X-UUID: 70060d12bb194ef7b0aeb2f78d44d92e-20190110 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1420587663; Thu, 10 Jan 2019 16:50:28 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 16:50:26 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 10 Jan 2019 16:50:25 +0800 Message-ID: <1547110225.3831.24.camel@mhfsdcap03> Subject: Re: [PATCH v9 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support From: Long Cheng To: Randy Dunlap CC: Nicolas Boichat , Vinod Koul , Rob Herring , Mark Rutland , Ryder Lee , Sean Wang , Matthias Brugger , Dan Williams , Greg Kroah-Hartman , Jiri Slaby , Sean Wang , , , linux-arm Mailing List , , lkml , , , Yingjoe Chen , "YT Shen" , Zhenbao Liu Date: Thu, 10 Jan 2019 16:50:25 +0800 In-Reply-To: References: <1546395178-8880-1-git-send-email-long.cheng@mediatek.com> <1546395178-8880-2-git-send-email-long.cheng@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-TM-SNTS-SMTP: C0E1301CD85C79D6C4D6D9D004E32AB58BE59366EFE59482B05044DE530829012000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-01-02 at 18:03 -0800, Randy Dunlap wrote: > Hi, > > While you are making changes, here are a few more: > hi OK, thanks for your comments. > > On 1/2/19 5:39 PM, Nicolas Boichat wrote: > > diff --git a/drivers/dma/mediatek/Kconfig b/drivers/dma/mediatek/Kconfig > > index 27bac0b..1a523c87 100644 > > --- a/drivers/dma/mediatek/Kconfig > > +++ b/drivers/dma/mediatek/Kconfig > > @@ -1,4 +1,15 @@ > > > > +config DMA_MTK_UART > > + tristate "MediaTek SoCs APDMA support for UART" > > + depends on OF && SERIAL_8250_MT6577 > > + select DMA_ENGINE > > + select DMA_VIRTUAL_CHANNELS > > + help > > + Support for the UART DMA engine found on MediaTek MTK SoCs. > > + when SERIAL_8250_MT6577 is enabled, and if you want to use DMA, > > When > > > + you can enable the config. the DMA engine can only be used > > The > > > + with MediaTek SoCs. > > + > above, i will modify. > Also, use tabs to indent instead of spaces. > The lines (tristate, depends, select, and help) should be indented with one tab. > The help text lines should be indented with one tab + 2 spaces. > in my patch, i already do this. So don't need modify. > > config MTK_HSDMA > > tristate "MediaTek High-Speed DMA controller support" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > > thanks,