From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6C3C43387 for ; Tue, 15 Jan 2019 08:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2883020656 for ; Tue, 15 Jan 2019 08:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547541965; bh=2gY3OZS4Ct+W+34yglaWkZd74xS++DTmp53ageBDJ7g=; h=Subject:To:Cc:From:Date:List-ID:From; b=BVtNx6PaXZVSFL5SV74345vp1+sVC9Ae8oPla0ZNHZRnvH686wA6WzGAf+2SJVngj 6kcBLaWQ0oXgl/euZVj9Q8wlVQdITWPJa6uXLPEolCydkIMree07fnFxCJ0o4sLC9Y hSmyMJEvgtjsVrKHg+vIRwZUaty3fzRiyX0164CM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfAOIqE (ORCPT ); Tue, 15 Jan 2019 03:46:04 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:52557 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727221AbfAOIqE (ORCPT ); Tue, 15 Jan 2019 03:46:04 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id AC52328114; Tue, 15 Jan 2019 03:46:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 15 Jan 2019 03:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uuET/n g0g7fQc0vobhO60lisVmqqqtmpF2a6gV7tdgE=; b=LxphLi5GksVsJtNKjwW/6m IM5ZgH0/kkKQ+nM35FOqWAcsLi7sk9zLvG5Anj8ll42SF5fYShxEMelzUp7EKr1D Q838pIikYtgMtRdAIObk78BSbh8/wCeLbJ9Sw1Ef4ul03R6h8Rw9O4rVZq+cZHzU hYD+TibHxHEeLBDeyFyTidUiprB7u4Vww1GelLkaZmzr5xEb2qPPPbGBcODWlByW mhAD+FXteCqmQ5uvN3RaZRP5w8P1348bev6yS59vviJs8aa1NJmPbW83yR2S5op2 2mj+EiqrPR+diWgmTjbH6BW9B41lXYK+QAKdId9SCwcU1j0BONPJ7USaBMkWLWdw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecuogfuphgrmhfkphculdeftddtmdenucfjughrpefuvffhfffkgggtgfesthekre dttddtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdr ohhrgheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrghilhhfrh homhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F1CD1027C; Tue, 15 Jan 2019 03:46:03 -0500 (EST) Subject: FAILED: patch "[PATCH] ext4: track writeback errors using the generic tracking" failed to apply to 4.4-stable tree To: tytso@mit.edu Cc: From: Date: Tue, 15 Jan 2019 09:46:02 +0100 Message-ID: <15475419624392@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 95cb67138746451cc84cf8e516e14989746e93b0 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 31 Dec 2018 00:11:07 -0500 Subject: [PATCH] ext4: track writeback errors using the generic tracking infrastructure We already using mapping_set_error() in fs/ext4/page_io.c, so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in ext4_sync_file(). Signed-off-by: Theodore Ts'o Cc: stable@kernel.org diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 87a7ff00ef62..712f00995390 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) ret = err; } out: + err = file_check_and_advance_wb_err(file); + if (ret == 0) + ret = err; trace_ext4_sync_file_exit(inode, ret); return ret; }