From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 00/11] Fix build errors related to exported headers Date: Tue, 05 Jul 2016 14:33:54 +0200 Message-ID: <1547636.SrtxZCOMXF@xps13> References: <1459865290-10248-1-git-send-email-adrien.mazarguil@6wind.com> <577B998A.4050009@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Adrien Mazarguil To: Ferruh Yigit Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id CD65658D9 for ; Tue, 5 Jul 2016 14:33:55 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id z126so73720310wme.0 for ; Tue, 05 Jul 2016 05:33:55 -0700 (PDT) In-Reply-To: <577B998A.4050009@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-05 12:27, Ferruh Yigit: > On 7/5/2016 11:44 AM, Adrien Mazarguil wrote: > > DPDK uses GNU C language extensions in most of its code base. This is fine > > for internal source files whose compilation flags are controlled by DPDK, > > however user applications that use exported "public" headers may experience > > compilation failures when enabling strict error/standard checks (-std and > > -pedantic for instance). > > Out of curiosity, is there a specific standard version that is targeted? In the last patch (scripts/check-includes.sh), there is this: +: ${PEDANTIC_CFLAGS=-std=c99 -pedantic -Wall -Wextra -Werror} +: ${PEDANTIC_CXXFLAGS=} +: ${PEDANTIC_CPPFLAGS=-D_XOPEN_SOURCE=600} I guess it means that strict C99 is targeted and there is no standard requirement for C++.