From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 11/13] udmabuf: drop WARN_ON() check. Date: Tue, 11 Sep 2018 18:07:10 +0300 Message-ID: <1547650.lRi8WmezH2@avalon> References: <20180911134216.9760-1-kraxel@redhat.com> <20180911134216.9760-12-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id A91A889BA1 for ; Tue, 11 Sep 2018 15:06:59 +0000 (UTC) In-Reply-To: <20180911134216.9760-12-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: open list , dri-devel@lists.freedesktop.org, "moderated list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org SGkgR2VyZCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSwgMTEgU2VwdGVt YmVyIDIwMTggMTY6NDI6MTQgRUVTVCBHZXJkIEhvZmZtYW5uIHdyb3RlOgoKU3RpbGwgbm8gY29t bWl0IG1lc3NhZ2UgPyA6LSkKCj4gUmVwb3J0ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZt YW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2RtYS1i dWYvdWRtYWJ1Zi5jIHwgMyAtLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi91ZG1hYnVmLmMgYi9kcml2ZXJzL2RtYS1i dWYvdWRtYWJ1Zi5jCj4gaW5kZXggYjYzN2E4YmU2ZC4uN2E0ZmQyMTk0ZCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2RtYS1idWYvdWRtYWJ1Zi5jCj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3VkbWFi dWYuYwo+IEBAIC0yNSw5ICsyNSw2IEBAIHN0YXRpYyBpbnQgdWRtYWJ1Zl92bV9mYXVsdChzdHJ1 Y3Qgdm1fZmF1bHQgKnZtZikKPiAgCXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hID0gdm1mLT52 bWE7Cj4gIAlzdHJ1Y3QgdWRtYWJ1ZiAqdWJ1ZiA9IHZtYS0+dm1fcHJpdmF0ZV9kYXRhOwo+IAo+ IC0JaWYgKFdBUk5fT04odm1mLT5wZ29mZiA+PSB1YnVmLT5wYWdlY291bnQpKQo+IC0JCXJldHVy biBWTV9GQVVMVF9TSUdCVVM7Cj4gLQo+ICAJdm1mLT5wYWdlID0gdWJ1Zi0+cGFnZXNbdm1mLT5w Z29mZl07Cj4gIAlnZXRfcGFnZSh2bWYtPnBhZ2UpOwo+ICAJcmV0dXJuIDA7CgoKLS0gClJlZ2Fy ZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:39828 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbeIKUGl (ORCPT ); Tue, 11 Sep 2018 16:06:41 -0400 From: Laurent Pinchart To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Sumit Semwal , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list Subject: Re: [PATCH v2 11/13] udmabuf: drop WARN_ON() check. Date: Tue, 11 Sep 2018 18:07:10 +0300 Message-ID: <1547650.lRi8WmezH2@avalon> In-Reply-To: <20180911134216.9760-12-kraxel@redhat.com> References: <20180911134216.9760-1-kraxel@redhat.com> <20180911134216.9760-12-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Gerd, Thank you for the patch. On Tuesday, 11 September 2018 16:42:14 EEST Gerd Hoffmann wrote: Still no commit message ? :-) > Reported-by: Laurent Pinchart > Signed-off-by: Gerd Hoffmann Reviewed-by: Laurent Pinchart > --- > drivers/dma-buf/udmabuf.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index b637a8be6d..7a4fd2194d 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -25,9 +25,6 @@ static int udmabuf_vm_fault(struct vm_fault *vmf) > struct vm_area_struct *vma = vmf->vma; > struct udmabuf *ubuf = vma->vm_private_data; > > - if (WARN_ON(vmf->pgoff >= ubuf->pagecount)) > - return VM_FAULT_SIGBUS; > - > vmf->page = ubuf->pages[vmf->pgoff]; > get_page(vmf->page); > return 0; -- Regards, Laurent Pinchart