From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller Date: Thu, 17 Jan 2019 20:41:16 +0800 Message-ID: <1547728876.4433.237.camel@mhfsdcap03> References: <1547709348-17506-1-git-send-email-min.guo@mediatek.com> <1547709348-17506-2-git-send-email-min.guo@mediatek.com> <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> Sender: linux-kernel-owner@vger.kernel.org To: Sergei Shtylyov Cc: Bin Liu , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-Id: linux-mediatek@lists.infradead.org Hello! On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote: > Hello! > > On 01/17/2019 10:15 AM, min.guo@mediatek.com wrote: > > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..3e3f671 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > I'd indent it more to align with "specifies", else it looks weird. Okay. > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > Same here... Okay. > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > Here... Okay. > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > And here. Okay. > > + > > +Optional properties: > > + - extcon : external connector for VBUS and IDPIN changes detection, > > ID pin, maybe? Okay. > > + needed when supports dual-role mode. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode. > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > [...] > > MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1547728876.4433.237.camel@mhfsdcap03> Date: Thu, 17 Jan 2019 20:41:16 +0800 To: Sergei Shtylyov Cc: Bin Liu , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-ID: SGVsbG8hCgpPbiBUaHUsIDIwMTktMDEtMTcgYXQgMTQ6MDYgKzAzMDAsIFNlcmdlaSBTaHR5bHlv diB3cm90ZToKPiBIZWxsbyEKPiAKPiBPbiAwMS8xNy8yMDE5IDEwOjE1IEFNLCBtaW4uZ3VvQG1l ZGlhdGVrLmNvbSB3cm90ZToKPiAKPiA+IEZyb206IE1pbiBHdW8gPG1pbi5ndW9AbWVkaWF0ZWsu Y29tPgo+ID4gCj4gPiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgTWVkaWFUZWsgbXVzYiBjb250cm9s bGVyIGluCj4gPiBob3N0LCBwZXJpcGhlcmFsIGFuZCBvdGcgbW9kZS4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogTWluIEd1byA8bWluLmd1b0BtZWRpYXRlay5jb20+Cj4gPiAtLS0KPiA+ICAuLi4v ZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWssbXVzYi50eHQgICAgICB8IDQzICsrKysr KysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKQo+ ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv dXNiL21lZGlhdGVrLG11c2IudHh0Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG11c2IudHh0IGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4dAo+ID4gbmV3IGZpbGUg bW9kZSAxMDA2NDQKPiA+IGluZGV4IDAwMDAwMDAuLjNlM2Y2NzEKPiA+IC0tLSAvZGV2L251bGwK PiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWss bXVzYi50eHQKPiA+IEBAIC0wLDAgKzEsNDMgQEAKPiA+ICtNZWRpYVRlayBtdXNiIERSRC9PVEcg Y29udHJvbGxlcgo+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiA+ICsKPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gKyAtIGNvbXBhdGlibGUgICAg ICA6IHNob3VsZCBiZSAibWVkaWF0ZWssbXRrLW11c2IiCj4gPiArIC0gcmVnICAgICAgICAgICAg IDogc3BlY2lmaWVzIHBoeXNpY2FsIGJhc2UgYWRkcmVzcyBhbmQgc2l6ZSBvZgo+ID4gKyAgIHRo ZSByZWdpc3RlcnMKPiAKPiAgICBJJ2QgaW5kZW50IGl0IG1vcmUgdG8gYWxpZ24gd2l0aCAic3Bl Y2lmaWVzIiwgZWxzZSBpdCBsb29rcyB3ZWlyZC4KCk9rYXkuCgo+ID4gKyAtIGludGVycnVwdHMg ICAgICA6IGludGVycnVwdCB1c2VkIGJ5IG11c2IgY29udHJvbGxlcgo+ID4gKyAtIGludGVycnVw dC1uYW1lcyA6IG11c3QgYmUgIm1jIgo+ID4gKyAtIHBoeXMgICAgICAgICAgICA6IFBIWSBzcGVj aWZpZXIgZm9yIHRoZSBPVEcgcGh5Cj4gPiArIC0gZHJfbW9kZSAgICAgICAgIDogc2hvdWxkIGJl IG9uZSBvZiAiaG9zdCIsICJwZXJpcGhlcmFsIiBvciAib3RnIiwKPiA+ICsgICByZWZlciB0byB1 c2IvZ2VuZXJpYy50eHQKPiAKPiAgIFNhbWUgaGVyZS4uLgoKT2theS4KCj4gPiArIC0gY2xvY2tz ICAgICAgICAgIDogYSBsaXN0IG9mIHBoYW5kbGUgKyBjbG9jay1zcGVjaWZpZXIgcGFpcnMsIG9u ZSBmb3IKPiA+ICsgICBlYWNoIGVudHJ5IGluIGNsb2NrLW5hbWVzCj4gCj4gICAgSGVyZS4uLgoK T2theS4KCj4gPiArIC0gY2xvY2stbmFtZXMgICAgIDogbXVzdCBjb250YWluICJtYWluIiwgIm1j dSIsICJ1bml2cGxsIgo+ID4gKyAgIGZvciBjbG9ja3Mgb2YgY29udHJvbGxlcgo+IAo+ICAgQW5k IGhlcmUuCgpPa2F5LgoKPiA+ICsKPiA+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gKyAtIGV4 dGNvbiA6IGV4dGVybmFsIGNvbm5lY3RvciBmb3IgVkJVUyBhbmQgSURQSU4gY2hhbmdlcyBkZXRl Y3Rpb24sCj4gCj4gICAgSUQgcGluLCBtYXliZT8KCk9rYXkuCgo+ID4gKyAgIG5lZWRlZCB3aGVu IHN1cHBvcnRzIGR1YWwtcm9sZSBtb2RlLgo+ID4gKyAtIHZidXMtc3VwcGx5IDogcmVmZXJlbmNl IHRvIHRoZSBWQlVTIHJlZ3VsYXRvciwgbmVlZGVkIHdoZW4gc3VwcG9ydHMKPiA+ICsgICBkdWFs LXJvbGUgbW9kZS4KPiA+ICsgLSBwb3dlci1kb21haW5zICAgOiBhIHBoYW5kbGUgdG8gVVNCIHBv d2VyIGRvbWFpbiBub2RlIHRvIGNvbnRyb2wgVVNCJ3MKPiA+ICsgICBNVENNT1MKPiBbLi4uXQo+ IAo+IE1CUiwgU2VyZ2VpCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C24E0C43387 for ; Thu, 17 Jan 2019 12:41:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 919B820851 for ; Thu, 17 Jan 2019 12:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H5SH2a9v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 919B820851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8FlbsaQNE40KAfOs25P9Te7LHJ41OXBO3uCu3AylzuA=; b=H5SH2a9vQMO1kJ zTsRoehAah0yB7W/RC3Y2UaYaMxHdVH34nQSX0W/wMT5KUzWPoZePqC1lzqYVzn5S2R20MMtLrBbt ii+ltD5vhzmjuMNy4GEPyOxFuUI0zsLlGe2RaroDMhSTUXlC0IJcHVxloCldin79wJSVQbzq6XWSo hx0aEzQ0bZJ4Lwt5P4UtNcVTnJVi8AXloqDwrLKHCh/l79Vx6d3KL9GMeiUSz0KX0SAewWCm4LxUC sNEgmnfm0ycuLRA4UxXMONbtomV4T7NBXZIvhcrVz1PkFOaynF5vLc9SOFeKWyujq4rX1o6jPHFQS cuPwuMn69zXUi4DSwhGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gk6zG-0004cB-AD; Thu, 17 Jan 2019 12:41:34 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gk6zB-0004ah-AD; Thu, 17 Jan 2019 12:41:31 +0000 X-UUID: 326cabf272c24b73b46b4025c7825707-20190117 X-UUID: 326cabf272c24b73b46b4025c7825707-20190117 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1328996133; Thu, 17 Jan 2019 04:41:21 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 17 Jan 2019 04:41:19 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 17 Jan 2019 20:41:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 17 Jan 2019 20:41:17 +0800 Message-ID: <1547728876.4433.237.camel@mhfsdcap03> Subject: Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Sergei Shtylyov Date: Thu, 17 Jan 2019 20:41:16 +0800 In-Reply-To: <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> References: <1547709348-17506-1-git-send-email-min.guo@mediatek.com> <1547709348-17506-2-git-send-email-min.guo@mediatek.com> <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_044129_361702_7EAB56D2 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, chunfeng.yun@mediatek.com, Rob Herring , Alan Stern , Matthias Brugger , linux-mediatek@lists.infradead.org, Bin Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote: > Hello! > > On 01/17/2019 10:15 AM, min.guo@mediatek.com wrote: > > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..3e3f671 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > I'd indent it more to align with "specifies", else it looks weird. Okay. > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > Same here... Okay. > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > Here... Okay. > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > And here. Okay. > > + > > +Optional properties: > > + - extcon : external connector for VBUS and IDPIN changes detection, > > ID pin, maybe? Okay. > > + needed when supports dual-role mode. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode. > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > [...] > > MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD0CC43387 for ; Thu, 17 Jan 2019 12:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4C2620851 for ; Thu, 17 Jan 2019 12:41:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727874AbfAQMl1 (ORCPT ); Thu, 17 Jan 2019 07:41:27 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:47626 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727506AbfAQMl0 (ORCPT ); Thu, 17 Jan 2019 07:41:26 -0500 X-UUID: 73f7eb08865e4460ab5e11fa1cf686d1-20190117 X-UUID: 73f7eb08865e4460ab5e11fa1cf686d1-20190117 Received: from mtkcas36.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1494410280; Thu, 17 Jan 2019 20:41:19 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 17 Jan 2019 20:41:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 17 Jan 2019 20:41:17 +0800 Message-ID: <1547728876.4433.237.camel@mhfsdcap03> Subject: Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Sergei Shtylyov CC: Bin Liu , Rob Herring , "Greg Kroah-Hartman" , Mark Rutland , Matthias Brugger , "Alan Stern" , , , , , , , , Date: Thu, 17 Jan 2019 20:41:16 +0800 In-Reply-To: <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> References: <1547709348-17506-1-git-send-email-min.guo@mediatek.com> <1547709348-17506-2-git-send-email-min.guo@mediatek.com> <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote: > Hello! > > On 01/17/2019 10:15 AM, min.guo@mediatek.com wrote: > > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..3e3f671 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > I'd indent it more to align with "specifies", else it looks weird. Okay. > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > Same here... Okay. > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > Here... Okay. > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > And here. Okay. > > + > > +Optional properties: > > + - extcon : external connector for VBUS and IDPIN changes detection, > > ID pin, maybe? Okay. > > + needed when supports dual-role mode. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode. > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > [...] > > MBR, Sergei