From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkGyE-0005Ra-H3 for kexec@lists.infradead.org; Thu, 17 Jan 2019 23:21:12 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x0HNJJYe002435 for ; Thu, 17 Jan 2019 18:21:06 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2q2xchu4bk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Jan 2019 18:21:06 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Jan 2019 23:21:03 -0000 Subject: Re: [PATCH v3 1/2] integrity, KEYS: add a reference to platform keyring From: Mimi Zohar Date: Thu, 17 Jan 2019 18:20:45 -0500 In-Reply-To: <20190116101654.7288-2-kasong@redhat.com> References: <20190116101654.7288-1-kasong@redhat.com> <20190116101654.7288-2-kasong@redhat.com> Mime-Version: 1.0 Message-Id: <1547767245.3931.56.camel@linux.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Kairui Song , linux-kernel@vger.kernel.org Cc: jwboyer@fedoraproject.org, ebiggers@google.com, dyoung@redhat.com, nayna@linux.ibm.com, kexec@lists.infradead.org, jmorris@namei.org, dhowells@redhat.com, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, dwmw2@infradead.org, bauerman@linux.ibm.com, serge@hallyn.com T24gV2VkLCAyMDE5LTAxLTE2IGF0IDE4OjE2ICswODAwLCBLYWlydWkgU29uZyB3cm90ZToKPiBD dXJyZW50bHkgd2hlbiBsb2FkaW5nIG5ldyBrZXJuZWwgdmlhIGtleGVjX2ZpbGVfbG9hZCBzeXNj YWxsLCBpdCBpcyBhYmxlCj4gdG8gdmVyaWZ5IHRoZSBzaWduZWQgUEUgYnppbWFnZSBhZ2FpbnN0 IC5idWlsdGluX3RydXN0ZWRfa2V5cyBvcgo+IC5zZWNvbmRhcnlfdHJ1c3RlZF9rZXlzLiBCdXQg dGhlIGltYWdlIGNvdWxkIGJlIHNpZ25lZCB3aXRoIHRoaXJkIHBhcnQKPiBrZXlzIHdoaWNoIHdp bGwgYmUgcHJvdmlkZWQgYnkgcGxhdGZvcm0gb3IgZmlybXdhcmUgYXMgRUZJIHZhcmlhYmxlIChl Zy4KPiBzdG9yZWQgaW4gTW9rTGlzdFJUIEVGSSB2YXJpYWJsZSksIGFuZCB0aGUga2V5cyB3b24n dCBiZSBhdmFpbGFibGUgaW4KPiBrZXlyaW5ncyBtZW50aW9uZWQgYWJvdmUuCj4gCj4gQWZ0ZXIg Y29tbWl0IDlkYzkyYzQ1MTc3YSAoJ2ludGVncml0eTogRGVmaW5lIGEgdHJ1c3RlZCBwbGF0Zm9y bSBrZXlyaW5nJykKPiBhIC5wbGF0Zm9ybSBrZXlyaW5nIGlzIGludHJvZHVjZWQgdG8gc3RvcmUg dGhlIGtleXMgcHJvdmlkZWQgYnkgcGxhdGZvcm0KPiBvciBmaXJtd2FyZSwgdGhpcyBrZXlyaW5n IGlzIGludGVuZGVkIHRvIGJlIHVzZWQgZm9yIHZlcmlmeWluZyBrZXJuZWwKPiBpbWFnZXMgYmVp bmcgbG9hZGVkIGJ5IGtleGVjX2ZpbGVfbG9hZCBzeXNjYWxsLiBBbmQgd2l0aCBhIGZldyBmb2xs b3dpbmcKPiB1cCBjb21taXRzLCBrZXlzIHByb3ZpZGVkIGJ5IGZpcm13YXJlIGlzIGJlaW5nIGxv YWRlZCBpbnRvIHRoaXMga2V5cmluZywKPiBhbmQgSU1BLWFwcHJhaXNhbCBpcyBhYmxlIHRvIHVz ZSB0aGUga2V5cmluZyB0byB2ZXJpZnkga2VybmVsIGltYWdlcy4KPiBJTUEgaXMgdGhlIGN1cnJl bnRseSB0aGUgb25seSB1c2VyIG9mIHRoYXQga2V5cmluZy4KCkhvdyBhYm91dCBzaW1wbHkgc2F5 aW5nLCBDb21taXQgIi4uLi4iIGludHJvZHVjZWQgYSBwbGF0Zm9ybSBrZXlyaW5nCmZvciBzdG9y aW5nIHByZWJvb3Qga2V5cywgdXNlZCBmb3IgdmVyaWZ5aW5nIHRoZSBrZXhlYyBrZXJuZWwgaW1h Z2UncwpzaWduYXR1cmUuCgo+IFRoaXMgcGF0Y2ggZXhwb3NlcyB0aGUgLnBsYXRmb3JtLCBhbmQg bWFrZXMgaXQgdXNlYWJsZSBmb3Igb3RoZXIKPiBjb21wb25lbnRzLiBGb3IgZXhhbXBsZSwga2V4 ZWNfZmlsZV9sb2FkIGNvdWxkIHVzZSB0aGlzIC5wbGF0Zm9ybQo+IGtleXJpbmcgdG8gdmVyaWZ5 IHRoZSBrZXJuZWwgaW1hZ2UncyBpbWFnZS4KClRoZSBhYm92ZSBzdGF0ZW1lbnQgaXMgdG9vIGdl bmVyaWMuIMKgUGxlYXNlIHJlcGxhY2UgImFuZCBtYWtlcyBpdCAKdXNlYWJsZSBmb3Igb3RoZXIg Y29tcG9uZW50cyIgd2l0aCAiIGtleXJpbmcsIG1ha2luZyBpdCBhY2Nlc3NpYmxlIGZvcgp2ZXJp ZnlpbmcgYSBQRSBzaWduZWQga2VybmVsIGltYWdlIi4KCj4gCj4gU3VnZ2VzdGVkLWJ5OiBNaW1p IFpvaGFyIDx6b2hhckBsaW51eC5pYm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IEthaXJ1aSBTb25n IDxrYXNvbmdAcmVkaGF0LmNvbT4KClJldmlld2VkL1Rlc3RlZC1ieTogTWltaSBab2hhciA8em9o YXJAbGludXguaWJtLmNvbT4KPiAtLS0KPiAgY2VydHMvc3lzdGVtX2tleXJpbmcuYyAgICAgICAg fCA5ICsrKysrKysrKwo+ICBpbmNsdWRlL2tleXMvc3lzdGVtX2tleXJpbmcuaCB8IDUgKysrKysK PiAgc2VjdXJpdHkvaW50ZWdyaXR5L2RpZ3NpZy5jICAgfCA2ICsrKysrKwo+ICAzIGZpbGVzIGNo YW5nZWQsIDIwIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvY2VydHMvc3lzdGVtX2tl eXJpbmcuYyBiL2NlcnRzL3N5c3RlbV9rZXlyaW5nLmMKPiBpbmRleCA4MTcyODcxNzUyM2QuLjQ2 OTBlZjljZGE4YSAxMDA2NDQKPiAtLS0gYS9jZXJ0cy9zeXN0ZW1fa2V5cmluZy5jCj4gKysrIGIv Y2VydHMvc3lzdGVtX2tleXJpbmcuYwo+IEBAIC0yNCw2ICsyNCw5IEBAIHN0YXRpYyBzdHJ1Y3Qg a2V5ICpidWlsdGluX3RydXN0ZWRfa2V5czsKPiAgI2lmZGVmIENPTkZJR19TRUNPTkRBUllfVFJV U1RFRF9LRVlSSU5HCj4gIHN0YXRpYyBzdHJ1Y3Qga2V5ICpzZWNvbmRhcnlfdHJ1c3RlZF9rZXlz Owo+ICAjZW5kaWYKPiArI2lmZGVmIENPTkZJR19JTlRFR1JJVFlfUExBVEZPUk1fS0VZUklORwo+ ICtzdGF0aWMgc3RydWN0IGtleSAqcGxhdGZvcm1fdHJ1c3RlZF9rZXlzOwo+ICsjZW5kaWYKPiAg Cj4gIGV4dGVybiBfX2luaXRjb25zdCBjb25zdCB1OCBzeXN0ZW1fY2VydGlmaWNhdGVfbGlzdFtd Owo+ICBleHRlcm4gX19pbml0Y29uc3QgY29uc3QgdW5zaWduZWQgbG9uZyBzeXN0ZW1fY2VydGlm aWNhdGVfbGlzdF9zaXplOwo+IEBAIC0yNjUsNCArMjY4LDEwIEBAIGludCB2ZXJpZnlfcGtjczdf c2lnbmF0dXJlKGNvbnN0IHZvaWQgKmRhdGEsIHNpemVfdCBsZW4sCj4gIH0KPiAgRVhQT1JUX1NZ TUJPTF9HUEwodmVyaWZ5X3BrY3M3X3NpZ25hdHVyZSk7Cj4gIAo+ICsjaWZkZWYgQ09ORklHX0lO VEVHUklUWV9QTEFURk9STV9LRVlSSU5HCj4gK3ZvaWQgX19pbml0IHNldF9wbGF0Zm9ybV90cnVz dGVkX2tleXMoc3RydWN0IGtleSAqa2V5cmluZykgewo+ICsJcGxhdGZvcm1fdHJ1c3RlZF9rZXlz ID0ga2V5cmluZzsKPiArfQo+ICsjZW5kaWYKPiArCj4gICNlbmRpZiAvKiBDT05GSUdfU1lTVEVN X0RBVEFfVkVSSUZJQ0FUSU9OICovCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUva2V5cy9zeXN0ZW1f a2V5cmluZy5oIGIvaW5jbHVkZS9rZXlzL3N5c3RlbV9rZXlyaW5nLmgKPiBpbmRleCAzNTljMmY5 MzYwMDQuLjllMWI3ODQ5YjZhYSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2tleXMvc3lzdGVtX2tl eXJpbmcuaAo+ICsrKyBiL2luY2x1ZGUva2V5cy9zeXN0ZW1fa2V5cmluZy5oCj4gQEAgLTYxLDUg KzYxLDEwIEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGtleSAqZ2V0X2ltYV9ibGFja2xpc3Rfa2V5 cmluZyh2b2lkKQo+ICB9Cj4gICNlbmRpZiAvKiBDT05GSUdfSU1BX0JMQUNLTElTVF9LRVlSSU5H ICovCj4gIAo+ICsjaWZkZWYgQ09ORklHX0lOVEVHUklUWV9QTEFURk9STV9LRVlSSU5HCj4gKwo+ ICtleHRlcm4gdm9pZCBfX2luaXQgc2V0X3BsYXRmb3JtX3RydXN0ZWRfa2V5cyhzdHJ1Y3Qga2V5 KiBrZXlyaW5nKTsKPiArCj4gKyNlbmRpZiAvKiBDT05GSUdfSU5URUdSSVRZX1BMQVRGT1JNX0tF WVJJTkcgKi8KPiAgCj4gICNlbmRpZiAvKiBfS0VZU19TWVNURU1fS0VZUklOR19IICovCj4gZGlm ZiAtLWdpdCBhL3NlY3VyaXR5L2ludGVncml0eS9kaWdzaWcuYyBiL3NlY3VyaXR5L2ludGVncml0 eS9kaWdzaWcuYwo+IGluZGV4IGY0NWQ2ZWRlY2Y5OS4uYmZhYmMyYTgxMTFkIDEwMDY0NAo+IC0t LSBhL3NlY3VyaXR5L2ludGVncml0eS9kaWdzaWcuYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVncml0 eS9kaWdzaWcuYwo+IEBAIC04OSw2ICs4OSwxMiBAQCBzdGF0aWMgaW50IF9faW50ZWdyaXR5X2lu aXRfa2V5cmluZyhjb25zdCB1bnNpZ25lZCBpbnQgaWQsIGtleV9wZXJtX3QgcGVybSwKPiAgCQlr ZXlyaW5nW2lkXSA9IE5VTEw7Cj4gIAl9Cj4gIAo+ICsjaWZkZWYgQ09ORklHX0lOVEVHUklUWV9Q TEFURk9STV9LRVlSSU5HCj4gKwlpZiAoaWQgPT0gSU5URUdSSVRZX0tFWVJJTkdfUExBVEZPUk0p IHsKPiArCQlzZXRfcGxhdGZvcm1fdHJ1c3RlZF9rZXlzKGtleXJpbmdbaWRdKTsKPiArCX0KPiAr I2VuZGlmCj4gKwo+ICAJcmV0dXJuIGVycjsKPiAgfQo+ICAKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Thu, 17 Jan 2019 23:20:45 +0000 Subject: Re: [PATCH v3 1/2] integrity, KEYS: add a reference to platform keyring Message-Id: <1547767245.3931.56.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20190116101654.7288-1-kasong@redhat.com> <20190116101654.7288-2-kasong@redhat.com> In-Reply-To: <20190116101654.7288-2-kasong@redhat.com> To: Kairui Song , linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, dyoung@redhat.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org T24gV2VkLCAyMDE5LTAxLTE2IGF0IDE4OjE2ICswODAwLCBLYWlydWkgU29uZyB3cm90ZToKPiBD dXJyZW50bHkgd2hlbiBsb2FkaW5nIG5ldyBrZXJuZWwgdmlhIGtleGVjX2ZpbGVfbG9hZCBzeXNj YWxsLCBpdCBpcyBhYmxlCj4gdG8gdmVyaWZ5IHRoZSBzaWduZWQgUEUgYnppbWFnZSBhZ2FpbnN0 IC5idWlsdGluX3RydXN0ZWRfa2V5cyBvcgo+IC5zZWNvbmRhcnlfdHJ1c3RlZF9rZXlzLiBCdXQg dGhlIGltYWdlIGNvdWxkIGJlIHNpZ25lZCB3aXRoIHRoaXJkIHBhcnQKPiBrZXlzIHdoaWNoIHdp bGwgYmUgcHJvdmlkZWQgYnkgcGxhdGZvcm0gb3IgZmlybXdhcmUgYXMgRUZJIHZhcmlhYmxlIChl Zy4KPiBzdG9yZWQgaW4gTW9rTGlzdFJUIEVGSSB2YXJpYWJsZSksIGFuZCB0aGUga2V5cyB3b24n dCBiZSBhdmFpbGFibGUgaW4KPiBrZXlyaW5ncyBtZW50aW9uZWQgYWJvdmUuCj4gCj4gQWZ0ZXIg Y29tbWl0IDlkYzkyYzQ1MTc3YSAoJ2ludGVncml0eTogRGVmaW5lIGEgdHJ1c3RlZCBwbGF0Zm9y bSBrZXlyaW5nJykKPiBhIC5wbGF0Zm9ybSBrZXlyaW5nIGlzIGludHJvZHVjZWQgdG8gc3RvcmUg dGhlIGtleXMgcHJvdmlkZWQgYnkgcGxhdGZvcm0KPiBvciBmaXJtd2FyZSwgdGhpcyBrZXlyaW5n IGlzIGludGVuZGVkIHRvIGJlIHVzZWQgZm9yIHZlcmlmeWluZyBrZXJuZWwKPiBpbWFnZXMgYmVp bmcgbG9hZGVkIGJ5IGtleGVjX2ZpbGVfbG9hZCBzeXNjYWxsLiBBbmQgd2l0aCBhIGZldyBmb2xs b3dpbmcKPiB1cCBjb21taXRzLCBrZXlzIHByb3ZpZGVkIGJ5IGZpcm13YXJlIGlzIGJlaW5nIGxv YWRlZCBpbnRvIHRoaXMga2V5cmluZywKPiBhbmQgSU1BLWFwcHJhaXNhbCBpcyBhYmxlIHRvIHVz ZSB0aGUga2V5cmluZyB0byB2ZXJpZnkga2VybmVsIGltYWdlcy4KPiBJTUEgaXMgdGhlIGN1cnJl bnRseSB0aGUgb25seSB1c2VyIG9mIHRoYXQga2V5cmluZy4KCkhvdyBhYm91dCBzaW1wbHkgc2F5 aW5nLCBDb21taXQgIi4uLi4iIGludHJvZHVjZWQgYSBwbGF0Zm9ybSBrZXlyaW5nCmZvciBzdG9y aW5nIHByZWJvb3Qga2V5cywgdXNlZCBmb3IgdmVyaWZ5aW5nIHRoZSBrZXhlYyBrZXJuZWwgaW1h Z2UncwpzaWduYXR1cmUuCgo+IFRoaXMgcGF0Y2ggZXhwb3NlcyB0aGUgLnBsYXRmb3JtLCBhbmQg bWFrZXMgaXQgdXNlYWJsZSBmb3Igb3RoZXIKPiBjb21wb25lbnRzLiBGb3IgZXhhbXBsZSwga2V4 ZWNfZmlsZV9sb2FkIGNvdWxkIHVzZSB0aGlzIC5wbGF0Zm9ybQo+IGtleXJpbmcgdG8gdmVyaWZ5 IHRoZSBrZXJuZWwgaW1hZ2UncyBpbWFnZS4KClRoZSBhYm92ZSBzdGF0ZW1lbnQgaXMgdG9vIGdl bmVyaWMuIMKgUGxlYXNlIHJlcGxhY2UgImFuZCBtYWtlcyBpdCAKdXNlYWJsZSBmb3Igb3RoZXIg Y29tcG9uZW50cyIgd2l0aCAiIGtleXJpbmcsIG1ha2luZyBpdCBhY2Nlc3NpYmxlIGZvcgp2ZXJp ZnlpbmcgYSBQRSBzaWduZWQga2VybmVsIGltYWdlIi4KCj4gCj4gU3VnZ2VzdGVkLWJ5OiBNaW1p IFpvaGFyIDx6b2hhckBsaW51eC5pYm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IEthaXJ1aSBTb25n IDxrYXNvbmdAcmVkaGF0LmNvbT4KClJldmlld2VkL1Rlc3RlZC1ieTogTWltaSBab2hhciA8em9o YXJAbGludXguaWJtLmNvbT4KPiAtLS0KPiAgY2VydHMvc3lzdGVtX2tleXJpbmcuYyAgICAgICAg fCA5ICsrKysrKysrKwo+ICBpbmNsdWRlL2tleXMvc3lzdGVtX2tleXJpbmcuaCB8IDUgKysrKysK PiAgc2VjdXJpdHkvaW50ZWdyaXR5L2RpZ3NpZy5jICAgfCA2ICsrKysrKwo+ICAzIGZpbGVzIGNo YW5nZWQsIDIwIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvY2VydHMvc3lzdGVtX2tl eXJpbmcuYyBiL2NlcnRzL3N5c3RlbV9rZXlyaW5nLmMKPiBpbmRleCA4MTcyODcxNzUyM2QuLjQ2 OTBlZjljZGE4YSAxMDA2NDQKPiAtLS0gYS9jZXJ0cy9zeXN0ZW1fa2V5cmluZy5jCj4gKysrIGIv Y2VydHMvc3lzdGVtX2tleXJpbmcuYwo+IEBAIC0yNCw2ICsyNCw5IEBAIHN0YXRpYyBzdHJ1Y3Qg a2V5ICpidWlsdGluX3RydXN0ZWRfa2V5czsKPiAgI2lmZGVmIENPTkZJR19TRUNPTkRBUllfVFJV U1RFRF9LRVlSSU5HCj4gIHN0YXRpYyBzdHJ1Y3Qga2V5ICpzZWNvbmRhcnlfdHJ1c3RlZF9rZXlz Owo+ICAjZW5kaWYKPiArI2lmZGVmIENPTkZJR19JTlRFR1JJVFlfUExBVEZPUk1fS0VZUklORwo+ ICtzdGF0aWMgc3RydWN0IGtleSAqcGxhdGZvcm1fdHJ1c3RlZF9rZXlzOwo+ICsjZW5kaWYKPiAg Cj4gIGV4dGVybiBfX2luaXRjb25zdCBjb25zdCB1OCBzeXN0ZW1fY2VydGlmaWNhdGVfbGlzdFtd Owo+ICBleHRlcm4gX19pbml0Y29uc3QgY29uc3QgdW5zaWduZWQgbG9uZyBzeXN0ZW1fY2VydGlm aWNhdGVfbGlzdF9zaXplOwo+IEBAIC0yNjUsNCArMjY4LDEwIEBAIGludCB2ZXJpZnlfcGtjczdf c2lnbmF0dXJlKGNvbnN0IHZvaWQgKmRhdGEsIHNpemVfdCBsZW4sCj4gIH0KPiAgRVhQT1JUX1NZ TUJPTF9HUEwodmVyaWZ5X3BrY3M3X3NpZ25hdHVyZSk7Cj4gIAo+ICsjaWZkZWYgQ09ORklHX0lO VEVHUklUWV9QTEFURk9STV9LRVlSSU5HCj4gK3ZvaWQgX19pbml0IHNldF9wbGF0Zm9ybV90cnVz dGVkX2tleXMoc3RydWN0IGtleSAqa2V5cmluZykgewo+ICsJcGxhdGZvcm1fdHJ1c3RlZF9rZXlz ID0ga2V5cmluZzsKPiArfQo+ICsjZW5kaWYKPiArCj4gICNlbmRpZiAvKiBDT05GSUdfU1lTVEVN X0RBVEFfVkVSSUZJQ0FUSU9OICovCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUva2V5cy9zeXN0ZW1f a2V5cmluZy5oIGIvaW5jbHVkZS9rZXlzL3N5c3RlbV9rZXlyaW5nLmgKPiBpbmRleCAzNTljMmY5 MzYwMDQuLjllMWI3ODQ5YjZhYSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2tleXMvc3lzdGVtX2tl eXJpbmcuaAo+ICsrKyBiL2luY2x1ZGUva2V5cy9zeXN0ZW1fa2V5cmluZy5oCj4gQEAgLTYxLDUg KzYxLDEwIEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGtleSAqZ2V0X2ltYV9ibGFja2xpc3Rfa2V5 cmluZyh2b2lkKQo+ICB9Cj4gICNlbmRpZiAvKiBDT05GSUdfSU1BX0JMQUNLTElTVF9LRVlSSU5H ICovCj4gIAo+ICsjaWZkZWYgQ09ORklHX0lOVEVHUklUWV9QTEFURk9STV9LRVlSSU5HCj4gKwo+ ICtleHRlcm4gdm9pZCBfX2luaXQgc2V0X3BsYXRmb3JtX3RydXN0ZWRfa2V5cyhzdHJ1Y3Qga2V5 KiBrZXlyaW5nKTsKPiArCj4gKyNlbmRpZiAvKiBDT05GSUdfSU5URUdSSVRZX1BMQVRGT1JNX0tF WVJJTkcgKi8KPiAgCj4gICNlbmRpZiAvKiBfS0VZU19TWVNURU1fS0VZUklOR19IICovCj4gZGlm ZiAtLWdpdCBhL3NlY3VyaXR5L2ludGVncml0eS9kaWdzaWcuYyBiL3NlY3VyaXR5L2ludGVncml0 eS9kaWdzaWcuYwo+IGluZGV4IGY0NWQ2ZWRlY2Y5OS4uYmZhYmMyYTgxMTFkIDEwMDY0NAo+IC0t LSBhL3NlY3VyaXR5L2ludGVncml0eS9kaWdzaWcuYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVncml0 eS9kaWdzaWcuYwo+IEBAIC04OSw2ICs4OSwxMiBAQCBzdGF0aWMgaW50IF9faW50ZWdyaXR5X2lu aXRfa2V5cmluZyhjb25zdCB1bnNpZ25lZCBpbnQgaWQsIGtleV9wZXJtX3QgcGVybSwKPiAgCQlr ZXlyaW5nW2lkXSA9IE5VTEw7Cj4gIAl9Cj4gIAo+ICsjaWZkZWYgQ09ORklHX0lOVEVHUklUWV9Q TEFURk9STV9LRVlSSU5HCj4gKwlpZiAoaWQgPSBJTlRFR1JJVFlfS0VZUklOR19QTEFURk9STSkg ewo+ICsJCXNldF9wbGF0Zm9ybV90cnVzdGVkX2tleXMoa2V5cmluZ1tpZF0pOwo+ICsJfQo+ICsj ZW5kaWYKPiArCj4gIAlyZXR1cm4gZXJyOwo+ICB9Cj4gIAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84B9C43387 for ; Thu, 17 Jan 2019 23:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8426220851 for ; Thu, 17 Jan 2019 23:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbfAQXVH (ORCPT ); Thu, 17 Jan 2019 18:21:07 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59432 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726062AbfAQXVH (ORCPT ); Thu, 17 Jan 2019 18:21:07 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x0HNJk8v110512 for ; Thu, 17 Jan 2019 18:21:05 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2q2xuw9ebx-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Jan 2019 18:21:05 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Jan 2019 23:21:03 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 17 Jan 2019 23:20:59 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0HNKwRW10355110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Jan 2019 23:20:58 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4871552052; Thu, 17 Jan 2019 23:20:58 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.91.54]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 90D9352050; Thu, 17 Jan 2019 23:20:56 +0000 (GMT) Subject: Re: [PATCH v3 1/2] integrity, KEYS: add a reference to platform keyring From: Mimi Zohar To: Kairui Song , linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, dyoung@redhat.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org Date: Thu, 17 Jan 2019 18:20:45 -0500 In-Reply-To: <20190116101654.7288-2-kasong@redhat.com> References: <20190116101654.7288-1-kasong@redhat.com> <20190116101654.7288-2-kasong@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19011723-4275-0000-0000-00000300ADD7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19011723-4276-0000-0000-0000380ED44B Message-Id: <1547767245.3931.56.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-17_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901170162 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, 2019-01-16 at 18:16 +0800, Kairui Song wrote: > Currently when loading new kernel via kexec_file_load syscall, it is able > to verify the signed PE bzimage against .builtin_trusted_keys or > .secondary_trusted_keys. But the image could be signed with third part > keys which will be provided by platform or firmware as EFI variable (eg. > stored in MokListRT EFI variable), and the keys won't be available in > keyrings mentioned above. > > After commit 9dc92c45177a ('integrity: Define a trusted platform keyring') > a .platform keyring is introduced to store the keys provided by platform > or firmware, this keyring is intended to be used for verifying kernel > images being loaded by kexec_file_load syscall. And with a few following > up commits, keys provided by firmware is being loaded into this keyring, > and IMA-appraisal is able to use the keyring to verify kernel images. > IMA is the currently the only user of that keyring. How about simply saying, Commit "...." introduced a platform keyring for storing preboot keys, used for verifying the kexec kernel image's signature. > This patch exposes the .platform, and makes it useable for other > components. For example, kexec_file_load could use this .platform > keyring to verify the kernel image's image. The above statement is too generic.  Please replace "and makes it useable for other components" with " keyring, making it accessible for verifying a PE signed kernel image". > > Suggested-by: Mimi Zohar > Signed-off-by: Kairui Song Reviewed/Tested-by: Mimi Zohar > --- > certs/system_keyring.c | 9 +++++++++ > include/keys/system_keyring.h | 5 +++++ > security/integrity/digsig.c | 6 ++++++ > 3 files changed, 20 insertions(+) > > diff --git a/certs/system_keyring.c b/certs/system_keyring.c > index 81728717523d..4690ef9cda8a 100644 > --- a/certs/system_keyring.c > +++ b/certs/system_keyring.c > @@ -24,6 +24,9 @@ static struct key *builtin_trusted_keys; > #ifdef CONFIG_SECONDARY_TRUSTED_KEYRING > static struct key *secondary_trusted_keys; > #endif > +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING > +static struct key *platform_trusted_keys; > +#endif > > extern __initconst const u8 system_certificate_list[]; > extern __initconst const unsigned long system_certificate_list_size; > @@ -265,4 +268,10 @@ int verify_pkcs7_signature(const void *data, size_t len, > } > EXPORT_SYMBOL_GPL(verify_pkcs7_signature); > > +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING > +void __init set_platform_trusted_keys(struct key *keyring) { > + platform_trusted_keys = keyring; > +} > +#endif > + > #endif /* CONFIG_SYSTEM_DATA_VERIFICATION */ > diff --git a/include/keys/system_keyring.h b/include/keys/system_keyring.h > index 359c2f936004..9e1b7849b6aa 100644 > --- a/include/keys/system_keyring.h > +++ b/include/keys/system_keyring.h > @@ -61,5 +61,10 @@ static inline struct key *get_ima_blacklist_keyring(void) > } > #endif /* CONFIG_IMA_BLACKLIST_KEYRING */ > > +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING > + > +extern void __init set_platform_trusted_keys(struct key* keyring); > + > +#endif /* CONFIG_INTEGRITY_PLATFORM_KEYRING */ > > #endif /* _KEYS_SYSTEM_KEYRING_H */ > diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c > index f45d6edecf99..bfabc2a8111d 100644 > --- a/security/integrity/digsig.c > +++ b/security/integrity/digsig.c > @@ -89,6 +89,12 @@ static int __integrity_init_keyring(const unsigned int id, key_perm_t perm, > keyring[id] = NULL; > } > > +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING > + if (id == INTEGRITY_KEYRING_PLATFORM) { > + set_platform_trusted_keys(keyring[id]); > + } > +#endif > + > return err; > } >