From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkJLq-00077j-PH for kexec@lists.infradead.org; Fri, 18 Jan 2019 01:53:44 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0I1iUOq066782 for ; Thu, 17 Jan 2019 20:53:41 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2q35btrk81-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Jan 2019 20:53:12 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 Jan 2019 01:53:10 -0000 Subject: Re: [PATCH v3 0/2] let kexec_file_load use platform keyring to verify the kernel image From: Mimi Zohar Date: Thu, 17 Jan 2019 20:52:52 -0500 In-Reply-To: <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> References: <20190116101654.7288-1-kasong@redhat.com> <1547773684.4026.10.camel@linux.ibm.com> <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> Mime-Version: 1.0 Message-Id: <1547776372.3982.1.camel@linux.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: jwboyer@fedoraproject.org, Kairui Song , ebiggers@google.com, nayna@linux.ibm.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jmorris@namei.org, dhowells@redhat.com, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, dwmw2@infradead.org, bauerman@linux.ibm.com, serge@hallyn.com T24gRnJpLCAyMDE5LTAxLTE4IGF0IDA5OjM1ICswODAwLCBEYXZlIFlvdW5nIHdyb3RlOgo+IE9u IDAxLzE3LzE5IGF0IDA4OjA4cG0sIE1pbWkgWm9oYXIgd3JvdGU6Cgo+ID4gSXQncyB0YWtlbiBz byBsb25nIGZvciBtZSB0byByZXZpZXcvdGVzdCB0aGlzIHBhdGNoIHNldCBkdWUgdG8gYQo+ID4g cmVncmVzc2lvbiBpbiBzYW5pdHlfY2hlY2tfc2VnbWVudF9saXN0KCksIGludHJvZHVjZWQgc29t ZXdoZXJlCj4gPiBiZXR3ZWVuIDQuMjAgYW5kIDUuMC4wLXJjMS4gwqBUaGUgc2dlbWVudCBvdmVy bGFwIHRlc3QgLSAiaWYgKChtZW5kID4KPiA+IHBzdGFydCkgJiYgKG1zdGFydCA8IHBlbmQpKSIg LSBmYWlscywgcmV0dXJuaW5nIGEgLUVJTlZBTC4KPiA+IAo+ID4gSXMgYW55b25lIGVsc2Ugc2Vl aW5nIHRoaXM/Cj4gCj4gTWltaSwgc2hvdWxkIGJlIHRoaXMgaXNzdWU/ICBJIGhhdmUgc2VudCBh IGZpeCBmb3IgdGhhdC4KPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMTgxMjI4MDEx MjQ3LkdBOTk5OUBkaGNwLTEyOC02NS5uYXkucmVkaGF0LmNvbS8KClRoYW5rcywgdGhhdCByZXNv bHZlZCB0aGUgcmVncmVzc2lvbi4KCk1pbWkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVj Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Fri, 18 Jan 2019 01:52:52 +0000 Subject: Re: [PATCH v3 0/2] let kexec_file_load use platform keyring to verify the kernel image Message-Id: <1547776372.3982.1.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20190116101654.7288-1-kasong@redhat.com> <1547773684.4026.10.camel@linux.ibm.com> <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> In-Reply-To: <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> To: Dave Young Cc: Kairui Song , linux-kernel@vger.kernel.org, dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org T24gRnJpLCAyMDE5LTAxLTE4IGF0IDA5OjM1ICswODAwLCBEYXZlIFlvdW5nIHdyb3RlOgo+IE9u IDAxLzE3LzE5IGF0IDA4OjA4cG0sIE1pbWkgWm9oYXIgd3JvdGU6Cgo+ID4gSXQncyB0YWtlbiBz byBsb25nIGZvciBtZSB0byByZXZpZXcvdGVzdCB0aGlzIHBhdGNoIHNldCBkdWUgdG8gYQo+ID4g cmVncmVzc2lvbiBpbiBzYW5pdHlfY2hlY2tfc2VnbWVudF9saXN0KCksIGludHJvZHVjZWQgc29t ZXdoZXJlCj4gPiBiZXR3ZWVuIDQuMjAgYW5kIDUuMC4wLXJjMS4gwqBUaGUgc2dlbWVudCBvdmVy bGFwIHRlc3QgLSAiaWYgKChtZW5kID4KPiA+IHBzdGFydCkgJiYgKG1zdGFydCA8IHBlbmQpKSIg LSBmYWlscywgcmV0dXJuaW5nIGEgLUVJTlZBTC4KPiA+IAo+ID4gSXMgYW55b25lIGVsc2Ugc2Vl aW5nIHRoaXM/Cj4gCj4gTWltaSwgc2hvdWxkIGJlIHRoaXMgaXNzdWU/ICBJIGhhdmUgc2VudCBh IGZpeCBmb3IgdGhhdC4KPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMTgxMjI4MDEx MjQ3LkdBOTk5OUBkaGNwLTEyOC02NS5uYXkucmVkaGF0LmNvbS8KClRoYW5rcywgdGhhdCByZXNv bHZlZCB0aGUgcmVncmVzc2lvbi4KCk1pbWkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3BAC43387 for ; Fri, 18 Jan 2019 01:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 683242086D for ; Fri, 18 Jan 2019 01:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfARBxO (ORCPT ); Thu, 17 Jan 2019 20:53:14 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34794 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726962AbfARBxN (ORCPT ); Thu, 17 Jan 2019 20:53:13 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x0I1n8Un116361 for ; Thu, 17 Jan 2019 20:53:12 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2q3404k8qf-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Jan 2019 20:53:12 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 Jan 2019 01:53:10 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 18 Jan 2019 01:53:06 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0I1r4H53277276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Jan 2019 01:53:04 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B7E2DA405B; Fri, 18 Jan 2019 01:53:04 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03B41A4054; Fri, 18 Jan 2019 01:53:03 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.91.65]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 18 Jan 2019 01:53:02 +0000 (GMT) Subject: Re: [PATCH v3 0/2] let kexec_file_load use platform keyring to verify the kernel image From: Mimi Zohar To: Dave Young Cc: Kairui Song , linux-kernel@vger.kernel.org, dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org Date: Thu, 17 Jan 2019 20:52:52 -0500 In-Reply-To: <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> References: <20190116101654.7288-1-kasong@redhat.com> <1547773684.4026.10.camel@linux.ibm.com> <20190118013530.GA2814@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19011801-4275-0000-0000-00000300B820 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19011801-4276-0000-0000-0000380EDEBD Message-Id: <1547776372.3982.1.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-18_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=899 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901180013 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, 2019-01-18 at 09:35 +0800, Dave Young wrote: > On 01/17/19 at 08:08pm, Mimi Zohar wrote: > > It's taken so long for me to review/test this patch set due to a > > regression in sanity_check_segment_list(), introduced somewhere > > between 4.20 and 5.0.0-rc1.  The sgement overlap test - "if ((mend > > > pstart) && (mstart < pend))" - fails, returning a -EINVAL. > > > > Is anyone else seeing this? > > Mimi, should be this issue? I have sent a fix for that. > https://lore.kernel.org/lkml/20181228011247.GA9999@dhcp-128-65.nay.redhat.com/ Thanks, that resolved the regression. Mimi