From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller Date: Tue, 22 Jan 2019 17:36:13 +0800 Message-ID: <1548149773.4433.284.camel@mhfsdcap03> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190121151417.GA19238@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Bin Liu Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Hi Bin, Sorry to bother you again, I encounter a problem about the extcon property. I don't find a common driver describing the usb-connector. Is there any driver that I can refer to, specially the way to switch MUSB controller between host and device mode? If it needs to implement by myself, is it possible to emulate an usb-connector driver by extcon-usb-gpio, and also use the notifier mechanism or can you give me some advices? Hi Rob, On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote: > On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > This is not what I said. I gave you the exact text to put. Sorry to misunderstood your meaning last time, I will modify it in next patch. compatible: should be one of "mediatek,mt2701-musb"...,followed by "mediatek,mtk-musb" > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..4305770 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - extcon : external connector for VBUS and ID pin changes detection, > > + needed when supports dual-role mode > > Again, do not use extcon in new bindings. Thanks, ok. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + vbus-supply = <&usb_vbus>; > > + extcon = <&extcon_usb>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > +}; > > -- > > 1.9.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Regards, Min. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1548149773.4433.284.camel@mhfsdcap03> Date: Tue, 22 Jan 2019 17:36:13 +0800 To: Rob Herring , Bin Liu Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-ID: SGkgQmluLAoKU29ycnkgdG8gYm90aGVyIHlvdSBhZ2FpbiwgSSBlbmNvdW50ZXIgYSBwcm9ibGVt IGFib3V0IHRoZSBleHRjb24KcHJvcGVydHkuCgpJIGRvbid0IGZpbmQgYSBjb21tb24gZHJpdmVy IGRlc2NyaWJpbmcgdGhlIHVzYi1jb25uZWN0b3IuIElzCnRoZXJlIGFueSBkcml2ZXIgdGhhdCBJ IGNhbiByZWZlciB0bywgc3BlY2lhbGx5IHRoZSB3YXkgdG8gc3dpdGNoIE1VU0IKY29udHJvbGxl ciBiZXR3ZWVuIGhvc3QgYW5kIGRldmljZSBtb2RlPyAKSWYgaXQgbmVlZHMgdG8gaW1wbGVtZW50 IGJ5IG15c2VsZiwgaXMgaXQgcG9zc2libGUgdG8gZW11bGF0ZSBhbgp1c2ItY29ubmVjdG9yIGRy aXZlciBieSBleHRjb24tdXNiLWdwaW8sIGFuZCBhbHNvIHVzZSB0aGUgbm90aWZpZXIKbWVjaGFu aXNtIG9yIGNhbiB5b3UgZ2l2ZSBtZSBzb21lIGFkdmljZXM/CgoKSGkgUm9iLAoKT24gTW9uLCAy MDE5LTAxLTIxIGF0IDA5OjE0IC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBPbiBNb24sIEph biAyMSwgMjAxOSBhdCAwODoyMjoyNlBNICswODAwLCBtaW4uZ3VvQG1lZGlhdGVrLmNvbSB3cm90 ZToKPiA+IEZyb206IE1pbiBHdW8gPG1pbi5ndW9AbWVkaWF0ZWsuY29tPgo+ID4gCj4gPiBUaGlz IGFkZHMgc3VwcG9ydCBmb3IgTWVkaWFUZWsgbXVzYiBjb250cm9sbGVyIGluCj4gPiBob3N0LCBw ZXJpcGhlcmFsIGFuZCBvdGcgbW9kZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWluIEd1byA8 bWluLmd1b0BtZWRpYXRlay5jb20+Cj4gPiAtLS0KPiA+IGNoYW5nZXMgaW4gdjQ6Cj4gPiBzdWdn ZXN0ZWQgYnkgU2VyZ2VpOgo+ID4gMS4gU3RyaW5nIGFsaWdubWVudAo+ID4gCj4gPiBjaGFuZ2Vz IGluIHYzOgo+ID4gMS4gbm8gY2hhbmdlcwo+ID4gCj4gPiBjaGFuZ2VzIGluIHYyOgo+ID4gc3Vn Z2VzdGVkIGJ5IEJpbjoKPiA+IDEuIE1vZGlmeSBEUkMgdG8gRFJECj4gPiBzdWdnZXN0ZWQgYnkg Um9iOgo+ID4gMi4gRHJvcCB0aGUgIjxzb2MtbW9kZWw+LW11c2IiIGluIGNvbXBhdGlibGUKPiAK PiBUaGlzIGlzIG5vdCB3aGF0IEkgc2FpZC4gSSBnYXZlIHlvdSB0aGUgZXhhY3QgdGV4dCB0byBw dXQuCgpTb3JyeSB0byBtaXN1bmRlcnN0b29kIHlvdXIgbWVhbmluZyBsYXN0IHRpbWUsICBJIHdp bGwgbW9kaWZ5IGl0IGluIG5leHQKcGF0Y2guCgljb21wYXRpYmxlOiBzaG91bGQgYmUgb25lIG9m ICJtZWRpYXRlayxtdDI3MDEtbXVzYiIuLi4sZm9sbG93ZWQgYnkKIm1lZGlhdGVrLG10ay1tdXNi IgoKPiA+IDMuIFJlbW92ZSBwaHktbmFtZXMKPiA+IDQuIEFkZCBzcGFjZSBhZnRlciBjb21tYSBp biBjbG9jay1uYW1lcwo+ID4gLS0tCj4gPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21l ZGlhdGVrLG11c2IudHh0ICAgICAgfCA0MyArKysrKysrKysrKysrKysrKysrKysrCj4gPiAgMSBm aWxlIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKykKPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4dAo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9t ZWRpYXRlayxtdXNiLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2Iv bWVkaWF0ZWssbXVzYi50eHQKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAw MDAwLi40MzA1NzcwCj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG11c2IudHh0Cj4gPiBAQCAtMCwwICsxLDQz IEBACj4gPiArTWVkaWFUZWsgbXVzYiBEUkQvT1RHIGNvbnRyb2xsZXIKPiA+ICstLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiArCj4gPiArUmVxdWlyZWQgcHJv cGVydGllczoKPiA+ICsgLSBjb21wYXRpYmxlICAgICAgOiBzaG91bGQgYmUgIm1lZGlhdGVrLG10 ay1tdXNiIgo+ID4gKyAtIHJlZyAgICAgICAgICAgICA6IHNwZWNpZmllcyBwaHlzaWNhbCBiYXNl IGFkZHJlc3MgYW5kIHNpemUgb2YKPiA+ICsgICAgICAgICAgICAgICAgICAgICB0aGUgcmVnaXN0 ZXJzCj4gPiArIC0gaW50ZXJydXB0cyAgICAgIDogaW50ZXJydXB0IHVzZWQgYnkgbXVzYiBjb250 cm9sbGVyCj4gPiArIC0gaW50ZXJydXB0LW5hbWVzIDogbXVzdCBiZSAibWMiCj4gPiArIC0gcGh5 cyAgICAgICAgICAgIDogUEhZIHNwZWNpZmllciBmb3IgdGhlIE9URyBwaHkKPiA+ICsgLSBkcl9t b2RlICAgICAgICAgOiBzaG91bGQgYmUgb25lIG9mICJob3N0IiwgInBlcmlwaGVyYWwiIG9yICJv dGciLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJlZmVyIHRvIHVzYi9nZW5lcmljLnR4dAo+ ID4gKyAtIGNsb2NrcyAgICAgICAgICA6IGEgbGlzdCBvZiBwaGFuZGxlICsgY2xvY2stc3BlY2lm aWVyIHBhaXJzLCBvbmUgZm9yCj4gPiArICAgICAgICAgICAgICAgICAgICAgZWFjaCBlbnRyeSBp biBjbG9jay1uYW1lcwo+ID4gKyAtIGNsb2NrLW5hbWVzICAgICA6IG11c3QgY29udGFpbiAibWFp biIsICJtY3UiLCAidW5pdnBsbCIKPiA+ICsgICAgICAgICAgICAgICAgICAgICBmb3IgY2xvY2tz IG9mIGNvbnRyb2xsZXIKPiA+ICsKPiA+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gKyAtIGV4 dGNvbiAgICAgICAgICA6IGV4dGVybmFsIGNvbm5lY3RvciBmb3IgVkJVUyBhbmQgSUQgcGluIGNo YW5nZXMgZGV0ZWN0aW9uLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgIG5lZWRlZCB3aGVuIHN1 cHBvcnRzIGR1YWwtcm9sZSBtb2RlCj4gCj4gQWdhaW4sIGRvIG5vdCB1c2UgZXh0Y29uIGluIG5l dyBiaW5kaW5ncy4KClRoYW5rcywgb2suCgo+ID4gKyAtIHZidXMtc3VwcGx5ICAgICA6IHJlZmVy ZW5jZSB0byB0aGUgVkJVUyByZWd1bGF0b3IsIG5lZWRlZCB3aGVuIHN1cHBvcnRzCj4gPiArICAg ICAgICAgICAgICAgICAgICAgZHVhbC1yb2xlIG1vZGUKPiA+ICsgLSBwb3dlci1kb21haW5zICAg OiBhIHBoYW5kbGUgdG8gVVNCIHBvd2VyIGRvbWFpbiBub2RlIHRvIGNvbnRyb2wgVVNCJ3MKPiA+ ICsgICAgICAgICAgICAgICAgICAgICBNVENNT1MKPiA+ICsKPiA+ICtFeGFtcGxlOgo+ID4gKwo+ ID4gK3VzYjI6IHVzYkAxMTIwMDAwMCB7Cj4gPiArCWNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQy NzAxLW11c2IiLAo+ID4gKwkJICAgICAibWVkaWF0ZWssbXRrLW11c2IiOwo+ID4gKwlyZWcgPSA8 MCAweDExMjAwMDAwIDAgMHgxMDAwPjsKPiA+ICsJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDMyIElS UV9UWVBFX0xFVkVMX0xPVz47Cj4gPiArCWludGVycnVwdC1uYW1lcyA9ICJtYyI7Cj4gPiArCXBo eXMgPSA8JnUycG9ydDIgUEhZX1RZUEVfVVNCMj47Cj4gPiArCXZidXMtc3VwcGx5ID0gPCZ1c2Jf dmJ1cz47Cj4gPiArCWV4dGNvbiA9IDwmZXh0Y29uX3VzYj47Cj4gPiArCWRyX21vZGUgPSAib3Rn IjsKPiA+ICsJY2xvY2tzID0gPCZwZXJpY2ZnIENMS19QRVJJX1VTQjA+LAo+ID4gKwkJIDwmcGVy aWNmZyBDTEtfUEVSSV9VU0IwX01DVT4sCj4gPiArCQkgPCZwZXJpY2ZnIENMS19QRVJJX1VTQl9T TFY+Owo+ID4gKwljbG9jay1uYW1lcyA9ICJtYWluIiwibWN1IiwidW5pdnBsbCI7Cj4gPiArCXBv d2VyLWRvbWFpbnMgPSA8JnNjcHN5cyBNVDI3MDFfUE9XRVJfRE9NQUlOX0lGUl9NU0M+Owo+ID4g K307Cj4gPiAtLSAKPiA+IDEuOS4xCj4gPiAKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IGh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAoKUmVn YXJkcywKTWluLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0AEC282C3 for ; Tue, 22 Jan 2019 09:36:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B720218D9 for ; Tue, 22 Jan 2019 09:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VSTLgPKi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B720218D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2o8u6sZs23Vx61n8JhzNn8S81GQ445O6LmlIJpBiLzY=; b=VSTLgPKiecnyTH Xt+xPkkFDJBLzNz2iRySl+g4evIOkNC4xNRmxfWzN4hUV+pIENPJYOCEZzlQvYKc7CunaCWdsfEwd EhLAssxW6sfVFCcV1JLmWiXdLtHTvOqOiWeasTSU4ijDKUTtnE6o7IQWYTMe7KfKWX7W/go+spv9o NekhKWPZRV1yRCQyxez+hOalciLnbVdrkLe+WlUWRQcSw7PSnpzFoK86rjfhwRk92tlmVan+IUsj0 KpsqGrQbZcXaYi7vsOwUEfT3mz0nINZ/NRwELWKsaYvhNjsUeDtgV4fhy4n+Y1ETiy92YcxHo40Wn UATap+0tyiaW2uR8TLKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glsTu-0000xT-4t; Tue, 22 Jan 2019 09:36:30 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glsTp-0000wO-SJ; Tue, 22 Jan 2019 09:36:28 +0000 X-UUID: fcb1b7d915d447e1aff5719dd0aaf52c-20190122 X-UUID: fcb1b7d915d447e1aff5719dd0aaf52c-20190122 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 198403713; Tue, 22 Jan 2019 01:36:17 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 22 Jan 2019 01:36:15 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 22 Jan 2019 17:36:13 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 22 Jan 2019 17:36:13 +0800 Message-ID: <1548149773.4433.284.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring , Bin Liu Date: Tue, 22 Jan 2019 17:36:13 +0800 In-Reply-To: <20190121151417.GA19238@bogus> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190122_013625_921477_02B3D79F X-CRM114-Status: GOOD ( 26.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hdegoede@redhat.com, chunfeng.yun@mediatek.com, Alan Stern , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bin, Sorry to bother you again, I encounter a problem about the extcon property. I don't find a common driver describing the usb-connector. Is there any driver that I can refer to, specially the way to switch MUSB controller between host and device mode? If it needs to implement by myself, is it possible to emulate an usb-connector driver by extcon-usb-gpio, and also use the notifier mechanism or can you give me some advices? Hi Rob, On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote: > On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > This is not what I said. I gave you the exact text to put. Sorry to misunderstood your meaning last time, I will modify it in next patch. compatible: should be one of "mediatek,mt2701-musb"...,followed by "mediatek,mtk-musb" > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..4305770 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - extcon : external connector for VBUS and ID pin changes detection, > > + needed when supports dual-role mode > > Again, do not use extcon in new bindings. Thanks, ok. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + vbus-supply = <&usb_vbus>; > > + extcon = <&extcon_usb>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > +}; > > -- > > 1.9.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Regards, Min. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7BFC282C3 for ; Tue, 22 Jan 2019 09:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A75D218D9 for ; Tue, 22 Jan 2019 09:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbfAVJgX (ORCPT ); Tue, 22 Jan 2019 04:36:23 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:22898 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727332AbfAVJgV (ORCPT ); Tue, 22 Jan 2019 04:36:21 -0500 X-UUID: 77f2512ae73b451db95e1ea4fdd29c38-20190122 X-UUID: 77f2512ae73b451db95e1ea4fdd29c38-20190122 Received: from mtkcas36.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 271746080; Tue, 22 Jan 2019 17:36:15 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 22 Jan 2019 17:36:13 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 22 Jan 2019 17:36:13 +0800 Message-ID: <1548149773.4433.284.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring , Bin Liu CC: Mark Rutland , , , , Greg Kroah-Hartman , , , Matthias Brugger , Alan Stern , , , Date: Tue, 22 Jan 2019 17:36:13 +0800 In-Reply-To: <20190121151417.GA19238@bogus> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, Sorry to bother you again, I encounter a problem about the extcon property. I don't find a common driver describing the usb-connector. Is there any driver that I can refer to, specially the way to switch MUSB controller between host and device mode? If it needs to implement by myself, is it possible to emulate an usb-connector driver by extcon-usb-gpio, and also use the notifier mechanism or can you give me some advices? Hi Rob, On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote: > On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > This is not what I said. I gave you the exact text to put. Sorry to misunderstood your meaning last time, I will modify it in next patch. compatible: should be one of "mediatek,mt2701-musb"...,followed by "mediatek,mtk-musb" > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..4305770 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,43 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - extcon : external connector for VBUS and ID pin changes detection, > > + needed when supports dual-role mode > > Again, do not use extcon in new bindings. Thanks, ok. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + vbus-supply = <&usb_vbus>; > > + extcon = <&extcon_usb>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > +}; > > -- > > 1.9.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Regards, Min.