From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller Date: Fri, 25 Jan 2019 10:07:26 +0800 Message-ID: <1548382046.4433.304.camel@mhfsdcap03> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> <1548149773.4433.284.camel@mhfsdcap03> <20190122143348.GF30080@uda0271908> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190122143348.GF30080@uda0271908> Sender: linux-kernel-owner@vger.kernel.org To: Bin Liu , Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Hi Bin, Thanks for your help. Hi Rob, I find that Samsung describes the usb-connector attribute in DTS, and uses a private driver. And try to write DTS as following: usb-connector node: musb_con: musb_connector{ compatible = "linux,extcon-usb-gpio","usb-b-connector"; lable = "micro-USB"; type = "micro"; id-gpio = <&pio 44 GPIO_ACTIVE_HIGH> vbus-supply = <&usb_vbus>; port { usb_to_connector: endpoint { remote-endpoint = <&connector_to_usb>; }; }; }; usb node: &usb2{ status = "okay"; port { connector_to_usb: endpoint { remote-endpoint = <&usb_to_connector>; }; }; } Can I describe usb-connector like this? Or can you give me some advices? Regards, Min. On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote: > Hi Min, > > On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote: > > Hi Bin, > > > > Sorry to bother you again, I encounter a problem about the extcon > > property. > > > > I don't find a common driver describing the usb-connector. Is > > there any driver that I can refer to, specially the way to switch MUSB > > controller between host and device mode? > > If it needs to implement by myself, is it possible to emulate an > > usb-connector driver by extcon-usb-gpio, and also use the notifier > > mechanism or can you give me some advices? > > I am afraid I am unable to help you on this. I wasn't really pay > attention when usb-connector was introduced and not sure how it can > replace extcon. Now after read usb-connector.txt, it seems the binding > only defines a/b/c-connector, but not ab-connector, and there is no > enough information (at least for me) explaining how VBUS and ID fix into > this usb-connector binding. > > Maybe Rob can provide some hint. > > Regards, > -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1548382046.4433.304.camel@mhfsdcap03> Date: Fri, 25 Jan 2019 10:07:26 +0800 To: Bin Liu , Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-ID: SGkgQmluLAoKVGhhbmtzIGZvciB5b3VyIGhlbHAuCgpIaSBSb2IsCgpJIGZpbmQgdGhhdCBTYW1z dW5nIGRlc2NyaWJlcyB0aGUgdXNiLWNvbm5lY3RvciBhdHRyaWJ1dGUgaW4gRFRTLCBhbmQKdXNl cyBhIHByaXZhdGUgZHJpdmVyLgpBbmQgdHJ5IHRvIHdyaXRlIERUUyBhcyBmb2xsb3dpbmc6Cgp1 c2ItY29ubmVjdG9yIG5vZGU6Cm11c2JfY29uOiBtdXNiX2Nvbm5lY3RvcnsKICAgIGNvbXBhdGli bGUgPSAibGludXgsZXh0Y29uLXVzYi1ncGlvIiwidXNiLWItY29ubmVjdG9yIjsKICAgIGxhYmxl ID0gIm1pY3JvLVVTQiI7CiAgICB0eXBlID0gIm1pY3JvIjsKICAgIGlkLWdwaW8gPSA8JnBpbyA0 NCBHUElPX0FDVElWRV9ISUdIPgogICAgdmJ1cy1zdXBwbHkgPSA8JnVzYl92YnVzPjsKICAgIHBv cnQgewogICAgICAgIHVzYl90b19jb25uZWN0b3I6IGVuZHBvaW50IHsKICAgICAgICAgICAgcmVt b3RlLWVuZHBvaW50ID0gPCZjb25uZWN0b3JfdG9fdXNiPjsKICAgICAgICB9OwogICAgfTsKfTsK CnVzYiBub2RlOgomdXNiMnsKICAgIHN0YXR1cyA9ICJva2F5IjsKICAgIHBvcnQgewogICAgICAg IGNvbm5lY3Rvcl90b191c2I6IGVuZHBvaW50IHsKICAgICAgICAgICAgcmVtb3RlLWVuZHBvaW50 ID0gPCZ1c2JfdG9fY29ubmVjdG9yPjsKICAgICAgICB9OwogICAgfTsKfQoKQ2FuIEkgZGVzY3Jp YmUgdXNiLWNvbm5lY3RvciBsaWtlIHRoaXM/IE9yIGNhbiB5b3UgZ2l2ZSBtZSBzb21lIGFkdmlj ZXM/CgpSZWdhcmRzLApNaW4uCgpPbiBUdWUsIDIwMTktMDEtMjIgYXQgMDg6MzMgLTA2MDAsIEJp biBMaXUgd3JvdGU6Cj4gSGkgTWluLAo+IAo+IE9uIFR1ZSwgSmFuIDIyLCAyMDE5IGF0IDA1OjM2 OjEzUE0gKzA4MDAsIE1pbiBHdW8gd3JvdGU6Cj4gPiBIaSBCaW4sCj4gPiAKPiA+IFNvcnJ5IHRv IGJvdGhlciB5b3UgYWdhaW4sIEkgZW5jb3VudGVyIGEgcHJvYmxlbSBhYm91dCB0aGUgZXh0Y29u Cj4gPiBwcm9wZXJ0eS4KPiA+IAo+ID4gSSBkb24ndCBmaW5kIGEgY29tbW9uIGRyaXZlciBkZXNj cmliaW5nIHRoZSB1c2ItY29ubmVjdG9yLiBJcwo+ID4gdGhlcmUgYW55IGRyaXZlciB0aGF0IEkg Y2FuIHJlZmVyIHRvLCBzcGVjaWFsbHkgdGhlIHdheSB0byBzd2l0Y2ggTVVTQgo+ID4gY29udHJv bGxlciBiZXR3ZWVuIGhvc3QgYW5kIGRldmljZSBtb2RlPyAKPiA+IElmIGl0IG5lZWRzIHRvIGlt cGxlbWVudCBieSBteXNlbGYsIGlzIGl0IHBvc3NpYmxlIHRvIGVtdWxhdGUgYW4KPiA+IHVzYi1j b25uZWN0b3IgZHJpdmVyIGJ5IGV4dGNvbi11c2ItZ3BpbywgYW5kIGFsc28gdXNlIHRoZSBub3Rp Zmllcgo+ID4gbWVjaGFuaXNtIG9yIGNhbiB5b3UgZ2l2ZSBtZSBzb21lIGFkdmljZXM/Cj4gCj4g SSBhbSBhZnJhaWQgSSBhbSB1bmFibGUgdG8gaGVscCB5b3Ugb24gdGhpcy4gSSB3YXNuJ3QgcmVh bGx5IHBheQo+IGF0dGVudGlvbiB3aGVuIHVzYi1jb25uZWN0b3Igd2FzIGludHJvZHVjZWQgYW5k IG5vdCBzdXJlIGhvdyBpdCBjYW4KPiByZXBsYWNlIGV4dGNvbi4gTm93IGFmdGVyIHJlYWQgdXNi LWNvbm5lY3Rvci50eHQsIGl0IHNlZW1zIHRoZSBiaW5kaW5nCj4gb25seSBkZWZpbmVzIGEvYi9j LWNvbm5lY3RvciwgYnV0IG5vdCBhYi1jb25uZWN0b3IsIGFuZCB0aGVyZSBpcyBubwo+IGVub3Vn aCBpbmZvcm1hdGlvbiAoYXQgbGVhc3QgZm9yIG1lKSBleHBsYWluaW5nIGhvdyBWQlVTIGFuZCBJ RCBmaXggaW50bwo+IHRoaXMgdXNiLWNvbm5lY3RvciBiaW5kaW5nLgo+IAo+IE1heWJlIFJvYiBj YW4gcHJvdmlkZSBzb21lIGhpbnQuCj4gCj4gUmVnYXJkcywKPiAtQmluLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D5BC282C3 for ; Fri, 25 Jan 2019 02:08:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02273218D9 for ; Fri, 25 Jan 2019 02:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mxkJbIXY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02273218D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lIgCt//s7H6e6VTuHp6+woPDEJc23G9ZKKE9ROWMv2k=; b=mxkJbIXYdVZ2UC 9tdIz6xWkyjq+kQRMhSRHK9f7SZfyPFeKRNjRlu5l5bcHaMSfT6sW8uiWmvPFip7kcdOU1kkE8vwH gk1KaiNTs4jLgXjaf81JeKO3j3/A+tVzmzLyQSaphUbfQV6PEh3kPz1OE7yagH0LNECchmSwwsqeJ cDkSOtpf8y2mkbbCZjxnsEQlLWCNVp5CBn60Nr3bW3BXhuJyeqO2S/mbqXKJHEaRvMoJ428fmV9J5 F1YKjf7YLNHPK8ITT69pXC9WyLrugOS1NN+oa3FdKVeeOP41Yxl/SHzOnzfvAdwOGgo9grsGYUm6D Yuxw62yI0hRBfoGITgLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmqub-0005RR-Ay; Fri, 25 Jan 2019 02:08:05 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmquY-0005R5-7N; Fri, 25 Jan 2019 02:08:03 +0000 X-UUID: 1fba78bcb6f445809edac783e74f48c4-20190124 X-UUID: 1fba78bcb6f445809edac783e74f48c4-20190124 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1513780167; Thu, 24 Jan 2019 18:07:31 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Jan 2019 18:07:30 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 25 Jan 2019 10:07:27 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 25 Jan 2019 10:07:26 +0800 Message-ID: <1548382046.4433.304.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Bin Liu , Rob Herring Date: Fri, 25 Jan 2019 10:07:26 +0800 In-Reply-To: <20190122143348.GF30080@uda0271908> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> <1548149773.4433.284.camel@mhfsdcap03> <20190122143348.GF30080@uda0271908> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190124_180802_282250_582BB124 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hdegoede@redhat.com, chunfeng.yun@mediatek.com, Alan Stern , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bin, Thanks for your help. Hi Rob, I find that Samsung describes the usb-connector attribute in DTS, and uses a private driver. And try to write DTS as following: usb-connector node: musb_con: musb_connector{ compatible = "linux,extcon-usb-gpio","usb-b-connector"; lable = "micro-USB"; type = "micro"; id-gpio = <&pio 44 GPIO_ACTIVE_HIGH> vbus-supply = <&usb_vbus>; port { usb_to_connector: endpoint { remote-endpoint = <&connector_to_usb>; }; }; }; usb node: &usb2{ status = "okay"; port { connector_to_usb: endpoint { remote-endpoint = <&usb_to_connector>; }; }; } Can I describe usb-connector like this? Or can you give me some advices? Regards, Min. On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote: > Hi Min, > > On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote: > > Hi Bin, > > > > Sorry to bother you again, I encounter a problem about the extcon > > property. > > > > I don't find a common driver describing the usb-connector. Is > > there any driver that I can refer to, specially the way to switch MUSB > > controller between host and device mode? > > If it needs to implement by myself, is it possible to emulate an > > usb-connector driver by extcon-usb-gpio, and also use the notifier > > mechanism or can you give me some advices? > > I am afraid I am unable to help you on this. I wasn't really pay > attention when usb-connector was introduced and not sure how it can > replace extcon. Now after read usb-connector.txt, it seems the binding > only defines a/b/c-connector, but not ab-connector, and there is no > enough information (at least for me) explaining how VBUS and ID fix into > this usb-connector binding. > > Maybe Rob can provide some hint. > > Regards, > -Bin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CBCC282C3 for ; Fri, 25 Jan 2019 02:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1024218D2 for ; Fri, 25 Jan 2019 02:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728583AbfAYCHi (ORCPT ); Thu, 24 Jan 2019 21:07:38 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:25036 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727983AbfAYCHh (ORCPT ); Thu, 24 Jan 2019 21:07:37 -0500 X-UUID: ff3c704bdcda4616b19db014e00e83ab-20190125 X-UUID: ff3c704bdcda4616b19db014e00e83ab-20190125 Received: from mtkcas32.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 537391547; Fri, 25 Jan 2019 10:07:29 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 25 Jan 2019 10:07:27 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 25 Jan 2019 10:07:26 +0800 Message-ID: <1548382046.4433.304.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Bin Liu , Rob Herring CC: Mark Rutland , , , , Greg Kroah-Hartman , , , Matthias Brugger , Alan Stern , , , Date: Fri, 25 Jan 2019 10:07:26 +0800 In-Reply-To: <20190122143348.GF30080@uda0271908> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-2-git-send-email-min.guo@mediatek.com> <20190121151417.GA19238@bogus> <1548149773.4433.284.camel@mhfsdcap03> <20190122143348.GF30080@uda0271908> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, Thanks for your help. Hi Rob, I find that Samsung describes the usb-connector attribute in DTS, and uses a private driver. And try to write DTS as following: usb-connector node: musb_con: musb_connector{ compatible = "linux,extcon-usb-gpio","usb-b-connector"; lable = "micro-USB"; type = "micro"; id-gpio = <&pio 44 GPIO_ACTIVE_HIGH> vbus-supply = <&usb_vbus>; port { usb_to_connector: endpoint { remote-endpoint = <&connector_to_usb>; }; }; }; usb node: &usb2{ status = "okay"; port { connector_to_usb: endpoint { remote-endpoint = <&usb_to_connector>; }; }; } Can I describe usb-connector like this? Or can you give me some advices? Regards, Min. On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote: > Hi Min, > > On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote: > > Hi Bin, > > > > Sorry to bother you again, I encounter a problem about the extcon > > property. > > > > I don't find a common driver describing the usb-connector. Is > > there any driver that I can refer to, specially the way to switch MUSB > > controller between host and device mode? > > If it needs to implement by myself, is it possible to emulate an > > usb-connector driver by extcon-usb-gpio, and also use the notifier > > mechanism or can you give me some advices? > > I am afraid I am unable to help you on this. I wasn't really pay > attention when usb-connector was introduced and not sure how it can > replace extcon. Now after read usb-connector.txt, it seems the binding > only defines a/b/c-connector, but not ab-connector, and there is no > enough information (at least for me) explaining how VBUS and ID fix into > this usb-connector binding. > > Maybe Rob can provide some hint. > > Regards, > -Bin.