All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Zhou Yanjie <zhouyanjie@zoho.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	a.zummo@towertech.it, robh+dt@kernel.org, paul.burton@mips.com,
	mark.rutland@arm.com, syq@debian.org, jiaxun.yang@flygoat.com,
	772753199@qq.com
Subject: Re: Add Ingenic X1000 RTC support.
Date: Mon, 28 Jan 2019 17:48:04 -0300	[thread overview]
Message-ID: <1548708484.7511.3@crapouillou.net> (raw)
In-Reply-To: <20190128201014.GB18309@piout.net>

Hi,

> Hello,
> 
> This seems like a useless renaming to me, can you elaborate a bit 
> more?
> 
> I'd also like to have Paul and Lars-Peter comment.

According to the patchset, the RTC in the X1000 does not behave any 
different
than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped.
In your devicetree bindings, just use the "ingenic,jz4780-rtc" 
compatible
string instead. The same goes for all the drivers (e.g. the uart one).

I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" 
with
just "Ingenic SoCs" since XBurst is just the name of the CPU inside 
these
SoCs.

Regards,
-Paul


  reply	other threads:[~2019-01-28 20:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 17:29 Add Ingenic X1000 RTC support Zhou Yanjie
2019-01-28 17:29 ` [PATCH 1/3] RTC: Ingenic: Add support for the X1000 Zhou Yanjie
2019-01-28 17:29 ` [PATCH 2/3] Dt-bindings: RTC: Add X1000 RTC bindings Zhou Yanjie
2019-01-28 20:11   ` Alexandre Belloni
2019-01-28 17:29 ` [PATCH 3/3] RTC: Ingenic: Replace jz47xx with XBurst Zhou Yanjie
2019-01-28 20:13   ` Alexandre Belloni
2019-01-28 20:10 ` Add Ingenic X1000 RTC support Alexandre Belloni
2019-01-28 20:48   ` Paul Cercueil [this message]
2019-01-29  3:53     ` Zhou Yanjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548708484.7511.3@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=772753199@qq.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=paul.burton@mips.com \
    --cc=robh+dt@kernel.org \
    --cc=syq@debian.org \
    --cc=zhouyanjie@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.