From: guoren@kernel.org
To: arnd@arndb.de, robh+dt@kernel.org, marc.zyngier@arm.com
Cc: linux-kernel@vger.kernel.org, guoren@kernel.org,
linux-arch@vger.kernel.org, Guo Ren <ren_guo@c-sky.com>
Subject: [PATCH 08/10] csky: coding convention: Use task_stack_page
Date: Tue, 29 Jan 2019 20:24:27 +0800 [thread overview]
Message-ID: <1548764669-16656-8-git-send-email-guoren@kernel.org> (raw)
In-Reply-To: <1548764669-16656-1-git-send-email-guoren@kernel.org>
From: Guo Ren <ren_guo@c-sky.com>
Use task_stack_page instead of p->stack to get stack. Follow the coding
convention style. Also for init_stack, the same with other archs.
Signed-off-by: Guo Ren <ren_guo@c-sky.com>
---
arch/csky/include/asm/processor.h | 4 ++--
arch/csky/kernel/smp.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/csky/include/asm/processor.h b/arch/csky/include/asm/processor.h
index 8f45481..21e0bd5 100644
--- a/arch/csky/include/asm/processor.h
+++ b/arch/csky/include/asm/processor.h
@@ -49,7 +49,7 @@ struct thread_struct {
};
#define INIT_THREAD { \
- .ksp = (unsigned long) init_thread_union.stack + THREAD_SIZE, \
+ .ksp = sizeof(init_stack) + (unsigned long) &init_stack, \
.sr = DEFAULT_PSR_VALUE, \
}
@@ -95,7 +95,7 @@ unsigned long get_wchan(struct task_struct *p);
#define KSTK_ESP(tsk) (task_pt_regs(tsk)->usp)
#define task_pt_regs(p) \
- ((struct pt_regs *)(THREAD_SIZE + p->stack) - 1)
+ ((struct pt_regs *)(THREAD_SIZE + task_stack_page(p)) - 1)
#define cpu_relax() barrier()
diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c
index ddc4dd7..b07a534 100644
--- a/arch/csky/kernel/smp.c
+++ b/arch/csky/kernel/smp.c
@@ -160,7 +160,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *tidle)
{
unsigned long mask = 1 << cpu;
- secondary_stack = (unsigned int)tidle->stack + THREAD_SIZE - 8;
+ secondary_stack =
+ (unsigned int) task_stack_page(tidle) + THREAD_SIZE - 8;
secondary_hint = mfcr("cr31");
secondary_ccr = mfcr("cr18");
--
2.7.4
next prev parent reply other threads:[~2019-01-29 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 12:24 [PATCH 01/10] irqchip/csky: Support csky,dh7k SOC intc driver guoren
2019-01-29 12:24 ` [PATCH 02/10] dt-bindings: csky,apb-intc: Add dh7k SOC support guoren
2019-01-29 12:24 ` [PATCH 03/10] csky: Fixup _PAGE_GLOBAL bit for 610 tlb entry guoren
2019-01-29 12:24 ` [PATCH 04/10] irqchip/csky: Optimize remove unnecessary loop irq handle guoren
2019-01-29 12:24 ` [PATCH 05/10] irqchip/irq-csky-mpintc: Add triger type and priority guoren
2019-01-29 12:24 ` [PATCH 06/10] dt-bindings: interrupt-controller: Update csky mpintc guoren
2019-01-29 12:24 ` [PATCH 07/10] csky: Fixup wrong pt_regs size guoren
2019-01-29 12:24 ` guoren [this message]
2019-01-29 12:24 ` [PATCH 09/10] dt-bindings: csky,apb-intc: Add vector irq mode guoren
2019-01-29 12:24 ` [PATCH 10/10] irqchip/csky: Add support-vector-irq for apb-intc guoren
2019-02-14 14:03 ` [PATCH 01/10] irqchip/csky: Support csky,dh7k SOC intc driver Marc Zyngier
2019-02-15 1:21 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548764669-16656-8-git-send-email-guoren@kernel.org \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=ren_guo@c-sky.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.