Re: [PATCH v4 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Andrzej,

Thank you for the patch.

On Friday 07 Oct 2016 09:02:41 Andrzej Hajda wrote:
> SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled
> via I2C bus.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/video/bridge/sil-sii8620.txt          | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
> 
> diff --git a/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
> b/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt new file
> mode 100644
> index 0000000..9409d9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
> @@ -0,0 +1,33 @@
> +Silicon Image SiI8620 HDMI/MHL bridge bindings
> +
> +Required properties:
> +	- compatible: "sil,sii8620"
> +	- reg: i2c address of the bridge
> +	- cvcc10-supply: Digital Core Supply Voltage (1.0V)
> +	- iovcc18-supply: I/O Supply Voltage (1.8V)
> +	- interrupts, interrupt-parent: interrupt specifier of INT pin
> +	- reset-gpios: gpio specifier of RESET pin
> +	- clocks, clock-names: specification and name of "xtal" clock
> +	- video interfaces: Device node can contain video interface port
> +			    node for HDMI encoder according to [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +	sii8620@39 {
> +		reg = <0x39>;
> +		compatible = "sil,sii8620";
> +		cvcc10-supply = <&ldo36_reg>;
> +		iovcc18-supply = <&ldo34_reg>;
> +		interrupt-parent = <&gpf0>;
> +		interrupts = <2 0>;
> +		reset-gpio = <&gpv7 0 0>;
> +		clocks = <&pmu_system_controller 0>;
> +		clock-names = "xtal";
> +
> +		port {
> +			mhl_to_hdmi: endpoint {
> +				remote-endpoint = <&hdmi_to_mhl>;
> +			};
> +		};

A bridge, by definition, has two ports, an input port and an output port. You 
should model that in DT.

> +	};

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel