From: Titouan Christophe <titouan.christophe@railnova.eu>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/qt5/qt5base: handle sse2/sse3/ssse3/sse4.1/sse4.2/avx/avx2 configuration
Date: Mon, 04 Feb 2019 17:34:01 +0100 [thread overview]
Message-ID: <1549298041.7318.53.camel@railnova.eu> (raw)
In-Reply-To: <20190201202452.11724-1-ps.report@gmx.net>
Hi Peter,
On Fri, 2019-02-01 at 21:24 +0100, Peter Seiderer wrote:
> The Qt configure auto detection (and anounced runtime detection
> feature) failes (see e.g. [1]), so override the configuration
> with the buildroot determined settings.
>
> [1] http://lists.busybox.net/pipermail/buildroot/2019-January/241862.
> html
>
> Reported-by: David Picard <dplamp@gmx.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
> - suggested by Arnout Vandecappelle [2]
>
> [2] http://lists.busybox.net/pipermail/buildroot/2019-January/242030.
> html
> ---
> package/qt5/qt5base/qt5base.mk | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/package/qt5/qt5base/qt5base.mk
> b/package/qt5/qt5base/qt5base.mk
> index d10f233b46..b84efcc2bf 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -33,6 +33,37 @@ else
> QT5BASE_DEPENDENCIES += pcre2
> endif
>
> +ifeq ($(BR2_X86_CPU_HAS_SSE2),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse2
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE3),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse3
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSSE3),)
> +QT5BASE_CONFIGURE_OPTS += -no-ssse3
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE4),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse4.1
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE42),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse4.2
> +else
> +ifeq ($(BR2_X86_CPU_HAS_AVX),)
> +QT5BASE_CONFIGURE_OPTS += -no-avx
> +else
> +ifeq ($(BR2_X86_CPU_HAS_AVX2),)
> +QT5BASE_CONFIGURE_OPTS += -no-avx2
> +else
> +# no BR2_X86_CPU_HAS_AVX512 for qt configure option
> +# '-no-avx512' (available for latest)
> +endif
> +endif
> +endif
> +endif
> +endif
> +endif
> +endif
Does -no-sse2 implies -no-sse3, -no-ssse3, ... and so on and so forth ?
This is not very clear from the docs I found.
> +
> QT5BASE_CONFIGURE_OPTS += $(call
> qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS))
>
> ifeq ($(BR2_PACKAGE_LIBDRM),y)
Otherwise looks reasonable.
Have a nice Monday !
Titouan
next prev parent reply other threads:[~2019-02-04 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 20:24 [Buildroot] [PATCH v1] package/qt5/qt5base: handle sse2/sse3/ssse3/sse4.1/sse4.2/avx/avx2 configuration Peter Seiderer
2019-02-04 16:34 ` Titouan Christophe [this message]
2019-02-04 20:18 ` Peter Seiderer
2019-02-04 20:14 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549298041.7318.53.camel@railnova.eu \
--to=titouan.christophe@railnova.eu \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.