All of lore.kernel.org
 help / color / mirror / Atom feed
From: Angelo Compagnucci <angelo@amarulasolutions.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/5] package/mender: adding a writable location
Date: Tue,  5 Feb 2019 11:23:44 +0100	[thread overview]
Message-ID: <1549362228-5731-2-git-send-email-angelo@amarulasolutions.com> (raw)
In-Reply-To: <1549362228-5731-1-git-send-email-angelo@amarulasolutions.com>

Mender needs /var/lib/mender to be writable at the service start, the
path is hardcoded and thus we cannot change it.
This patch solves the problem using the same approach we have for
dropbear.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 package/mender/mender.mk      |  2 ++
 package/mender/mender.service | 12 +++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/package/mender/mender.mk b/package/mender/mender.mk
index a5cece7..3203df8 100644
--- a/package/mender/mender.mk
+++ b/package/mender/mender.mk
@@ -49,6 +49,8 @@ define MENDER_INSTALL_CONFIG_FILES
 		$(INSTALL) -D -m 0755 $(@D)/support/mender-inventory-$(f) \
 			$(TARGET_DIR)/usr/share/mender/inventory/mender-inventory-$(f)
 	)
+
+	ln -snf /var/run/mender $(TARGET_DIR)/var/lib/mender
 endef
 
 MENDER_POST_INSTALL_TARGET_HOOKS += MENDER_INSTALL_CONFIG_FILES
diff --git a/package/mender/mender.service b/package/mender/mender.service
index 9ede55a..8b60a4f 100644
--- a/package/mender/mender.service
+++ b/package/mender/mender.service
@@ -6,7 +6,17 @@ After=systemd-resolved.service
 Type=idle
 User=root
 Group=root
-ExecStartPre=/bin/mkdir -p -m 0700 /data/mender
+ExecStartPre=/bin/sh -c '\
+if [ -L /var/lib/mender \
+     -a "$(readlink /var/lib/mender)" = "/var/run/mender" ]; then \
+    if rm -f /var/lib/mender >/dev/null 2>&1; then \
+        mkdir -p /var/lib/mender; \
+    else \
+        echo "No persistent location to store mender data. Data will be lost\
+        echo "at reboot. Are you sure this is what you want to do?"; \
+        mkdir -p "$(readlink /var/lib/mender)"; \
+    fi; \
+fi'
 ExecStart=/usr/bin/mender -daemon
 Restart=on-abort
 
-- 
2.7.4

  reply	other threads:[~2019-02-05 10:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 10:23 [Buildroot] [PATCH v2 0/5] Latest fixings to Mender Angelo Compagnucci
2019-02-05 10:23 ` Angelo Compagnucci [this message]
2019-02-05 10:30   ` [Buildroot] [PATCH v2 1/5] package/mender: adding a writable location Adam Duskett
2019-02-05 10:23 ` [Buildroot] [PATCH v2 2/5] package/mender: adding systemv init file Angelo Compagnucci
2019-02-05 10:29   ` Adam Duskett
2019-02-05 10:40     ` Titouan Christophe
2019-02-05 10:23 ` [Buildroot] [PATCH v2 3/5] package/mender: adding artifact_info file Angelo Compagnucci
2019-02-05 10:30   ` Adam Duskett
2019-02-05 10:23 ` [Buildroot] [PATCH v2 4/5] package/mender: adding device_type file Angelo Compagnucci
2019-02-05 10:29   ` Adam Duskett
2019-02-05 10:23 ` [Buildroot] [PATCH v2 5/5] package/mender: adding a readme file Angelo Compagnucci
2019-02-05 10:28   ` Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549362228-5731-2-git-send-email-angelo@amarulasolutions.com \
    --to=angelo@amarulasolutions.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.