From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] dm: don't overallocate the tags space Date: Fri, 08 Feb 2019 07:58:12 -0800 Message-ID: <1549641492.34241.81.camel@acm.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka , Milan Broz , Mike Snitzer , Ming Lei Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Fri, 2019-02-08 at 10:52 -0500, Mikulas Patocka wrote: > bio_sectors returns the value in the units of 512-byte sectors (no matter > what's the real sector size of the device). dm-crypt multiplies > bio_sectors by on_disk_tag_size to calculate the space allocated for > integrity tags. If dm-crypt is running with sector size larger than 512, > it allocates more data than what's needed. > > Device mapper trimmed this extra space when passing the bio to > dm-integrity, so this bug didn't result in any visible misbehavior. This > bug showed up when device mapper stopped trimming the bio. > > Signed-off-by: Mikulas Patocka > Reported-by: Milan Broz Hi Mikulas, Is this a fix for commit fa8db4948f52 ("dm: don't use bio_trim() afterall")? If so, please consider adding a "Fixes:" tag. Thanks, Bart.