From: "Yavuz, Tuba" <tuba@ece.ufl.edu>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: hso: do not unregister if not registered
Date: Sat, 9 Feb 2019 00:02:56 +0000 [thread overview]
Message-ID: <1549670577031.62975@ece.ufl.edu> (raw)
In-Reply-To: <20190208.150818.2115309831038338250.davem@davemloft.net>
I just resubmitted the patch and made sure to send it in plaintext. Hopefully, it will work this time.
Best,
Tuba
________________________________________
From: David Miller <davem@davemloft.net>
Sent: Friday, February 8, 2019 6:08 PM
To: Yavuz, Tuba
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: hso: do not unregister if not registered
From: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Date: Wed, 6 Feb 2019 00:40:31 +0000
>
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
> Signed-off-by: Tuba Yavuz <tuba@ece.ufl.edu>
This patch is corrupted by your email client.
next prev parent reply other threads:[~2019-02-09 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 0:40 [PATCH] net: hso: do not unregister if not registered Yavuz, Tuba
2019-02-08 23:08 ` David Miller
2019-02-09 0:02 ` Yavuz, Tuba [this message]
2019-02-09 3:40 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-02-09 16:24 Yavuz, Tuba
2019-02-09 17:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549670577031.62975@ece.ufl.edu \
--to=tuba@ece.ufl.edu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.