From: Thomas Monjalon <thomas@monjalon.net>
To: Chas Williams <3chas3@gmail.com>, Chas Williams <chas3@att.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
skhare@vmware.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent
Date: Thu, 05 Apr 2018 12:03:06 +0200 [thread overview]
Message-ID: <1549783.CbrISpF0YD@xps> (raw)
In-Reply-To: <c7a2017c-c78b-4b7c-a7a5-6e172724d4a1@intel.com>
20/03/2018 15:12, Ferruh Yigit:
> On 3/18/2018 1:45 AM, Chas Williams wrote:
> > From: Chas Williams <chas3@att.com>
> >
> > The vmxnet3 never attempts link speed negotiation. As a virtual device
> > the link speed is vague at best. However, it is important for certain
> > applications, like bonding, to see a consistent link_status. 802.3ad
> > requires that only links of the same cost (link speed) be enslaved.
> > Keeping the link status consistent in vmxnet3 avoids races with bonding
> > enslavement.
I don't understand the issue.
Are you sure it is not an issue in bonding?
About the right value to set for virtual PMDs, I don't know, both are fakes.
I thought that AUTONEG better convey the vague link speed you describe.
> > Author: Thomas Monjalon <thomas@monjalon.net>
> > Date: Fri Jan 5 18:38:55 2018 +0100
> >
> > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
> > Cc: stable@dpdk.org
>
> There were a few more PMDs [1] they have been updated from FIXED to AUTONEG with
> above commit, do you think should we update them back to FIXED as well?
>
> [1]
> pcap
> softnic
> vmxnet3
Yes, they all can be fixed/LINK_FIXED :) I guess
next prev parent reply other threads:[~2018-04-05 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 1:45 [PATCH] net/vmxnet3: keep link state consistent Chas Williams
2018-03-20 14:12 ` [dpdk-stable] " Ferruh Yigit
2018-03-20 14:42 ` Chas Williams
2018-04-05 10:03 ` Thomas Monjalon [this message]
2018-04-05 15:01 ` Chas Williams
2018-04-17 19:25 ` Ferruh Yigit
2018-04-17 20:24 ` Thomas Monjalon
2018-04-18 16:23 ` Ferruh Yigit
2018-04-18 16:59 ` Yong Wang
2018-04-20 0:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549783.CbrISpF0YD@xps \
--to=thomas@monjalon.net \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=skhare@vmware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.