From: Bart Van Assche <bvanassche@acm.org>
To: Johannes Thumshirn <jthumshirn@suse.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>
Cc: lsf-pc@lists.linux-foundation.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [LSF/MM TOPIC] improving storage testing
Date: Thu, 14 Feb 2019 15:26:23 -0800 [thread overview]
Message-ID: <1550186783.31902.81.camel@acm.org> (raw)
In-Reply-To: <20190214105507.GA9739@linux-x5ow.site>
On Thu, 2019-02-14 at 11:55 +0100, Johannes Thumshirn wrote:
> On Wed, Feb 13, 2019 at 01:07:54PM -0500, Theodore Y. Ts'o wrote:
> > Also, there are expectations about minimum versions of bash that can
> > be supported; but there aren't necessarily for other components such
> > as nvme-cli, and I suspect that it is due to the use of a overly new
> > version of nvme-cli from its git tree. Is that supposed to work, or
> > should I constrain myself to whatever version is being shipped in
> > Fedora or some other reference distribution? More generally, what is
> > the overall expectations that should be expected? xfstests has some
> > extremely expansive set of sed scripts to normalize shell script
> > output to make xfstests extremely portable; will patches along similar
> > lines something that we should be doing for blktests?
>
> I think this is the root cause of the problems you've sent out mails for this
> week. A lot of blktests test need filtering. See [1] as an example.
>
> [1] https://github.com/osandov/blktests/pull/34
Hi Johannes,
Output of tools like nvme-cli is not an ABI although an ABI is what is
required to make blktests work reliably. One possible approach is to modify
nvme-cli such that it has two output formats: one output format that is
intended for humans and another that is easy to parse by software. I think
we should consider that approach and compare it to using sed scripts.
Bart.
next prev parent reply other threads:[~2019-02-14 23:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 18:07 [LSF/MM TOPIC] improving storage testing Theodore Y. Ts'o
2019-02-14 7:37 ` Chaitanya Kulkarni
2019-02-14 10:55 ` Johannes Thumshirn
2019-02-14 16:21 ` David Sterba
2019-02-14 23:26 ` Bart Van Assche [this message]
2019-02-15 2:52 ` Chaitanya Kulkarni
2019-02-15 7:52 ` Johannes Thumshirn
2019-02-14 12:10 ` Lukas Czerner
2019-02-14 21:28 ` Omar Sandoval
2019-02-14 21:56 ` Omar Sandoval
2019-02-15 3:02 ` Theodore Y. Ts'o
2019-02-15 17:32 ` Keith Busch
2019-02-20 1:33 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550186783.31902.81.camel@acm.org \
--to=bvanassche@acm.org \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.