From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:43100 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732665AbfBSBki (ORCPT ); Mon, 18 Feb 2019 20:40:38 -0500 Message-ID: <1550540432.2534.1.camel@intel.com> Subject: Re: [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol From: Ley Foon Tan Date: Tue, 19 Feb 2019 09:40:32 +0800 In-Reply-To: References: <20190213174005.28785-1-hch@lst.de> <20190213174005.28785-6-hch@lst.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada , Christoph Hellwig Cc: linux-xtensa@linux-xtensa.org, linux-s390 , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, linuxppc-dev , Ley Foon Tan , nios2-dev@lists.rocketboards.org On Fri, 2019-02-15 at 16:55 +0900, Masahiro Yamada wrote: > +CC: Ley Foon Tan > +CC: nios2-dev@lists.rocketboards.org > > > On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig wrote: > > > > > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig > > index 715e6c09b4a5..3b50689007f5 100644 > > --- a/arch/nios2/Kconfig > > +++ b/arch/nios2/Kconfig > > @@ -20,6 +20,7 @@ config NIOS2 > >         select OF_EARLY_FLATTREE > >         select SOC_BUS > >         select SPARSE_IRQ > > +       select TRACE_IRQFLAGS_SUPPORT > > This is a behavior change of nios2. > > TRACE_IRQFLAGS_SUPPORT was previously 'n', > and this commit is changing it to 'y'. > > > > > Strangely, nios2 defines TRACE_IRQFLAGS_SUPPORT twice > with different default values. > > In Kconfig, the first one becomes effective. > > In this case, 'def_bool n' in arch/nios2/Kconfig is used. > 'def_bool y' in arch/nios2/Kconfig.debug is dead code. > > > I think this select should be dropped > to keep the current behavior, > but I hope the NIOS2 maintainer will give us > some comments just in case. > Yes, please drop this patch to keep original behavior. Thanks. Regards Ley Foon > > > > > > >         select USB_ARCH_HAS_HCD if USB_SUPPORT > >         select CPU_NO_EFFICIENT_FFS > >         select ARCH_DISCARD_MEMBLOCK > > @@ -39,9 +40,6 @@ config NO_IOPORT_MAP > >  config FPU > >         def_bool n > > > > -config TRACE_IRQFLAGS_SUPPORT > > -       def_bool n > > - > >  menu "Kernel features" > > > >  source "kernel/Kconfig.hz" > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > > index f1da8a7b17ff..a8bc06e96ef5 100644 > > --- a/arch/nios2/Kconfig.debug > > +++ b/arch/nios2/Kconfig.debug > > @@ -1,8 +1,5 @@ > >  # SPDX-License-Identifier: GPL-2.0 > > > > -config TRACE_IRQFLAGS_SUPPORT > > -       def_bool y > > - > >  config EARLY_PRINTK > >         bool "Activate early kernel debugging" > >         default y > -- > Best Regards > Masahiro Yamada > > ________________________________ > > Confidentiality Notice. > This message may contain information that is confidential or > otherwise protected from disclosure. If you are not the intended > recipient, you are hereby notified that any use, disclosure, > dissemination, distribution, or copying of this message, or any > attachments, is strictly prohibited. If you have received this > message in error, please advise the sender by reply e-mail, and > delete the message and any attachments. Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8930C43381 for ; Tue, 19 Feb 2019 01:40:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B80BD2173C for ; Tue, 19 Feb 2019 01:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FfBtFIgp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B80BD2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DmGOhMT5ZuSStgLhhkheOpEByHOx46pULmivP8dqAC4=; b=FfBtFIgpxdif0+ 4hBka7k1fkHpSNrdJ/WHw1pG0GW1Tvb3sAW3xLOTZRBzUBR8L42JcU7m61BykLigyCWxglj5Ndv2X Mc6XQe9pciTnWuYwH9jMZDtERvm+3zWwCXnosLN6AZDWCMQ0CuiH5q/UZuxvDFXCppF3OUGSe7xCq yErbbVBIx+lPpFA2TLlYk5V6di5GRcFPDxd/XDEI/qHDChI4bBnHhlXKmcP8JHCOQ/U2utlLaFfGF G8/0XjeyAGN45+706tHfSqkhGLNUat+5/qvkranLUqghyT9u+Bi8AXkz6PKe52QGSjSadyDmRziuF Mtcym5avBmLA/eriYvJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvuOo-0008HS-34; Tue, 19 Feb 2019 01:40:42 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvuOl-0008H2-Iv for linux-riscv@lists.infradead.org; Tue, 19 Feb 2019 01:40:41 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 17:40:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,385,1544515200"; d="scan'208";a="134531155" Received: from lftan-mobl.gar.corp.intel.com (HELO ubuntu) ([10.226.248.88]) by FMSMGA003.fm.intel.com with SMTP; 18 Feb 2019 17:40:35 -0800 Received: by ubuntu (sSMTP sendmail emulation); Tue, 19 Feb 2019 09:40:33 +0800 Message-ID: <1550540432.2534.1.camel@intel.com> Subject: Re: [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol From: Ley Foon Tan To: Masahiro Yamada , Christoph Hellwig Date: Tue, 19 Feb 2019 09:40:32 +0800 In-Reply-To: References: <20190213174005.28785-1-hch@lst.de> <20190213174005.28785-6-hch@lst.de> X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190218_174039_636359_738CD085 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, Linux Kbuild mailing list , linux-s390 , Linux Kernel Mailing List , nios2-dev@lists.rocketboards.org, Ley Foon Tan , linux-riscv@lists.infradead.org, linuxppc-dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMDE5LTAyLTE1IGF0IDE2OjU1ICswOTAwLCBNYXNhaGlybyBZYW1hZGEgd3JvdGU6 Cj4gK0NDOiBMZXkgRm9vbiBUYW4gPGxmdGFuQGFsdGVyYS5jb20+Cj4gK0NDOiBuaW9zMi1kZXZA bGlzdHMucm9ja2V0Ym9hcmRzLm9yZwo+IAo+IAo+IE9uIFRodSwgRmViIDE0LCAyMDE5IGF0IDI6 NDAgQU0gQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+IHdyb3RlOgo+IAo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvYXJjaC9uaW9zMi9LY29uZmlnIGIvYXJjaC9uaW9zMi9LY29uZmlnCj4gPiBp bmRleCA3MTVlNmMwOWI0YTUuLjNiNTA2ODkwMDdmNSAxMDA2NDQKPiA+IC0tLSBhL2FyY2gvbmlv czIvS2NvbmZpZwo+ID4gKysrIGIvYXJjaC9uaW9zMi9LY29uZmlnCj4gPiBAQCAtMjAsNiArMjAs NyBAQCBjb25maWcgTklPUzIKPiA+IMKgwqDCoMKgwqDCoMKgwqBzZWxlY3QgT0ZfRUFSTFlfRkxB VFRSRUUKPiA+IMKgwqDCoMKgwqDCoMKgwqBzZWxlY3QgU09DX0JVUwo+ID4gwqDCoMKgwqDCoMKg wqDCoHNlbGVjdCBTUEFSU0VfSVJRCj4gPiArwqDCoMKgwqDCoMKgwqBzZWxlY3QgVFJBQ0VfSVJR RkxBR1NfU1VQUE9SVAo+IAo+IFRoaXMgaXMgYSBiZWhhdmlvciBjaGFuZ2Ugb2YgbmlvczIuCj4g Cj4gVFJBQ0VfSVJRRkxBR1NfU1VQUE9SVCB3YXMgcHJldmlvdXNseSAnbicsCj4gYW5kIHRoaXMg Y29tbWl0IGlzIGNoYW5naW5nIGl0IHRvICd5Jy4KPiAKPiAKPiAKPiAKPiBTdHJhbmdlbHksIG5p b3MyIGRlZmluZXMgVFJBQ0VfSVJRRkxBR1NfU1VQUE9SVCB0d2ljZQo+IHdpdGggZGlmZmVyZW50 IGRlZmF1bHQgdmFsdWVzLgo+IAo+IEluIEtjb25maWcsIHRoZSBmaXJzdCBvbmUgYmVjb21lcyBl ZmZlY3RpdmUuCj4gCj4gSW4gdGhpcyBjYXNlLCAnZGVmX2Jvb2wgbicgaW4gYXJjaC9uaW9zMi9L Y29uZmlnIGlzIHVzZWQuCj4gJ2RlZl9ib29sIHknIGluIGFyY2gvbmlvczIvS2NvbmZpZy5kZWJ1 ZyBpcyBkZWFkIGNvZGUuCj4gCj4gCj4gSSB0aGluayB0aGlzIHNlbGVjdCBzaG91bGQgYmUgZHJv cHBlZAo+IHRvIGtlZXAgdGhlIGN1cnJlbnQgYmVoYXZpb3IsCj4gYnV0IEkgaG9wZSB0aGUgTklP UzIgbWFpbnRhaW5lciB3aWxsIGdpdmUgdXMKPiBzb21lIGNvbW1lbnRzIGp1c3QgaW4gY2FzZS4K PiAKWWVzLCBwbGVhc2UgZHJvcCB0aGlzIHBhdGNoIHRvIGtlZXAgb3JpZ2luYWwgYmVoYXZpb3Iu ClRoYW5rcy4KClJlZ2FyZHMKTGV5IEZvb24KPiAKPiAKPiAKPiA+IAo+ID4gwqDCoMKgwqDCoMKg wqDCoHNlbGVjdCBVU0JfQVJDSF9IQVNfSENEIGlmIFVTQl9TVVBQT1JUCj4gPiDCoMKgwqDCoMKg wqDCoMKgc2VsZWN0IENQVV9OT19FRkZJQ0lFTlRfRkZTCj4gPiDCoMKgwqDCoMKgwqDCoMKgc2Vs ZWN0IEFSQ0hfRElTQ0FSRF9NRU1CTE9DSwo+ID4gQEAgLTM5LDkgKzQwLDYgQEAgY29uZmlnIE5P X0lPUE9SVF9NQVAKPiA+IMKgY29uZmlnIEZQVQo+ID4gwqDCoMKgwqDCoMKgwqDCoGRlZl9ib29s IG4KPiA+IAo+ID4gLWNvbmZpZyBUUkFDRV9JUlFGTEFHU19TVVBQT1JUCj4gPiAtwqDCoMKgwqDC oMKgwqBkZWZfYm9vbCBuCj4gPiAtCj4gPiDCoG1lbnUgIktlcm5lbCBmZWF0dXJlcyIKPiA+IAo+ ID4gwqBzb3VyY2UgImtlcm5lbC9LY29uZmlnLmh6Igo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvbmlv czIvS2NvbmZpZy5kZWJ1ZyBiL2FyY2gvbmlvczIvS2NvbmZpZy5kZWJ1Zwo+ID4gaW5kZXggZjFk YThhN2IxN2ZmLi5hOGJjMDZlOTZlZjUgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL25pb3MyL0tjb25m aWcuZGVidWcKPiA+ICsrKyBiL2FyY2gvbmlvczIvS2NvbmZpZy5kZWJ1Zwo+ID4gQEAgLTEsOCAr MSw1IEBACj4gPiDCoCMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiA+IAo+ID4g LWNvbmZpZyBUUkFDRV9JUlFGTEFHU19TVVBQT1JUCj4gPiAtwqDCoMKgwqDCoMKgwqBkZWZfYm9v bCB5Cj4gPiAtCj4gPiDCoGNvbmZpZyBFQVJMWV9QUklOVEsKPiA+IMKgwqDCoMKgwqDCoMKgwqBi b29sICJBY3RpdmF0ZSBlYXJseSBrZXJuZWwgZGVidWdnaW5nIgo+ID4gwqDCoMKgwqDCoMKgwqDC oGRlZmF1bHQgeQo+IC0tCj4gQmVzdCBSZWdhcmRzCj4gTWFzYWhpcm8gWWFtYWRhCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiAKPiBDb25maWRlbnRpYWxpdHkgTm90aWNl Lgo+IFRoaXMgbWVzc2FnZSBtYXkgY29udGFpbiBpbmZvcm1hdGlvbiB0aGF0IGlzIGNvbmZpZGVu dGlhbCBvcgo+IG90aGVyd2lzZSBwcm90ZWN0ZWQgZnJvbSBkaXNjbG9zdXJlLiBJZiB5b3UgYXJl IG5vdCB0aGUgaW50ZW5kZWQKPiByZWNpcGllbnQsIHlvdSBhcmUgaGVyZWJ5IG5vdGlmaWVkIHRo YXQgYW55IHVzZSwgZGlzY2xvc3VyZSwKPiBkaXNzZW1pbmF0aW9uLCBkaXN0cmlidXRpb24sIG9y IGNvcHlpbmcgb2YgdGhpcyBtZXNzYWdlLCBvciBhbnkKPiBhdHRhY2htZW50cywgaXMgc3RyaWN0 bHkgcHJvaGliaXRlZC4gSWYgeW91IGhhdmUgcmVjZWl2ZWQgdGhpcwo+IG1lc3NhZ2UgaW4gZXJy b3IsIHBsZWFzZSBhZHZpc2UgdGhlIHNlbmRlciBieSByZXBseSBlLW1haWwsIGFuZAo+IGRlbGV0 ZSB0aGUgbWVzc2FnZSBhbmQgYW55IGF0dGFjaG1lbnRzLiBUaGFuayB5b3UuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5n IGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26657C43381 for ; Tue, 19 Feb 2019 01:42:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69035217D9 for ; Tue, 19 Feb 2019 01:42:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69035217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 443NlR6QcWzDqJq for ; Tue, 19 Feb 2019 12:42:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=intel.com (client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ley.foon.tan@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 443NjW3GrRzDqH1 for ; Tue, 19 Feb 2019 12:40:40 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 17:40:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,385,1544515200"; d="scan'208";a="134531155" Received: from lftan-mobl.gar.corp.intel.com (HELO ubuntu) ([10.226.248.88]) by FMSMGA003.fm.intel.com with SMTP; 18 Feb 2019 17:40:35 -0800 Received: by ubuntu (sSMTP sendmail emulation); Tue, 19 Feb 2019 09:40:33 +0800 Message-ID: <1550540432.2534.1.camel@intel.com> Subject: Re: [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol From: Ley Foon Tan To: Masahiro Yamada , Christoph Hellwig Date: Tue, 19 Feb 2019 09:40:32 +0800 In-Reply-To: References: <20190213174005.28785-1-hch@lst.de> <20190213174005.28785-6-hch@lst.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, Linux Kbuild mailing list , linux-s390 , Linux Kernel Mailing List , nios2-dev@lists.rocketboards.org, Ley Foon Tan , linux-riscv@lists.infradead.org, linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2019-02-15 at 16:55 +0900, Masahiro Yamada wrote: > +CC: Ley Foon Tan > +CC: nios2-dev@lists.rocketboards.org >=20 >=20 > On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig wrote: >=20 > >=20 > > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig > > index 715e6c09b4a5..3b50689007f5 100644 > > --- a/arch/nios2/Kconfig > > +++ b/arch/nios2/Kconfig > > @@ -20,6 +20,7 @@ config NIOS2 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select OF_EARLY_FLATTRE= E > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select SOC_BUS > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select SPARSE_IRQ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select TRACE_IRQFLAGS_SUPPOR= T >=20 > This is a behavior change of nios2. >=20 > TRACE_IRQFLAGS_SUPPORT was previously 'n', > and this commit is changing it to 'y'. >=20 >=20 >=20 >=20 > Strangely, nios2 defines TRACE_IRQFLAGS_SUPPORT twice > with different default values. >=20 > In Kconfig, the first one becomes effective. >=20 > In this case, 'def_bool n' in arch/nios2/Kconfig is used. > 'def_bool y' in arch/nios2/Kconfig.debug is dead code. >=20 >=20 > I think this select should be dropped > to keep the current behavior, > but I hope the NIOS2 maintainer will give us > some comments just in case. >=20 Yes, please drop this patch to keep original behavior. Thanks. Regards Ley Foon >=20 >=20 >=20 > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select USB_ARCH_HAS_HCD= if USB_SUPPORT > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select CPU_NO_EFFICIENT= _FFS > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select ARCH_DISCARD_MEM= BLOCK > > @@ -39,9 +40,6 @@ config NO_IOPORT_MAP > > =C2=A0config FPU > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0def_bool n > >=20 > > -config TRACE_IRQFLAGS_SUPPORT > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0def_bool n > > - > > =C2=A0menu "Kernel features" > >=20 > > =C2=A0source "kernel/Kconfig.hz" > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > > index f1da8a7b17ff..a8bc06e96ef5 100644 > > --- a/arch/nios2/Kconfig.debug > > +++ b/arch/nios2/Kconfig.debug > > @@ -1,8 +1,5 @@ > > =C2=A0# SPDX-License-Identifier: GPL-2.0 > >=20 > > -config TRACE_IRQFLAGS_SUPPORT > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0def_bool y > > - > > =C2=A0config EARLY_PRINTK > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool "Activate early ke= rnel debugging" > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default y > -- > Best Regards > Masahiro Yamada >=20 > ________________________________ >=20 > Confidentiality Notice. > This message may contain information that is confidential or > otherwise protected from disclosure. If you are not the intended > recipient, you are hereby notified that any use, disclosure, > dissemination, distribution, or copying of this message, or any > attachments, is strictly prohibited. If you have received this > message in error, please advise the sender by reply e-mail, and > delete the message and any attachments. Thank you.