From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] build: set RTE_ARCH_64 based on pointer size
Date: Tue, 19 Feb 2019 15:07:41 +0000 [thread overview]
Message-ID: <1550588861.3736.2.camel@debian.org> (raw)
In-Reply-To: <20180926091536.61370-1-bruce.richardson@intel.com>
On Wed, 2018-09-26 at 10:15 +0100, Bruce Richardson wrote:
> Rather than relying on the target machine architecture, use the
> size of a pointer from the compiler to determine if we are 64-bits
> or not. This allows correct behaviour when you pass -m32 as a compile
> option. It also allows us to use this value repeatedly throughout the
> repo rather than continually testing for the sizeof(void*).
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/arm/meson.build | 3 +--
> config/meson.build | 5 ++++-
> config/ppc_64/meson.build | 4 +++-
> config/x86/meson.build | 3 +--
> drivers/net/sfc/meson.build | 2 +-
> lib/librte_bpf/meson.build | 2 +-
> lib/librte_kni/meson.build | 2 +-
> 7 files changed, 12 insertions(+), 9 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2019-02-19 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 9:15 [PATCH] build: set RTE_ARCH_64 based on pointer size Bruce Richardson
2018-09-26 9:45 ` Bruce Richardson
2018-09-26 10:18 ` Luca Boccassi
2019-02-26 17:34 ` Thomas Monjalon
2019-02-19 15:07 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550588861.3736.2.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.