From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller Date: Mon, 25 Feb 2019 09:36:44 +0800 Message-ID: <1551058604.12020.34.camel@mhfsdcap03> References: <1550561795-31132-1-git-send-email-min.guo@mediatek.com> <1550561795-31132-2-git-send-email-min.guo@mediatek.com> <20190222164923.GA26413@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190222164923.GA26413@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-Id: linux-mediatek@lists.infradead.org Hi Rob, On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v5: > > suggested by Rob: > > 1. Modify compatible as > > - compatible : should be one of: > > "mediatek,mt-2701" > > ... > > followed by "mediatek,mtk-musb" > > 2. Add usb connector child node > > > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..0632e6e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,54 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be one of: > > + "mediatek,mt-2701" > > That looks like a top-level SoC compatible and doesn't match the > example. "mediatek,mt-2701" is an example, just to describe a specific SOC. May I modify compatibel like: compatible : should be "mediatek,mtk-musb" > > + ... > > + followed by "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > Not much point in a name when there is only 1. The MUSB core driver has two interrupts, one is for MAC, another for DMA, but on MTK platform, there is only a MAC interrupt, musb core driver uses platform_get_irq_byname(pdev, "mc") to get this interrupt number. > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Required child nodes: > > + usb connector node as defined in bindings/connector/usb-connector.txt > > + - extcon : for VBUS and ID pin changes detection, needed when > > + supports dual-role mode > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > + usb_con: connector{ > > + compatible = "usb-b-connector"; > > + label = "micro-USB"; > > + type = "micro"; > > + extcon = <&extcon_usb>; > > The connector node should replace 'extcon'. Add what you need here > directly (e.g. id-gpios). What you add needs to be defined in > usb-connector.txt. OK. > > + vbus-supply = <&usb_vbus>; > > + }; > > +}; > > -- > > 1.9.1 > > Regards, Min. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1551058604.12020.34.camel@mhfsdcap03> Date: Mon, 25 Feb 2019 09:36:44 +0800 To: Rob Herring Cc: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-ID: SGkgUm9iLApPbiBGcmksIDIwMTktMDItMjIgYXQgMTA6NDkgLTA2MDAsIFJvYiBIZXJyaW5nIHdy b3RlOgo+IE9uIFR1ZSwgRmViIDE5LCAyMDE5IGF0IDAzOjM2OjMwUE0gKzA4MDAsIG1pbi5ndW9A bWVkaWF0ZWsuY29tIHdyb3RlOgo+ID4gRnJvbTogTWluIEd1byA8bWluLmd1b0BtZWRpYXRlay5j b20+Cj4gPiAKPiA+IFRoaXMgYWRkcyBzdXBwb3J0IGZvciBNZWRpYVRlayBtdXNiIGNvbnRyb2xs ZXIgaW4KPiA+IGhvc3QsIHBlcmlwaGVyYWwgYW5kIG90ZyBtb2RlLgo+ID4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBNaW4gR3VvIDxtaW4uZ3VvQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4gY2hhbmdl cyBpbiB2NToKPiA+IHN1Z2dlc3RlZCBieSBSb2I6Cj4gPiAxLiBNb2RpZnkgY29tcGF0aWJsZSBh cyAKPiA+IC0gY29tcGF0aWJsZSA6IHNob3VsZCBiZSBvbmUgb2Y6Cj4gPiAgICAgICAgICAgICAg ICAibWVkaWF0ZWssbXQtMjcwMSIKPiA+ICAgICAgICAgICAgICAgIC4uLgo+ID4gICAgICAgICAg ICAgICAgZm9sbG93ZWQgYnkgIm1lZGlhdGVrLG10ay1tdXNiIgo+ID4gMi4gQWRkIHVzYiBjb25u ZWN0b3IgY2hpbGQgbm9kZQo+ID4gCj4gPiBjaGFuZ2VzIGluIHY0Ogo+ID4gc3VnZ2VzdGVkIGJ5 IFNlcmdlaToKPiA+IDEuIFN0cmluZyBhbGlnbm1lbnQKPiA+IAo+ID4gY2hhbmdlcyBpbiB2MzoK PiA+IDEuIG5vIGNoYW5nZXMKPiA+IAo+ID4gY2hhbmdlcyBpbiB2MjoKPiA+IHN1Z2dlc3RlZCBi eSBCaW46Cj4gPiAxLiBNb2RpZnkgRFJDIHRvIERSRAo+ID4gc3VnZ2VzdGVkIGJ5IFJvYjoKPiA+ IDIuIERyb3AgdGhlICI8c29jLW1vZGVsPi1tdXNiIiBpbiBjb21wYXRpYmxlCj4gPiAzLiBSZW1v dmUgcGh5LW5hbWVzCj4gPiA0LiBBZGQgc3BhY2UgYWZ0ZXIgY29tbWEgaW4gY2xvY2stbmFtZXMK PiA+IC0tLQo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4 dCAgICAgIHwgNTQgKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1 NCBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWssbXVzYi50eHQKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWssbXVzYi50 eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG11c2Iu dHh0Cj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5kZXggMDAwMDAwMC4uMDYzMmU2ZQo+ ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3VzYi9tZWRpYXRlayxtdXNiLnR4dAo+ID4gQEAgLTAsMCArMSw1NCBAQAo+ID4gK01lZGlh VGVrIG11c2IgRFJEL09URyBjb250cm9sbGVyCj4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gKwo+ID4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiAr IC0gY29tcGF0aWJsZSAgICAgIDogc2hvdWxkIGJlIG9uZSBvZjoKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAibWVkaWF0ZWssbXQtMjcwMSIKPiAKPiBUaGF0IGxvb2tzIGxpa2UgYSB0b3AtbGV2 ZWwgU29DIGNvbXBhdGlibGUgYW5kIGRvZXNuJ3QgbWF0Y2ggdGhlIAo+IGV4YW1wbGUuCiJtZWRp YXRlayxtdC0yNzAxIiBpcyBhbiBleGFtcGxlLCBqdXN0IHRvIGRlc2NyaWJlIGEgc3BlY2lmaWMg U09DLgpNYXkgSSBtb2RpZnkgY29tcGF0aWJlbCBsaWtlOgpjb21wYXRpYmxlIDogc2hvdWxkIGJl ICJtZWRpYXRlayxtdGstbXVzYiIKCj4gPiArICAgICAgICAgICAgICAgICAgICAgLi4uCj4gPiAr ICAgICAgICAgICAgICAgICAgICAgZm9sbG93ZWQgYnkgIm1lZGlhdGVrLG10ay1tdXNiIgo+ID4g KyAtIHJlZyAgICAgICAgICAgICA6IHNwZWNpZmllcyBwaHlzaWNhbCBiYXNlIGFkZHJlc3MgYW5k IHNpemUgb2YKPiA+ICsgICAgICAgICAgICAgICAgICAgICB0aGUgcmVnaXN0ZXJzCj4gPiArIC0g aW50ZXJydXB0cyAgICAgIDogaW50ZXJydXB0IHVzZWQgYnkgbXVzYiBjb250cm9sbGVyCj4gPiAr IC0gaW50ZXJydXB0LW5hbWVzIDogbXVzdCBiZSAibWMiCj4gCj4gTm90IG11Y2ggcG9pbnQgaW4g YSBuYW1lIHdoZW4gdGhlcmUgaXMgb25seSAxLgpUaGUgTVVTQiBjb3JlIGRyaXZlciBoYXMgdHdv IGludGVycnVwdHMsIG9uZSBpcyBmb3IgTUFDLCBhbm90aGVyIGZvcgpETUEsIGJ1dCBvbiBNVEsg cGxhdGZvcm0sIHRoZXJlIGlzIG9ubHkgYSBNQUMgaW50ZXJydXB0LCBtdXNiIGNvcmUKZHJpdmVy IHVzZXMgcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIm1jIikgdG8gZ2V0IHRoaXMgaW50 ZXJydXB0Cm51bWJlci4KCj4gPiArIC0gcGh5cyAgICAgICAgICAgIDogUEhZIHNwZWNpZmllciBm b3IgdGhlIE9URyBwaHkKPiA+ICsgLSBkcl9tb2RlICAgICAgICAgOiBzaG91bGQgYmUgb25lIG9m ICJob3N0IiwgInBlcmlwaGVyYWwiIG9yICJvdGciLAo+ID4gKyAgICAgICAgICAgICAgICAgICAg IHJlZmVyIHRvIHVzYi9nZW5lcmljLnR4dAo+ID4gKyAtIGNsb2NrcyAgICAgICAgICA6IGEgbGlz dCBvZiBwaGFuZGxlICsgY2xvY2stc3BlY2lmaWVyIHBhaXJzLCBvbmUgZm9yCj4gPiArICAgICAg ICAgICAgICAgICAgICAgZWFjaCBlbnRyeSBpbiBjbG9jay1uYW1lcwo+ID4gKyAtIGNsb2NrLW5h bWVzICAgICA6IG11c3QgY29udGFpbiAibWFpbiIsICJtY3UiLCAidW5pdnBsbCIKPiA+ICsgICAg ICAgICAgICAgICAgICAgICBmb3IgY2xvY2tzIG9mIGNvbnRyb2xsZXIKPiA+ICsKPiA+ICtPcHRp b25hbCBwcm9wZXJ0aWVzOgo+ID4gKyAtIHBvd2VyLWRvbWFpbnMgICA6IGEgcGhhbmRsZSB0byBV U0IgcG93ZXIgZG9tYWluIG5vZGUgdG8gY29udHJvbCBVU0Incwo+ID4gKyAgICAgICAgICAgICAg ICAgICAgIE1UQ01PUwo+ID4gKwo+ID4gK1JlcXVpcmVkIGNoaWxkIG5vZGVzOgo+ID4gKyB1c2Ig Y29ubmVjdG9yIG5vZGUgYXMgZGVmaW5lZCBpbiBiaW5kaW5ncy9jb25uZWN0b3IvdXNiLWNvbm5l Y3Rvci50eHQKPiA+ICsgLSBleHRjb24gICAgICAgICAgOiBmb3IgVkJVUyBhbmQgSUQgcGluIGNo YW5nZXMgZGV0ZWN0aW9uLCBuZWVkZWQgd2hlbgo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHN1 cHBvcnRzIGR1YWwtcm9sZSBtb2RlCj4gPiArIC0gdmJ1cy1zdXBwbHkgICAgIDogcmVmZXJlbmNl IHRvIHRoZSBWQlVTIHJlZ3VsYXRvciwgbmVlZGVkIHdoZW4gc3VwcG9ydHMKPiA+ICsgICAgICAg ICAgICAgICAgICAgICBkdWFsLXJvbGUgbW9kZQo+ID4gKwo+ID4gK0V4YW1wbGU6Cj4gPiArCj4g PiArdXNiMjogdXNiQDExMjAwMDAwIHsKPiA+ICsJY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDI3 MDEtbXVzYiIsCj4gPiArCQkgICAgICJtZWRpYXRlayxtdGstbXVzYiI7Cj4gPiArCXJlZyA9IDww IDB4MTEyMDAwMDAgMCAweDEwMDA+Owo+ID4gKwlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzIgSVJR X1RZUEVfTEVWRUxfTE9XPjsKPiA+ICsJaW50ZXJydXB0LW5hbWVzID0gIm1jIjsKPiA+ICsJcGh5 cyA9IDwmdTJwb3J0MiBQSFlfVFlQRV9VU0IyPjsKPiA+ICsJZHJfbW9kZSA9ICJvdGciOwo+ID4g KwljbG9ja3MgPSA8JnBlcmljZmcgQ0xLX1BFUklfVVNCMD4sCj4gPiArCQkgPCZwZXJpY2ZnIENM S19QRVJJX1VTQjBfTUNVPiwKPiA+ICsJCSA8JnBlcmljZmcgQ0xLX1BFUklfVVNCX1NMVj47Cj4g PiArCWNsb2NrLW5hbWVzID0gIm1haW4iLCJtY3UiLCJ1bml2cGxsIjsKPiA+ICsJcG93ZXItZG9t YWlucyA9IDwmc2Nwc3lzIE1UMjcwMV9QT1dFUl9ET01BSU5fSUZSX01TQz47Cj4gPiArCXVzYl9j b246IGNvbm5lY3RvcnsKPiA+ICsJCWNvbXBhdGlibGUgPSAidXNiLWItY29ubmVjdG9yIjsKPiA+ ICsJCWxhYmVsID0gIm1pY3JvLVVTQiI7Cj4gPiArCQl0eXBlID0gIm1pY3JvIjsKPiA+ICsJCWV4 dGNvbiA9IDwmZXh0Y29uX3VzYj47Cj4gCj4gVGhlIGNvbm5lY3RvciBub2RlIHNob3VsZCByZXBs YWNlICdleHRjb24nLiBBZGQgd2hhdCB5b3UgbmVlZCBoZXJlIAo+IGRpcmVjdGx5IChlLmcuIGlk LWdwaW9zKS4gV2hhdCB5b3UgYWRkIG5lZWRzIHRvIGJlIGRlZmluZWQgaW4gCj4gdXNiLWNvbm5l Y3Rvci50eHQuCk9LLgoKPiA+ICsJCXZidXMtc3VwcGx5ID0gPCZ1c2JfdmJ1cz47Cj4gPiArCX07 Cj4gPiArfTsKPiA+IC0tIAo+ID4gMS45LjEKPiA+IAoKUmVnYXJkcywKTWluLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979AEC43381 for ; Mon, 25 Feb 2019 01:37:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 670FC21019 for ; Mon, 25 Feb 2019 01:37:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gqLLnS1y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 670FC21019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYgxXRt6ekzLlh/lypPPhDe6kgOkv/i57CbxahUl7QA=; b=gqLLnS1yPhiEV6 n2WI0X9ou3K/cJ/m2lrepDlKMJWpba8u6xQvkRyR/sxUz0aZgYqi6U7JJv5Wu2dhfE0UBwyhDnyvM bgH5l3fJPVTMk5lSB5f4gGDi67owLTw/ia3CoSHyl9ks/aZXzGceHCFSp5TAnUfPweszfZvhmf+iB rjl22iMpjCJudfjoV5meJlPMhvMweunwy4tar+MTAzLk0+C3F/YQG4mj19WGexsttoHq33xybObIt Xc2GvexDYlO69Mp1e0tT3mafG3X5RG5OqcLXi+qLk+zzzGI6fmCDpFjRSrJFRl+/+7TfQVtgcr26T rKLzkQzK/hPcMHAKwhbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gy5CZ-0002NI-Lj; Mon, 25 Feb 2019 01:37:03 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gy5CV-0002Lr-1i; Mon, 25 Feb 2019 01:37:00 +0000 X-UUID: 358b68cd4f184f5ab651b1ddc3c2e8c5-20190224 X-UUID: 358b68cd4f184f5ab651b1ddc3c2e8c5-20190224 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1781849231; Sun, 24 Feb 2019 17:36:49 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 24 Feb 2019 17:36:47 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Feb 2019 09:36:44 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 25 Feb 2019 09:36:44 +0800 Message-ID: <1551058604.12020.34.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring Date: Mon, 25 Feb 2019 09:36:44 +0800 In-Reply-To: <20190222164923.GA26413@bogus> References: <1550561795-31132-1-git-send-email-min.guo@mediatek.com> <1550561795-31132-2-git-send-email-min.guo@mediatek.com> <20190222164923.GA26413@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190224_173659_097481_F074E2B5 X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, Bin Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v5: > > suggested by Rob: > > 1. Modify compatible as > > - compatible : should be one of: > > "mediatek,mt-2701" > > ... > > followed by "mediatek,mtk-musb" > > 2. Add usb connector child node > > > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..0632e6e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,54 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be one of: > > + "mediatek,mt-2701" > > That looks like a top-level SoC compatible and doesn't match the > example. "mediatek,mt-2701" is an example, just to describe a specific SOC. May I modify compatibel like: compatible : should be "mediatek,mtk-musb" > > + ... > > + followed by "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > Not much point in a name when there is only 1. The MUSB core driver has two interrupts, one is for MAC, another for DMA, but on MTK platform, there is only a MAC interrupt, musb core driver uses platform_get_irq_byname(pdev, "mc") to get this interrupt number. > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Required child nodes: > > + usb connector node as defined in bindings/connector/usb-connector.txt > > + - extcon : for VBUS and ID pin changes detection, needed when > > + supports dual-role mode > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > + usb_con: connector{ > > + compatible = "usb-b-connector"; > > + label = "micro-USB"; > > + type = "micro"; > > + extcon = <&extcon_usb>; > > The connector node should replace 'extcon'. Add what you need here > directly (e.g. id-gpios). What you add needs to be defined in > usb-connector.txt. OK. > > + vbus-supply = <&usb_vbus>; > > + }; > > +}; > > -- > > 1.9.1 > > Regards, Min. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B681C43381 for ; Mon, 25 Feb 2019 01:36:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 090A421019 for ; Mon, 25 Feb 2019 01:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbfBYBgv (ORCPT ); Sun, 24 Feb 2019 20:36:51 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:47330 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726461AbfBYBgv (ORCPT ); Sun, 24 Feb 2019 20:36:51 -0500 X-UUID: 7fd205b0ed164c14b72a003a086299a1-20190225 X-UUID: 7fd205b0ed164c14b72a003a086299a1-20190225 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1631350980; Mon, 25 Feb 2019 09:36:46 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Feb 2019 09:36:44 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 25 Feb 2019 09:36:44 +0800 Message-ID: <1551058604.12020.34.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring CC: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , , , , , , , , Date: Mon, 25 Feb 2019 09:36:44 +0800 In-Reply-To: <20190222164923.GA26413@bogus> References: <1550561795-31132-1-git-send-email-min.guo@mediatek.com> <1550561795-31132-2-git-send-email-min.guo@mediatek.com> <20190222164923.GA26413@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v5: > > suggested by Rob: > > 1. Modify compatible as > > - compatible : should be one of: > > "mediatek,mt-2701" > > ... > > followed by "mediatek,mtk-musb" > > 2. Add usb connector child node > > > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..0632e6e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,54 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be one of: > > + "mediatek,mt-2701" > > That looks like a top-level SoC compatible and doesn't match the > example. "mediatek,mt-2701" is an example, just to describe a specific SOC. May I modify compatibel like: compatible : should be "mediatek,mtk-musb" > > + ... > > + followed by "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > Not much point in a name when there is only 1. The MUSB core driver has two interrupts, one is for MAC, another for DMA, but on MTK platform, there is only a MAC interrupt, musb core driver uses platform_get_irq_byname(pdev, "mc") to get this interrupt number. > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Required child nodes: > > + usb connector node as defined in bindings/connector/usb-connector.txt > > + - extcon : for VBUS and ID pin changes detection, needed when > > + supports dual-role mode > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > + usb_con: connector{ > > + compatible = "usb-b-connector"; > > + label = "micro-USB"; > > + type = "micro"; > > + extcon = <&extcon_usb>; > > The connector node should replace 'extcon'. Add what you need here > directly (e.g. id-gpios). What you add needs to be defined in > usb-connector.txt. OK. > > + vbus-supply = <&usb_vbus>; > > + }; > > +}; > > -- > > 1.9.1 > > Regards, Min.