All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Markku Savela <msa@moth.iki.fi>,
	linux-integrity@vger.kernel.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>
Subject: Re: IMA fails to see TPM chip (rpi3, linaro optee)
Date: Tue, 26 Feb 2019 07:14:37 -0500	[thread overview]
Message-ID: <1551183277.27819.66.camel@linux.ibm.com> (raw)
In-Reply-To: <357e44f8-df31-48ec-d2f0-deabd0161fc0@moth.iki.fi>

On Tue, 2019-02-26 at 10:12 +0200, Markku Savela wrote:
> In case anyone is interested, I got IMA to accept TPM chip in my special 
> case (linaro optee kernel) by changing
> 
>    clk-bcm2835.c: core_initcall -> susbsys_initcall
>    raspberrypi.c: subsys_initcall -> core_initcall
> 
> At first check, the system seems to be ok. Maybe some combination of 
> initcalls could work, but this is enough for me.

Thank you for sharing this!

Mimi

> 
> diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
> index d6caac9c3..7cdd597f1 100644
> --- a/drivers/clk/bcm/clk-bcm2835.c
> +++ b/drivers/clk/bcm/clk-bcm2835.c
> @@ -2330,7 +2330,7 @@ static int __init __bcm2835_clk_driver_init(void)
>   {
>          return platform_driver_register(&bcm2835_clk_driver);
>   }
> -core_initcall(__bcm2835_clk_driver_init);
> +subsys_initcall(__bcm2835_clk_driver_init);
> 
>   MODULE_AUTHOR("Eric Anholt <eric@anholt.net>");
>   MODULE_DESCRIPTION("BCM2835 clock driver");
> diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
> index a82819a78..dfa362e1c 100644
> --- a/drivers/firmware/raspberrypi.c
> +++ b/drivers/firmware/raspberrypi.c
> @@ -457,7 +457,7 @@ static int __init rpi_firmware_init(void)
>   out1:
>          return ret;
>   }
> -subsys_initcall(rpi_firmware_init);
> +core_initcall(rpi_firmware_init);
> 
>   static void __init rpi_firmware_exit(void)
>   {


  reply	other threads:[~2019-02-26 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  9:36 IMA fails to see TPM chip (rpi3, linaro optee) Markku Savela
2019-02-18 10:13 ` Markku Savela
2019-02-20  8:14   ` Markku Savela
2019-02-21  9:08     ` Markku Savela
2019-02-21 12:49       ` Mimi Zohar
2019-02-21 13:17         ` Markku Savela
2019-02-21 13:23           ` Markku Savela
2019-02-26  8:12             ` Markku Savela
2019-02-26 12:14               ` Mimi Zohar [this message]
2019-02-26 12:38                 ` Ard Biesheuvel
2019-02-26 14:04                   ` Mimi Zohar
2019-02-26 18:09                     ` Jarkko Sakkinen
2019-02-26 19:05                       ` Mimi Zohar
2019-03-07 17:15                 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551183277.27819.66.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=PeterHuewe@gmx.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=msa@moth.iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.