From: Oliver Neukum <oneukum@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Subject: USB: usb.h: tweak struct urb to remove wasted space
Date: Sat, 02 Mar 2019 14:51:41 +0100 [thread overview]
Message-ID: <1551534701.16887.2.camel@suse.com> (raw)
On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote:
> > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote:
> > > By moving one field around in 'struct urb' we reduce the size of the
> > > structure by 8 bytes.
> >
> > If you are going for this I have to ask why unlink and status
> > are full size ints anyway.
>
> History, they hold a "normal" negative error code. I guess we could
> turn them into s16, if it really matters, but that feels odd to me.
Returning internal error codes to user space is a bug.
Regards
Oliver
next reply other threads:[~2019-03-02 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 13:51 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-04 18:31 USB: usb.h: tweak struct urb to remove wasted space Oliver Neukum
2019-03-02 14:36 Greg Kroah-Hartman
2019-03-02 8:00 Greg Kroah-Hartman
2019-03-01 19:44 Oliver Neukum
2019-03-01 17:22 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551534701.16887.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.