From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Tue, 05 Mar 2019 20:49:16 +0000 Subject: Re: [PATCH] scsi: target: add device product id and revision configfs attributes Message-Id: <1551818956.31902.269.camel@acm.org> List-Id: References: <1551480260-1265-1-git-send-email-alan.adamson@oracle.com> In-Reply-To: <1551480260-1265-1-git-send-email-alan.adamson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: target-devel@vger.kernel.org On Fri, 2019-03-01 at 14:44 -0800, Alan Adamson wrote: +AD4 +- for (i +AD0 0+ADs i +ADw len+ADs i+-+-) +AHs +AD4 +- if ((buf+AFs-i+AF0 +ADw 0x20) +AHwAfA (buf+AFs-i+AF0 +AD4 0x7E)) +AHs If you have to repost this patch please leave out the superfluous parentheses. Otherwise this patch looks good to me. Hence: Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4-