From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C74FC43381 for ; Wed, 6 Mar 2019 09:46:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4925A20661 for ; Wed, 6 Mar 2019 09:46:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r1fBJJSS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4925A20661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IL0TpCRt9BZmCtovNcRq9c/bdYYkotx54Z3h63vox8o=; b=r1fBJJSSZukD3b Hn9Vs6aOlOrcWp8UTZ+B6vqG28I2xEvkrHVaCrhfEg7wEtkDz0kdO6Xkl8f6bGTI8iHSa7JYBbB6V u/FpkxOIsUc5PIgPfiMSbGfi2V/vjIeXn6C9YaaeaVY95dmbfNDy3sb6/F9axNPArjicKmNTihHqp 6agEPjZxRGW4USG9a8joX3NTMvQP7xTwfkBK5Dts57Df1CcdlvaplozcQ2UrVlrW/jkCFJRWmGl3y FoalEufps25I0eqesJBskEOEqIG8DzKwSIjFZf4GK346YhXU+TSTP06zdCI8gzQOja0bHy+WZy/SZ Qrtm0ZWmwHIIWPalsvIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1T7h-0000oG-Mv; Wed, 06 Mar 2019 09:46:01 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1T7e-0000nk-5G for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 09:45:59 +0000 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h1T7b-0006X3-3u; Wed, 06 Mar 2019 10:45:55 +0100 Message-ID: <1551865552.9298.24.camel@pengutronix.de> Subject: Re: Smarter Kconfig help From: Lucas Stach To: Russell King - ARM Linux admin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 06 Mar 2019 10:45:52 +0100 In-Reply-To: <20190305173111.t3n6ycktht7kxuhq@shell.armlinux.org.uk> References: <20190305173111.t3n6ycktht7kxuhq@shell.armlinux.org.uk> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_014558_360653_92372457 X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Greg Kroah-Hartman , Andy Shevchenko , Peng Hao Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUnVzc2VsbCwKCkFtIERpZW5zdGFnLCBkZW4gMDUuMDMuMjAxOSwgMTc6MzEgKzAwMDAgc2No cmllYiBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggYWRtaW46Cj4gR3V5cywKPiAKPiBXZSBuZWVk IHRvIGJlIHNtYXJ0ZXIgd2hlbiB3cml0aW5nIEtjb25maWcgaGVscC7CoMKgSSdtIGp1c3QgZ29p bmcKPiB0aHJvdWdoIHVwZGF0aW5nIG15IGJ1aWxkIHRyZWVzIHdpdGggdGhlIHJlc3VsdHMgb2Yg NS4wIGRldmVsb3BtZW50LAo+IGFuZCBhIG51bWJlciBvZiB0aGUgaGVscCB0ZXh0cyBhcmUgbmV4 dCB0byB1c2VsZXNzLsKgwqBGb3IgZXhhbXBsZSwKPiAKPiBQVlBBTklDIC0gaXMgdGhpcyBzb21l dGhpbmcgdGhhdCBzaG91bGQgYmUgZW5hYmxlZCBmb3IgYSBob3N0IG9yCj4gZ3Vlc3Qga2VybmVs P8KgwqBBbnN3ZXI6IHlvdSBoYXZlIHRvIHJlYWQgdGhlIGRyaXZlciBjb2RlIHRvIGZpbmQgb3V0 Lgo+IAo+IElNWF9JUlFTVEVFUiAtIHdoaWNoIGkuTVggU29DcyBkb2VzIHRoaXMgYXBwbHkgdG8/ wqDCoFRoZSBoZWxwIHRleHQKPiBqdXN0IHNheXM6Cj4gCj4gwqAgIlN1cHBvcnQgZm9yIHRoZSBp Lk1YIElSUVNURUVSIGludGVycnVwdCBtdWx0aXBsZXhlci9yZW1hcHBlci4iCj4gCj4gd2hpY2gg ZG9lc24ndCBzYXkgd2hpY2ggU29DcyB0aGlzIHNob3VsZCBiZSBlbmFibGVkIGZvciAtIGl0IHR1 cm5zCj4gb3V0IHRoYXQgZ3JlcHBpbmcgZm9yIHRoZSBkcml2ZXIncyBEVCBjb21wYXRpYmxlIHN0 cmluZywgbm9uZSBvZgo+IHRoZSAzMi1iaXQgQVJNIGNvcmVzIGhhdmUgc3VwcG9ydCBmb3IgdGhp cywgeWV0IHdlIHN0aWxsIGRlZmF1bHQKPiBpdCB0byBlbmFibGVkIHRoZXJlLsKgwqBJdCBzZWVt cyB0aGUgaGVscCB0ZXh0IHNob3VsZCBhdCB0aGUgdmVyeQo+IGxlYXN0IHRlbGwgdGhlIHVzZXIg dGhhdCB0aGlzIGlzIG5vdCBhcHBsaWNhYmxlIHRvIGkuTVggU29DcyB3aXRoCj4gMzItYml0IEFS TSBjb3Jlcy4KPiAKPiBJJ20gc3VyZSB0aGVyZSdzIG1hbnkgb3RoZXIgaW5zdGFuY2VzIG9mIHRo aXMuLi4gSSBzdXNwZWN0IHRoYXQKPiBpdCdzIGNhdXNlZCBieSByZXZpZXcgY29uY2VudHJhdGlu ZyBtb3N0bHkgb24gdGhlIHRlY2huaWNhbCBhc3BlY3RzCj4gb2YgdGhlIGNvZGUgYW5kIHRoZSBL Y29uZmlnIGhlbHAgdGV4dCBqdXN0IGdldHMgZm9yZ290dGVuIGFib3V0Lgo+IAo+IENhbiB3ZSBh dCBsZWFzdCBpbXByb3ZlIHRoZXNlIHR3byBvcHRpb25zIHBsZWFzZT8KCldoaWxlIEkgdG90YWxs eSBhZ3JlZSB0aGF0IHRoZSBpcnFzdGVlciBkcml2ZXIgc2hvdWxkIG9ubHkgZGVmYXVsdCBZIG9u CjY0Yml0IGkuTVggU29DcywgSSdtIG5vdCByZWFsbHkgc3VyZSB3aGF0IHRvIGRvIGFib3V0IHRo ZSBLY29uZmlnIGhlbHAKdGV4dC4KCkVudW1lcmF0aW5nIFNvQ3MgaW4gdGhlIEtjb25maWcgb2Yg YSBJUCBibG9jayBkcml2ZXIgaXMgYWx3YXlzIHByb25lIHRvCmdldCBvdXRkYXRlZC4gSnVzdCBh cyB0aGUgZmlyc3QgZXhhbXBsZSBJJ3ZlIGJlZW4gYWJsZSB0byBjb21lIHVwIHdpdGgsCnRoZSBN TUNfU0RIQ0lfRVNESENfSU1YIGhlbHAgdGV4dCBzYXlzOiAiVGhpcyBzZWxlY3RzIHRoZSBGcmVl c2NhbGUKZVNESEMvdVNESEMgY29udHJvbGxlciBzdXBwb3J0wqBmb3VuZCBvbiBpLk1YMjUsIGku TVgzNSBpLk1YNXggYW5kCmkuTVg2eC4iLCB3aGlsZSB0aGUgc2FtZSBJUCBibG9jayBpcyB0byBi ZSBmb3VuZCBvbiBpLk1YNyBhbmQgdmFyaW91cwppLk1YOC4KCkZvciB0aGUgS2NvbmZpZyB1c2Vy LCB3aG8gbmVlZHMgdG8gZGVjaWRlIGlmIGFuIG9wdGlvbiBpcyByZWxldmFudCwKb3V0ZGF0ZWQg U29DIGluZm9ybWF0aW9uIGlzIHByb2JhYmx5IGp1c3QgYXMgYmFkIGFzIG5vIGluZm9ybWF0aW9u IGF0CmFsbC4KClJlZ2FyZHMsCkx1Y2FzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE5B1C43381 for ; Wed, 6 Mar 2019 09:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84A71206DD for ; Wed, 6 Mar 2019 09:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbfCFJqB (ORCPT ); Wed, 6 Mar 2019 04:46:01 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:36153 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729695AbfCFJqB (ORCPT ); Wed, 6 Mar 2019 04:46:01 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h1T7b-0006X3-3u; Wed, 06 Mar 2019 10:45:55 +0100 Message-ID: <1551865552.9298.24.camel@pengutronix.de> Subject: Re: Smarter Kconfig help From: Lucas Stach To: Russell King - ARM Linux admin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Peng Hao , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman Date: Wed, 06 Mar 2019 10:45:52 +0100 In-Reply-To: <20190305173111.t3n6ycktht7kxuhq@shell.armlinux.org.uk> References: <20190305173111.t3n6ycktht7kxuhq@shell.armlinux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, Am Dienstag, den 05.03.2019, 17:31 +0000 schrieb Russell King - ARM Linux admin: > Guys, > > We need to be smarter when writing Kconfig help.  I'm just going > through updating my build trees with the results of 5.0 development, > and a number of the help texts are next to useless.  For example, > > PVPANIC - is this something that should be enabled for a host or > guest kernel?  Answer: you have to read the driver code to find out. > > IMX_IRQSTEER - which i.MX SoCs does this apply to?  The help text > just says: > >   "Support for the i.MX IRQSTEER interrupt multiplexer/remapper." > > which doesn't say which SoCs this should be enabled for - it turns > out that grepping for the driver's DT compatible string, none of > the 32-bit ARM cores have support for this, yet we still default > it to enabled there.  It seems the help text should at the very > least tell the user that this is not applicable to i.MX SoCs with > 32-bit ARM cores. > > I'm sure there's many other instances of this... I suspect that > it's caused by review concentrating mostly on the technical aspects > of the code and the Kconfig help text just gets forgotten about. > > Can we at least improve these two options please? While I totally agree that the irqsteer driver should only default Y on 64bit i.MX SoCs, I'm not really sure what to do about the Kconfig help text. Enumerating SoCs in the Kconfig of a IP block driver is always prone to get outdated. Just as the first example I've been able to come up with, the MMC_SDHCI_ESDHC_IMX help text says: "This selects the Freescale eSDHC/uSDHC controller support found on i.MX25, i.MX35 i.MX5x and i.MX6x.", while the same IP block is to be found on i.MX7 and various i.MX8. For the Kconfig user, who needs to decide if an option is relevant, outdated SoC information is probably just as bad as no information at all. Regards, Lucas