From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port Date: Fri, 08 Mar 2019 17:52:08 +0100 Message-ID: <1552063928.29776.2.camel@suse.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kento.A.Kobayashi@sony.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu Cc: usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Fr, 2019-03-08 at 09:13 +0000, Kento.A.Kobayashi@sony.com wrote: > The usb_reset_and_verify_device included in usb_reset_device fails > with -ENODEV after power off hub port, and the -ENODEV error will > be reported to uas_eh_bus_reset_handler and upper layer, so it > doesn't need to do rebind if -ENODEV happens. Hi, no I am sorry, that is an assumption you just cannot make. Anything can trigger a reset. That being SCSI is the common case certainly, but not the only case. And in those cases we cannot depend on upper layers doing the right thing, if we just ignore an error. NACK Sorry Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: uas: fix usb subsystem hang after power off hub port From: Oliver Neukum Message-Id: <1552063928.29776.2.camel@suse.com> Date: Fri, 08 Mar 2019 17:52:08 +0100 To: Kento.A.Kobayashi@sony.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu Cc: usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gRnIsIDIwMTktMDMtMDggYXQgMDk6MTMgKzAwMDAsIEtlbnRvLkEuS29iYXlhc2hpQHNvbnku Y29tIHdyb3RlOgo+IFRoZSB1c2JfcmVzZXRfYW5kX3ZlcmlmeV9kZXZpY2UgaW5jbHVkZWQgaW4g dXNiX3Jlc2V0X2RldmljZSBmYWlscwo+IHdpdGggLUVOT0RFViBhZnRlciBwb3dlciBvZmYgaHVi IHBvcnQsIGFuZCB0aGUgLUVOT0RFViBlcnJvciB3aWxsCj4gYmUgcmVwb3J0ZWQgdG8gdWFzX2Vo X2J1c19yZXNldF9oYW5kbGVyIGFuZCB1cHBlciBsYXllciwgc28gaXQKPiBkb2Vzbid0IG5lZWQg dG8gZG8gcmViaW5kIGlmIC1FTk9ERVYgaGFwcGVucy4KCkhpLAoKbm8gSSBhbSBzb3JyeSwgdGhh dCBpcyBhbiBhc3N1bXB0aW9uIHlvdSBqdXN0IGNhbm5vdCBtYWtlLgpBbnl0aGluZyBjYW4gdHJp Z2dlciBhIHJlc2V0LiBUaGF0IGJlaW5nIFNDU0kgaXMgdGhlIGNvbW1vbgpjYXNlIGNlcnRhaW5s eSwgYnV0IG5vdCB0aGUgb25seSBjYXNlLiBBbmQgaW4gdGhvc2UgY2FzZXMKd2UgY2Fubm90IGRl cGVuZCBvbiB1cHBlciBsYXllcnMgZG9pbmcgdGhlIHJpZ2h0IHRoaW5nLCBpZgp3ZSBqdXN0IGln bm9yZSBhbiBlcnJvci4KCk5BQ0sKCglTb3JyeQoJCU9saXZlcgo=