From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2KSu-0004k2-38 for kexec@lists.infradead.org; Fri, 08 Mar 2019 18:43:30 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x28Icm8B091006 for ; Fri, 8 Mar 2019 13:43:26 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2r3w4hhynv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Mar 2019 13:43:25 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Mar 2019 18:43:24 -0000 Subject: Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode From: Mimi Zohar Date: Fri, 08 Mar 2019 13:43:18 -0500 In-Reply-To: References: <1542657371-7019-1-git-send-email-zohar@linux.ibm.com> <1542657371-7019-4-git-send-email-zohar@linux.ibm.com> <1551998897.31706.461.camel@linux.ibm.com> <1552052377.4134.23.camel@linux.ibm.com> Mime-Version: 1.0 Message-Id: <1552070598.4134.51.camel@linux.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Matthew Garrett Cc: linux-efi , Nayna Jain , kexec@lists.infradead.org, Linux Kernel Mailing List , David Howells , Seth Forshee , LSM List , Justin Forbes , linux-integrity T24gRnJpLCAyMDE5LTAzLTA4IGF0IDA5OjUxIC0wODAwLCBNYXR0aGV3IEdhcnJldHQgd3JvdGU6 Cj4gT24gRnJpLCBNYXIgOCwgMjAxOSBhdCA1OjQwIEFNIE1pbWkgWm9oYXIgPHpvaGFyQGxpbnV4 LmlibS5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgMjAxOS0wMy0wNyBhdCAxNDo1MCAtMDgw MCwgTWF0dGhldyBHYXJyZXR0IHdyb3RlOgo+ID4gPiBJcyB0aGUgaXNzdWUgdGhhdCBpdCBnaXZl cyBpbmNvcnJlY3QgcmVzdWx0cyBvbiB0aGUgZmlyc3QgcmVhZCwgb3IgaXMKPiA+ID4gdGhlIGlz c3VlIHRoYXQgaXQgZ2l2ZXMgaW5jb3JyZWN0IHJlc3VsdHMgYmVmb3JlIEV4aXRCb290U2Vydmlj ZXMoKSBpcwo+ID4gPiBjYWxsZWQ/IElmIHRoZSBmb3JtZXIgdGhlbiB3ZSBzaG91bGQgcmVhZCB0 d2ljZSBpbiB0aGUgYm9vdCBzdHViLCBpZgo+ID4gPiB0aGUgbGF0dGVyIHRoZW4gd2Ugc2hvdWxk IGZpZ3VyZSBvdXQgYSB3YXkgdG8gZG8gdGhpcyBpbW1lZGlhdGVseQo+ID4gPiBhZnRlciBFeGl0 Qm9vdFNlcnZpY2VzKCkgaW5zdGVhZC4KPiA+Cj4gPiBEZXRlY3RpbmcgdGhlIHNlY3VyZSBib290 IG1vZGUgaXNuJ3QgdGhlIHByb2JsZW0uICBPbiBib290LCBJIGFtCj4gPiBzZWVpbmcgIkVGSSBz dHViOiBVRUZJIFNlY3VyZSBCb290IGlzIGVuYWJsZWQiLCBidXQgc2V0dXBfYXJjaCgpIGVtaXRz Cj4gPiAiU2VjdXJlIGJvb3QgY291bGQgbm90IGJlIGRldGVybWluZWQiLgo+ID4KPiA+IEluIGVm aV9tYWluKCkgdGhlIHNlY3VyZV9ib290IG1vZGUgaXMgaW5pdGlhbGx5IHVuc2V0LCBzbwo+ID4g ZWZpX2dldF9zZWN1cmVib290KCkgaXMgY2FsbGVkLiAgZWZpX2dldF9zZWN1cmVib290KCkgcmV0 dXJucyB0aGUKPiA+IHNlY3VyZV9ib290IG1vZGUgY29ycmVjdGx5IGFzIGVuYWJsZWQuICBUaGUg cHJvYmxlbSBzZWVtcyB0byBiZSBpbgo+ID4gc2F2aW5nIHRoZSBzZWN1cmVfYm9vdCBtb2RlIGZv ciBsYXRlciB1c2UuCj4gCj4gSG0uIEFuZCB0aGlzIG9ubHkgaGFwcGVucyBvbiBjZXJ0YWluIGZp cm13YXJlIHZlcnNpb25zPyBJZiBzb21ldGhpbmcncwo+IHN0ZXBwaW5nIG9uIGJvb3RfcGFyYW1z IHRoZW4gd2UgaGF2ZSBiaWdnZXIgcHJvYmxlbXMuCgpGWUksIGVmaV9wcmludGsoKSB3b3JrcyBi ZWZvcmUgZXhpdF9ib290KCksIGJ1dCBub3QgYWZ0ZXJ3YXJkcy4gwqBUaGUKc3lzdGVtIGhhbmdz LgoKTWltaQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode Date: Fri, 08 Mar 2019 13:43:18 -0500 Message-ID: <1552070598.4134.51.camel@linux.ibm.com> References: <1542657371-7019-1-git-send-email-zohar@linux.ibm.com> <1542657371-7019-4-git-send-email-zohar@linux.ibm.com> <1551998897.31706.461.camel@linux.ibm.com> <1552052377.4134.23.camel@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett Cc: Justin Forbes , linux-integrity , LSM List , linux-efi , Linux Kernel Mailing List , David Howells , Seth Forshee , kexec@lists.infradead.org, Nayna Jain List-Id: linux-efi@vger.kernel.org On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > On Fri, Mar 8, 2019 at 5:40 AM Mimi Zohar wrote: > > > > On Thu, 2019-03-07 at 14:50 -0800, Matthew Garrett wrote: > > > Is the issue that it gives incorrect results on the first read, or is > > > the issue that it gives incorrect results before ExitBootServices() is > > > called? If the former then we should read twice in the boot stub, if > > > the latter then we should figure out a way to do this immediately > > > after ExitBootServices() instead. > > > > Detecting the secure boot mode isn't the problem. On boot, I am > > seeing "EFI stub: UEFI Secure Boot is enabled", but setup_arch() emits > > "Secure boot could not be determined". > > > > In efi_main() the secure_boot mode is initially unset, so > > efi_get_secureboot() is called. efi_get_secureboot() returns the > > secure_boot mode correctly as enabled. The problem seems to be in > > saving the secure_boot mode for later use. > > Hm. And this only happens on certain firmware versions? If something's > stepping on boot_params then we have bigger problems. FYI, efi_printk() works before exit_boot(), but not afterwards.  The system hangs. Mimi