From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FE3C43381 for ; Mon, 11 Mar 2019 22:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EB5920657 for ; Mon, 11 Mar 2019 22:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552342649; bh=srP2aOAuTxd/i9qoJIWasL0lWvQQKGw6yq4BrZ51YWY=; h=Subject:To:Cc:From:Date:List-ID:From; b=xVP4nPUbdXcXh4E9tVF9XQ+EypmHcB57z5EiASvk35mbXUPJdnpnzSCO8C2NDBELW XeKmIEPQ9Ce9wvwN5OviNjxw4iwy/r5CNbyb5KY4b4STTxvqK2KFIK4Gj/TcTNJR/9 32w8d4dRfIun+wa1Uev/jpned4cZsq/zBqjDP7FM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfCKWR2 (ORCPT ); Mon, 11 Mar 2019 18:17:28 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58521 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfCKWR2 (ORCPT ); Mon, 11 Mar 2019 18:17:28 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 52B27225B9; Mon, 11 Mar 2019 18:17:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 11 Mar 2019 18:17:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/uilMY u/4yx8z3v4deHWO1Q7Af+htp23Vn/+EEudyOY=; b=PGaSq2jqLPxp19cRx2NS2g JqjeZr51lVKfvE1rb3XK2NySjExOJukUKg9ZoF7Xo+BdHGbJ0nq77zWtESvMRjkd LIZJDGy4IkhVreTQzRoIWpRJlN03WUcmqTgJpTtqMKgw8B4JkQFGvVbGAiBZZUYF TsLGRJRFjflZCLq+8ytCp2o3fWGCeHJAMDOUUBcXRp0bSeHJ8SRh/XBRpjA2lLqu mGcGqTg+y4lx2i42vncr8PLXiVd/skbag+0kwwKPy2akOb9xqHR/oyUs/4h8SBuc dlE4+CLXoHyHQePMB4JBWd3b8sKtRd8T3A14VCHhvs1/+bzD2uH76qv56+Ol/ZLA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrgeeigdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppedutdegrddufeefrdekrdelkeenucfrrghrrghmpehmrghilhhfrhhomh epghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [104.133.8.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 459C0E4752; Mon, 11 Mar 2019 18:17:26 -0400 (EDT) Subject: FAILED: patch "[PATCH] ARM: dts: exynos: Fix pinctrl definition for eMMC RTSN line" failed to apply to 4.4-stable tree To: m.szyprowski@samsung.com, krzk@kernel.org, m.reichl@fivetechno.de, stable@vger.kernel.org, ulf.hansson@linaro.org Cc: From: Date: Mon, 11 Mar 2019 15:17:22 -0700 Message-ID: <15523426426319@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From ec33745bccc8f336957c751f4153421cc9ef5a54 Mon Sep 17 00:00:00 2001 From: Marek Szyprowski Date: Thu, 24 Jan 2019 13:22:57 +0100 Subject: [PATCH] ARM: dts: exynos: Fix pinctrl definition for eMMC RTSN line on Odroid X2/U3 Commit 225da7e65a03 ("ARM: dts: add eMMC reset line for exynos4412-odroid-common") added MMC power sequence for eMMC card of Odroid X2/U3. It reused generic sd1_cd pin control configuration node and only disabled pull-up. However that time the pinctrl configuration was not applied during MMC power sequence driver initialization. This has been changed later by commit d97a1e5d7cd2 ("mmc: pwrseq: convert to proper platform device"). It turned out then, that the provided pinctrl configuration is not correct, because the eMMC_RTSN line is being re-configured as 'special function/card detect function for mmc1 controller' not the simple 'output', thus the power sequence driver doesn't really set the pin value. This in effect broke the reboot of Odroid X2/U3 boards. Fix this by providing separate node with eMMC_RTSN pin configuration. Cc: Reported-by: Markus Reichl Suggested-by: Ulf Hansson Fixes: 225da7e65a03 ("ARM: dts: add eMMC reset line for exynos4412-odroid-common") Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 24bcad3dfba9..08d3a0a7b4eb 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -49,7 +49,7 @@ }; emmc_pwrseq: pwrseq { - pinctrl-0 = <&sd1_cd>; + pinctrl-0 = <&emmc_rstn>; pinctrl-names = "default"; compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>; @@ -165,12 +165,6 @@ cpu0-supply = <&buck2_reg>; }; -/* RSTN signal for eMMC */ -&sd1_cd { - samsung,pin-pud = ; - samsung,pin-drv = ; -}; - &pinctrl_1 { gpio_power_key: power_key { samsung,pins = "gpx1-3"; @@ -188,6 +182,11 @@ samsung,pins = "gpx3-7"; samsung,pin-pud = ; }; + + emmc_rstn: emmc-rstn { + samsung,pins = "gpk1-2"; + samsung,pin-pud = ; + }; }; &ehci {