From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org,
bigeasy@linutronix.de, joel@joelfernandes.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [RFC PATCH v3 3/5] tracing: Use tracing error_log with hist triggers
Date: Tue, 12 Mar 2019 11:50:55 -0500 [thread overview]
Message-ID: <1552409455.4293.24.camel@kernel.org> (raw)
In-Reply-To: <20190313004631.d8feedaaa0ac701f2322ca38@kernel.org>
Hi Masami,
On Wed, 2019-03-13 at 00:46 +0900, Masami Hiramatsu wrote:
> On Mon, 4 Mar 2019 17:36:46 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > From: Tom Zanussi <tom.zanussi@linux.intel.com>
> >
> > Replace hist_err() and hist_err_event() with tracing_log_err() from
> > the new tracing error_log mechanism.
> >
> > Also add a couple related helper functions and remove most of the
> > old
> > hist_err()-related code.
> >
> > With this change, users no longer read the hist files for hist
> > trigger
> > error information, but instead look at tracing/error_log for the
> > same
> > information.
>
> Could you also add a patch which update its testcase?
>
> test.d/trigger/inter-event/trigger-extended-error-support.tc
>
> will fail after this patch.
>
Yeah, good point, will do (and documentation too).
Thanks,
Tom
next prev parent reply other threads:[~2019-03-12 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 23:36 [RFC PATCH v3 0/5] tracing: common error_log for ftrace Tom Zanussi
2019-03-04 23:36 ` [RFC PATCH v3 1/5] tracing: Add tracing error log Tom Zanussi
2019-03-04 23:36 ` [RFC PATCH v3 2/5] tracing: Save the last hist command's associated event name Tom Zanussi
2019-03-04 23:36 ` [RFC PATCH v3 3/5] tracing: Use tracing error_log with hist triggers Tom Zanussi
2019-03-12 15:46 ` Masami Hiramatsu
2019-03-12 16:50 ` Tom Zanussi [this message]
2019-03-04 23:36 ` [RFC PATCH v3 4/5] tracing: Use tracing error_log with kprobe events (incomplete) Tom Zanussi
2019-03-04 23:36 ` [RFC PATCH v3 5/5] tracing: Use tracing error_log with trace event filters Tom Zanussi
2019-03-05 14:06 ` [RFC PATCH v3 0/5] tracing: common error_log for ftrace Masami Hiramatsu
2019-03-12 6:26 ` Masami Hiramatsu
2019-03-12 16:49 ` Tom Zanussi
2019-03-13 13:03 ` Masami Hiramatsu
2019-03-13 14:09 ` Tom Zanussi
2019-03-05 21:58 ` Steven Rostedt
2019-03-05 22:05 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552409455.4293.24.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.