From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10EB7C43381 for ; Wed, 13 Mar 2019 11:03:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5C032184E for ; Wed, 13 Mar 2019 11:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="myIAZRj2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Ry4LB9xg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C032184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QF+ykhoCUDh4sFWqeZy0E/bN+nLAIB9Gc1L5oo4uiyU=; b=myIAZRj2QeWQoZ fsMxx26izJIbVy8XS3grNzcjKlJcNJ90fqpk111h+WJ4Ksu/g2AfL2B26EUGh2BFbv+1fwivgT3uu FzTcXxfxsnG5wWl016UDx3lC6NqyesYFfYS9cAet5kpK2b9u/3rnqwm7vGwZElHrTfPFeOnJPwxm/ +Pme3dmmiv5A+IYadxDod+J9PutV35KoExiiAlfJC6WnodG0bOrBMEgnfrYMuvzDKwvYCfhYTPU/Y JtRur2MsJwLahfEMwSZpSBvSlN23GY1/4T1vZ9QPNRGvnpa9VdJ07dpuWdU2mBIRdSi7JwkVd8O/T fNEfJRJrvwDrqfiTIhwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41f0-00023J-U7; Wed, 13 Mar 2019 11:02:58 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41ev-0001w3-DY for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2019 11:02:55 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 13 Mar 2019 04:02:40 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 13 Mar 2019 04:02:52 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 13 Mar 2019 04:02:52 -0700 Received: from HQMAIL102.nvidia.com (172.18.146.10) by HQMAIL103.nvidia.com (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 Mar 2019 11:02:51 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL102.nvidia.com (172.18.146.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 13 Mar 2019 11:02:51 +0000 Received: from linux.nvidia.com (Not Verified[10.24.34.185]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Wed, 13 Mar 2019 04:02:51 -0700 From: Sameer Pujar To: , , , , , , , , , , , , , , , , , , Subject: [PATCH 2/5] irqchip/gic: allow gic-pm driver to be used as module Date: Wed, 13 Mar 2019 16:32:33 +0530 Message-ID: <1552474956-25513-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552474956-25513-1-git-send-email-spujar@nvidia.com> References: <1552474956-25513-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1552474960; bh=3g7lYYBEFS+Yhcv9M0fGLejT2kT7qJA+aJ6YK4BdXZ4=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Type; b=Ry4LB9xgHf+u4jOzFMZusRtXnDUjsCHne8HmLEHf7WQZ7lc7gSz5vTpH0d3IRRtm5 vhn44Ldi8eTLTwbBzAafmxZh3L23o+Xoyyd7rKSucnwj/dyZcWTWI4qD4bLf3PO3AK abuRpizLM+Znm6R40612Oe0cxK1iX2vuGhjaZzEEttiCqjZtaaq0sgvpvygYg0dlb4 7SBNGAzq3j5vhH02mhI0cjfvz8f3ImFjoDNfdJLniWOS75zv4wa6hWuqxQ94+Zvm1Z Gi3Z5AyrNUaFz6HDf7JhxsMqNk4j3/QSlgfL+xgcSnv9wBj+dQ1j5fDK8qQFlqjHn0 lCAmm+7X7eZew== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_040253_692235_7DA39894 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sameer Pujar , treding@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org In order to use irq-gic-pm driver as module following changes are made. 1. config ARM_GIC_PM is changed to tristate to allow it to be built as module. 2. following functions are exported from irq-gic driver. * gic_of_init_child() * gic_cpu_save() * gic_dist_save() * gic_cpu_restore() * gic_dist_restore() 3. MODULE_LICENSE is added to make sure driver load is successful, else it fails to resolve required symbols. The 'builtin_platform_driver' is replaced with 'module_platform_driver' to allow driver removal, else it complains that device or resource is busy. Signed-off-by: Sameer Pujar --- drivers/irqchip/Kconfig | 2 +- drivers/irqchip/irq-gic-pm.c | 3 ++- drivers/irqchip/irq-gic.c | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 5438abb..8b5ce12 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -12,7 +12,7 @@ config ARM_GIC select GENERIC_IRQ_EFFECTIVE_AFF_MASK config ARM_GIC_PM - bool + tristate "ARM GIC with PM support" depends on PM select ARM_GIC select PM_CLK diff --git a/drivers/irqchip/irq-gic-pm.c b/drivers/irqchip/irq-gic-pm.c index 56a785f..cde9714 100644 --- a/drivers/irqchip/irq-gic-pm.c +++ b/drivers/irqchip/irq-gic-pm.c @@ -195,4 +195,5 @@ static struct platform_driver gic_driver = { } }; -builtin_platform_driver(gic_driver); +module_platform_driver(gic_driver); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index f88018b..b3ad7ed 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -600,6 +600,7 @@ void gic_dist_save(struct gic_chip_data *gic) gic->saved_spi_active[i] = readl_relaxed(dist_base + GIC_DIST_ACTIVE_SET + i * 4); } +EXPORT_SYMBOL_GPL(gic_dist_save); /* * Restores the GIC distributor registers during resume or when coming out of @@ -653,6 +654,7 @@ void gic_dist_restore(struct gic_chip_data *gic) writel_relaxed(GICD_ENABLE, dist_base + GIC_DIST_CTRL); } +EXPORT_SYMBOL_GPL(gic_dist_restore); void gic_cpu_save(struct gic_chip_data *gic) { @@ -683,6 +685,7 @@ void gic_cpu_save(struct gic_chip_data *gic) ptr[i] = readl_relaxed(dist_base + GIC_DIST_CONFIG + i * 4); } +EXPORT_SYMBOL_GPL(gic_cpu_save); void gic_cpu_restore(struct gic_chip_data *gic) { @@ -725,6 +728,7 @@ void gic_cpu_restore(struct gic_chip_data *gic) writel_relaxed(GICC_INT_PRI_THRESHOLD, cpu_base + GIC_CPU_PRIMASK); gic_cpu_if_up(gic); } +EXPORT_SYMBOL_GPL(gic_cpu_restore); static int gic_notifier(struct notifier_block *self, unsigned long cmd, void *v) { @@ -1410,6 +1414,7 @@ int gic_of_init_child(struct device *dev, struct gic_chip_data **gic, int irq) return 0; } +EXPORT_SYMBOL_GPL(gic_of_init_child); static void __init gic_of_setup_kvm_info(struct device_node *node) { @@ -1496,6 +1501,7 @@ int gic_of_init_child(struct device *dev, struct gic_chip_data **gic, int irq) { return -ENOTSUPP; } +EXPORT_SYMBOL_GPL(gic_of_init_child); #endif #ifdef CONFIG_ACPI -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B633C4360F for ; Wed, 13 Mar 2019 11:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 245D72070D for ; Wed, 13 Mar 2019 11:02:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Ry4LB9xg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbfCMLCz (ORCPT ); Wed, 13 Mar 2019 07:02:55 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:19077 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfCMLCx (ORCPT ); Wed, 13 Mar 2019 07:02:53 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 13 Mar 2019 04:02:40 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 13 Mar 2019 04:02:52 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 13 Mar 2019 04:02:52 -0700 Received: from HQMAIL102.nvidia.com (172.18.146.10) by HQMAIL103.nvidia.com (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 Mar 2019 11:02:51 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL102.nvidia.com (172.18.146.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 13 Mar 2019 11:02:51 +0000 Received: from linux.nvidia.com (Not Verified[10.24.34.185]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Wed, 13 Mar 2019 04:02:51 -0700 From: Sameer Pujar To: , , , , , , , , , , , , , , , , , , CC: , , , , Sameer Pujar Subject: [PATCH 2/5] irqchip/gic: allow gic-pm driver to be used as module Date: Wed, 13 Mar 2019 16:32:33 +0530 Message-ID: <1552474956-25513-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552474956-25513-1-git-send-email-spujar@nvidia.com> References: <1552474956-25513-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1552474960; bh=3g7lYYBEFS+Yhcv9M0fGLejT2kT7qJA+aJ6YK4BdXZ4=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Type; b=Ry4LB9xgHf+u4jOzFMZusRtXnDUjsCHne8HmLEHf7WQZ7lc7gSz5vTpH0d3IRRtm5 vhn44Ldi8eTLTwbBzAafmxZh3L23o+Xoyyd7rKSucnwj/dyZcWTWI4qD4bLf3PO3AK abuRpizLM+Znm6R40612Oe0cxK1iX2vuGhjaZzEEttiCqjZtaaq0sgvpvygYg0dlb4 7SBNGAzq3j5vhH02mhI0cjfvz8f3ImFjoDNfdJLniWOS75zv4wa6hWuqxQ94+Zvm1Z Gi3Z5AyrNUaFz6HDf7JhxsMqNk4j3/QSlgfL+xgcSnv9wBj+dQ1j5fDK8qQFlqjHn0 lCAmm+7X7eZew== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to use irq-gic-pm driver as module following changes are made. 1. config ARM_GIC_PM is changed to tristate to allow it to be built as module. 2. following functions are exported from irq-gic driver. * gic_of_init_child() * gic_cpu_save() * gic_dist_save() * gic_cpu_restore() * gic_dist_restore() 3. MODULE_LICENSE is added to make sure driver load is successful, else it fails to resolve required symbols. The 'builtin_platform_driver' is replaced with 'module_platform_driver' to allow driver removal, else it complains that device or resource is busy. Signed-off-by: Sameer Pujar --- drivers/irqchip/Kconfig | 2 +- drivers/irqchip/irq-gic-pm.c | 3 ++- drivers/irqchip/irq-gic.c | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 5438abb..8b5ce12 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -12,7 +12,7 @@ config ARM_GIC select GENERIC_IRQ_EFFECTIVE_AFF_MASK config ARM_GIC_PM - bool + tristate "ARM GIC with PM support" depends on PM select ARM_GIC select PM_CLK diff --git a/drivers/irqchip/irq-gic-pm.c b/drivers/irqchip/irq-gic-pm.c index 56a785f..cde9714 100644 --- a/drivers/irqchip/irq-gic-pm.c +++ b/drivers/irqchip/irq-gic-pm.c @@ -195,4 +195,5 @@ static struct platform_driver gic_driver = { } }; -builtin_platform_driver(gic_driver); +module_platform_driver(gic_driver); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index f88018b..b3ad7ed 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -600,6 +600,7 @@ void gic_dist_save(struct gic_chip_data *gic) gic->saved_spi_active[i] = readl_relaxed(dist_base + GIC_DIST_ACTIVE_SET + i * 4); } +EXPORT_SYMBOL_GPL(gic_dist_save); /* * Restores the GIC distributor registers during resume or when coming out of @@ -653,6 +654,7 @@ void gic_dist_restore(struct gic_chip_data *gic) writel_relaxed(GICD_ENABLE, dist_base + GIC_DIST_CTRL); } +EXPORT_SYMBOL_GPL(gic_dist_restore); void gic_cpu_save(struct gic_chip_data *gic) { @@ -683,6 +685,7 @@ void gic_cpu_save(struct gic_chip_data *gic) ptr[i] = readl_relaxed(dist_base + GIC_DIST_CONFIG + i * 4); } +EXPORT_SYMBOL_GPL(gic_cpu_save); void gic_cpu_restore(struct gic_chip_data *gic) { @@ -725,6 +728,7 @@ void gic_cpu_restore(struct gic_chip_data *gic) writel_relaxed(GICC_INT_PRI_THRESHOLD, cpu_base + GIC_CPU_PRIMASK); gic_cpu_if_up(gic); } +EXPORT_SYMBOL_GPL(gic_cpu_restore); static int gic_notifier(struct notifier_block *self, unsigned long cmd, void *v) { @@ -1410,6 +1414,7 @@ int gic_of_init_child(struct device *dev, struct gic_chip_data **gic, int irq) return 0; } +EXPORT_SYMBOL_GPL(gic_of_init_child); static void __init gic_of_setup_kvm_info(struct device_node *node) { @@ -1496,6 +1501,7 @@ int gic_of_init_child(struct device *dev, struct gic_chip_data **gic, int irq) { return -ENOTSUPP; } +EXPORT_SYMBOL_GPL(gic_of_init_child); #endif #ifdef CONFIG_ACPI -- 2.7.4