From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO Date: Fri, 15 Mar 2019 15:52:54 +0800 Message-ID: <1552636374.10179.121.camel@mhfsdcap03> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Hi Rob, There are two ways that I think out to support type-B GPIO based dual role switch. The first one, as the series used: &mtu3 { status = "okay"; connector@0 { compatible = "usb-b-connector", "linux,typeb-switch-gpio"; label = "micro-USB"; type = "micro"; id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; }; but there are some shortcomings: 1. It's not transparent, USB controller driver should be modified, and call of_platform_populate() to create platform device for connector, this is not friendly when the controller driver hasn't child node before, and also not compatible with other cases, such as Type-C 2. It doesn't keep format consistent with the case using Type-C, or using PMIC to detect ID pin. 3. vbus-supply will be got by USB controller driver if it aready supports it another way as following: role_sw_iddig { compatible = "linux,typeb-switch-gpio"; status = "okay"; connector { compatible = "usb-b-connector"; label = "micro-USB"; type = "micro"; id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; port { bsw_ep: endpoint@0 { remote-endpoint = <&usb_role_sw>; }; }; }; &mtu3 { status = "okay"; port { usb_role_sw: endpoint@0 { remote-endpoint = <&bsw_ep>; }; }; }; strength: avoid the shortcomings of the first way shortcoming: it's a virtual device and seems not following graph.txt binding, Do you have any suggestion? Thanks On Fri, 2019-03-15 at 15:38 +0800, Chunfeng Yun wrote: > It's used to support dual role switch via GPIO when use Type-B > receptacle > > Signed-off-by: Chunfeng Yun > --- > v2 changes: > 1. new patch to make binding clear suggested by Hans > --- > .../bindings/usb/typeb-switch-gpio.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > > diff --git a/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > new file mode 100644 > index 000000000000..d46d83bc6500 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > @@ -0,0 +1,26 @@ > +USB Type-B dual role switch via a GPIO > + > +This is a virtual device used to switch dual role mode from the USB ID pin > +connected to a GPIO pin. > + > +Required properties: > +- compatible: Should be "linux,typeb-switch-gpio" > + > +Either one of id-gpios or vbus-gpios must be present, and both can be present > +as well. > +vbus-supply could be present if needed when support dual role mode. > + see connector/usb-connector.txt > + > +Example: > + > +&mtu3 { > + status = "okay"; > + > + connector@0 { > + compatible = "usb-b-connector", "linux,typeb-switch-gpio"; > + label = "micro-USB"; > + type = "micro"; > + id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb_p0_vbus>; > + }; > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO From: Chunfeng Yun Message-Id: <1552636374.10179.121.camel@mhfsdcap03> Date: Fri, 15 Mar 2019 15:52:54 +0800 To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: SGkgUm9iLAoKVGhlcmUgYXJlIHR3byB3YXlzIHRoYXQgSSB0aGluayBvdXQgdG8gc3VwcG9ydCB0 eXBlLUIgR1BJTyBiYXNlZCBkdWFsCnJvbGUgc3dpdGNoLgoKVGhlIGZpcnN0IG9uZSwgYXMgdGhl IHNlcmllcyB1c2VkOgoKJm10dTMgewogICAgc3RhdHVzID0gIm9rYXkiOwoKICAgIGNvbm5lY3Rv ckAwIHsKICAgICAgICBjb21wYXRpYmxlID0gInVzYi1iLWNvbm5lY3RvciIsICJsaW51eCx0eXBl Yi1zd2l0Y2gtZ3BpbyI7CiAgICAgICAgbGFiZWwgPSAibWljcm8tVVNCIjsKICAgICAgICB0eXBl ID0gIm1pY3JvIjsKICAgICAgICBpZC1ncGlvID0gPCZwaW8gMTIgR1BJT19BQ1RJVkVfSElHSD47 CiAgICAgICAgdmJ1cy1zdXBwbHkgPSA8JnVzYl9wMF92YnVzPjsKICAgIH07Cn07CgpidXQgdGhl cmUgYXJlIHNvbWUgc2hvcnRjb21pbmdzOgoxLiBJdCdzIG5vdCB0cmFuc3BhcmVudCwgVVNCIGNv bnRyb2xsZXIgZHJpdmVyIHNob3VsZCBiZSBtb2RpZmllZCwgYW5kCmNhbGwgb2ZfcGxhdGZvcm1f cG9wdWxhdGUoKSB0byBjcmVhdGUgcGxhdGZvcm0gZGV2aWNlIGZvciBjb25uZWN0b3IsCnRoaXMg aXMgbm90IGZyaWVuZGx5IHdoZW4gdGhlIGNvbnRyb2xsZXIgZHJpdmVyIGhhc24ndCBjaGlsZCBu b2RlCmJlZm9yZSwgYW5kIGFsc28gbm90IGNvbXBhdGlibGUgd2l0aCBvdGhlciBjYXNlcywgc3Vj aCBhcyBUeXBlLUMKCjIuIEl0IGRvZXNuJ3Qga2VlcCBmb3JtYXQgY29uc2lzdGVudCB3aXRoIHRo ZSBjYXNlIHVzaW5nIFR5cGUtQywgb3IKdXNpbmcgUE1JQyB0byBkZXRlY3QgSUQgcGluLgoKMy4g dmJ1cy1zdXBwbHkgd2lsbCBiZSBnb3QgYnkgVVNCIGNvbnRyb2xsZXIgZHJpdmVyIGlmIGl0IGFy ZWFkeQpzdXBwb3J0cyBpdAoKCmFub3RoZXIgd2F5IGFzIGZvbGxvd2luZzoKCnJvbGVfc3dfaWRk aWcgewogICAgY29tcGF0aWJsZSA9ICJsaW51eCx0eXBlYi1zd2l0Y2gtZ3BpbyI7CiAgICBzdGF0 dXMgPSAib2theSI7CgogICAgY29ubmVjdG9yIHsKICAgICAgICBjb21wYXRpYmxlID0gInVzYi1i LWNvbm5lY3RvciI7CiAgICAgICAgbGFiZWwgPSAibWljcm8tVVNCIjsKICAgICAgICB0eXBlID0g Im1pY3JvIjsKICAgICAgICBpZC1ncGlvcyA9IDwmcGlvIDEyIEdQSU9fQUNUSVZFX0hJR0g+Owog ICAgICAgIHZidXMtc3VwcGx5ID0gPCZ1c2JfcDBfdmJ1cz47CiAgICB9OwoKICAgIHBvcnQgewog ICAgICAgIGJzd19lcDogZW5kcG9pbnRAMCB7CiAgICAgICAgICAgIHJlbW90ZS1lbmRwb2ludCA9 IDwmdXNiX3JvbGVfc3c+OwogICAgICAgIH07CiAgICB9Owp9OwoKJm10dTMgewogICAgc3RhdHVz ID0gIm9rYXkiOwoKICAgIHBvcnQgewogICAgICAgIHVzYl9yb2xlX3N3OiBlbmRwb2ludEAwIHsK ICAgICAgICAgICAgcmVtb3RlLWVuZHBvaW50ID0gPCZic3dfZXA+OwogICAgICAgIH07CiAgICB9 Owp9OwoKc3RyZW5ndGg6CmF2b2lkIHRoZSBzaG9ydGNvbWluZ3Mgb2YgdGhlIGZpcnN0IHdheQpz aG9ydGNvbWluZzoKaXQncyBhIHZpcnR1YWwgZGV2aWNlIGFuZCBzZWVtcyBub3QgZm9sbG93aW5n IGdyYXBoLnR4dCBiaW5kaW5nLAoKRG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb24/CgpUaGFua3MK CgpPbiBGcmksIDIwMTktMDMtMTUgYXQgMTU6MzggKzA4MDAsIENodW5mZW5nIFl1biB3cm90ZToK PiBJdCdzIHVzZWQgdG8gc3VwcG9ydCBkdWFsIHJvbGUgc3dpdGNoIHZpYSBHUElPIHdoZW4gdXNl IFR5cGUtQgo+IHJlY2VwdGFjbGUKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4gPGNo dW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4gLS0tCj4gdjIgY2hhbmdlczoKPiAgIDEuIG5ldyBw YXRjaCB0byBtYWtlIGJpbmRpbmcgY2xlYXIgc3VnZ2VzdGVkIGJ5IEhhbnMKPiAtLS0KPiAgLi4u L2JpbmRpbmdzL3VzYi90eXBlYi1zd2l0Y2gtZ3Bpby50eHQgICAgICAgIHwgMjYgKysrKysrKysr KysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUg bW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi90eXBlYi1z d2l0Y2gtZ3Bpby50eHQKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3VzYi90eXBlYi1zd2l0Y2gtZ3Bpby50eHQgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvdXNiL3R5cGViLXN3aXRjaC1ncGlvLnR4dAo+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5kNDZkODNiYzY1MDAKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi90eXBlYi1zd2l0 Y2gtZ3Bpby50eHQKPiBAQCAtMCwwICsxLDI2IEBACj4gK1VTQiBUeXBlLUIgZHVhbCByb2xlIHN3 aXRjaCB2aWEgYSBHUElPCj4gKwo+ICtUaGlzIGlzIGEgdmlydHVhbCBkZXZpY2UgdXNlZCB0byBz d2l0Y2ggZHVhbCByb2xlIG1vZGUgZnJvbSB0aGUgVVNCIElEIHBpbgo+ICtjb25uZWN0ZWQgdG8g YSBHUElPIHBpbi4KPiArCj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZTog U2hvdWxkIGJlICJsaW51eCx0eXBlYi1zd2l0Y2gtZ3BpbyIKPiArCj4gK0VpdGhlciBvbmUgb2Yg aWQtZ3Bpb3Mgb3IgdmJ1cy1ncGlvcyBtdXN0IGJlIHByZXNlbnQsIGFuZCBib3RoIGNhbiBiZSBw cmVzZW50Cj4gK2FzIHdlbGwuCj4gK3ZidXMtc3VwcGx5IGNvdWxkIGJlIHByZXNlbnQgaWYgbmVl ZGVkIHdoZW4gc3VwcG9ydCBkdWFsIHJvbGUgbW9kZS4KPiArCXNlZSBjb25uZWN0b3IvdXNiLWNv bm5lY3Rvci50eHQKPiArCj4gK0V4YW1wbGU6Cj4gKwo+ICsmbXR1MyB7Cj4gKwlzdGF0dXMgPSAi b2theSI7Cj4gKwo+ICsJY29ubmVjdG9yQDAgewo+ICsJCWNvbXBhdGlibGUgPSAidXNiLWItY29u bmVjdG9yIiwgImxpbnV4LHR5cGViLXN3aXRjaC1ncGlvIjsKPiArCQlsYWJlbCA9ICJtaWNyby1V U0IiOwo+ICsJCXR5cGUgPSAibWljcm8iOwo+ICsJCWlkLWdwaW8gPSA8JnBpbyAxMiBHUElPX0FD VElWRV9ISUdIPjsKPiArCQl2YnVzLXN1cHBseSA9IDwmdXNiX3AwX3ZidXM+Owo+ICsJfTsKPiAr fTsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F64EC43381 for ; Fri, 15 Mar 2019 07:53:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 012C321872 for ; Fri, 15 Mar 2019 07:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YjLZa0YT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 012C321872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h4ixkbsj542zPar2E3vUj8HtFpirjn9XV3i9BSANwgo=; b=YjLZa0YTEQf4iR 3noOOxUDCd1tXNqnIjrhXYK1Nf5ojvLgjj4kBu99QVrl8+qhhppIP7CMIrtuNAj6qwrdly78793wI LcYp5W8ZXTziQwYvzQnFp3vkmUuVnSrHhQ91XqjJN+6f6eVDkaVzwJ2/F58j5qx91ceKBC61LXX57 bThlUJ6qFksSXNPtx2Ebew+7qH/VCNMEqRkATOJIHQhY4OWWNAjnkVIA8tgq00rhFy1DhAv2fB8Qw J/q5UVVt/Kr7hsLgEi7FukIBsnFRLsGrg7Ix7Ns/lacPN7mKY51rBP/WcrmDNzpMWyimxg6Vr7owI PX4d6MnmCXmjmxuyttRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4heY-0005f7-0J; Fri, 15 Mar 2019 07:53:18 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4heU-0005cp-3C; Fri, 15 Mar 2019 07:53:14 +0000 X-UUID: 7fa72fac2d1d48eca0af7858fc300384-20190314 X-UUID: 7fa72fac2d1d48eca0af7858fc300384-20190314 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1845767305; Thu, 14 Mar 2019 23:53:01 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 00:52:59 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 15:52:55 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 15:52:54 +0800 Message-ID: <1552636374.10179.121.camel@mhfsdcap03> Subject: Re: [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO From: Chunfeng Yun To: Rob Herring Date: Fri, 15 Mar 2019 15:52:54 +0800 In-Reply-To: <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_005314_144196_AC5504F7 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, There are two ways that I think out to support type-B GPIO based dual role switch. The first one, as the series used: &mtu3 { status = "okay"; connector@0 { compatible = "usb-b-connector", "linux,typeb-switch-gpio"; label = "micro-USB"; type = "micro"; id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; }; but there are some shortcomings: 1. It's not transparent, USB controller driver should be modified, and call of_platform_populate() to create platform device for connector, this is not friendly when the controller driver hasn't child node before, and also not compatible with other cases, such as Type-C 2. It doesn't keep format consistent with the case using Type-C, or using PMIC to detect ID pin. 3. vbus-supply will be got by USB controller driver if it aready supports it another way as following: role_sw_iddig { compatible = "linux,typeb-switch-gpio"; status = "okay"; connector { compatible = "usb-b-connector"; label = "micro-USB"; type = "micro"; id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; port { bsw_ep: endpoint@0 { remote-endpoint = <&usb_role_sw>; }; }; }; &mtu3 { status = "okay"; port { usb_role_sw: endpoint@0 { remote-endpoint = <&bsw_ep>; }; }; }; strength: avoid the shortcomings of the first way shortcoming: it's a virtual device and seems not following graph.txt binding, Do you have any suggestion? Thanks On Fri, 2019-03-15 at 15:38 +0800, Chunfeng Yun wrote: > It's used to support dual role switch via GPIO when use Type-B > receptacle > > Signed-off-by: Chunfeng Yun > --- > v2 changes: > 1. new patch to make binding clear suggested by Hans > --- > .../bindings/usb/typeb-switch-gpio.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > > diff --git a/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > new file mode 100644 > index 000000000000..d46d83bc6500 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > @@ -0,0 +1,26 @@ > +USB Type-B dual role switch via a GPIO > + > +This is a virtual device used to switch dual role mode from the USB ID pin > +connected to a GPIO pin. > + > +Required properties: > +- compatible: Should be "linux,typeb-switch-gpio" > + > +Either one of id-gpios or vbus-gpios must be present, and both can be present > +as well. > +vbus-supply could be present if needed when support dual role mode. > + see connector/usb-connector.txt > + > +Example: > + > +&mtu3 { > + status = "okay"; > + > + connector@0 { > + compatible = "usb-b-connector", "linux,typeb-switch-gpio"; > + label = "micro-USB"; > + type = "micro"; > + id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb_p0_vbus>; > + }; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD039C43381 for ; Fri, 15 Mar 2019 07:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A401E21872 for ; Fri, 15 Mar 2019 07:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbfCOHxG (ORCPT ); Fri, 15 Mar 2019 03:53:06 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:26469 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727557AbfCOHxG (ORCPT ); Fri, 15 Mar 2019 03:53:06 -0400 X-UUID: 74200d71c15b4ddb9fc49abef31b0c0a-20190315 X-UUID: 74200d71c15b4ddb9fc49abef31b0c0a-20190315 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1407047240; Fri, 15 Mar 2019 15:52:56 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 15:52:55 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 15:52:54 +0800 Message-ID: <1552636374.10179.121.camel@mhfsdcap03> Subject: Re: [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO From: Chunfeng Yun To: Rob Herring CC: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , , , , , Date: Fri, 15 Mar 2019 15:52:54 +0800 In-Reply-To: <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-3-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, There are two ways that I think out to support type-B GPIO based dual role switch. The first one, as the series used: &mtu3 { status = "okay"; connector@0 { compatible = "usb-b-connector", "linux,typeb-switch-gpio"; label = "micro-USB"; type = "micro"; id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; }; but there are some shortcomings: 1. It's not transparent, USB controller driver should be modified, and call of_platform_populate() to create platform device for connector, this is not friendly when the controller driver hasn't child node before, and also not compatible with other cases, such as Type-C 2. It doesn't keep format consistent with the case using Type-C, or using PMIC to detect ID pin. 3. vbus-supply will be got by USB controller driver if it aready supports it another way as following: role_sw_iddig { compatible = "linux,typeb-switch-gpio"; status = "okay"; connector { compatible = "usb-b-connector"; label = "micro-USB"; type = "micro"; id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; port { bsw_ep: endpoint@0 { remote-endpoint = <&usb_role_sw>; }; }; }; &mtu3 { status = "okay"; port { usb_role_sw: endpoint@0 { remote-endpoint = <&bsw_ep>; }; }; }; strength: avoid the shortcomings of the first way shortcoming: it's a virtual device and seems not following graph.txt binding, Do you have any suggestion? Thanks On Fri, 2019-03-15 at 15:38 +0800, Chunfeng Yun wrote: > It's used to support dual role switch via GPIO when use Type-B > receptacle > > Signed-off-by: Chunfeng Yun > --- > v2 changes: > 1. new patch to make binding clear suggested by Hans > --- > .../bindings/usb/typeb-switch-gpio.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > > diff --git a/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > new file mode 100644 > index 000000000000..d46d83bc6500 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/typeb-switch-gpio.txt > @@ -0,0 +1,26 @@ > +USB Type-B dual role switch via a GPIO > + > +This is a virtual device used to switch dual role mode from the USB ID pin > +connected to a GPIO pin. > + > +Required properties: > +- compatible: Should be "linux,typeb-switch-gpio" > + > +Either one of id-gpios or vbus-gpios must be present, and both can be present > +as well. > +vbus-supply could be present if needed when support dual role mode. > + see connector/usb-connector.txt > + > +Example: > + > +&mtu3 { > + status = "okay"; > + > + connector@0 { > + compatible = "usb-b-connector", "linux,typeb-switch-gpio"; > + label = "micro-USB"; > + type = "micro"; > + id-gpio = <&pio 12 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb_p0_vbus>; > + }; > +};