From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Date: Fri, 15 Mar 2019 17:32:59 +0800 Message-ID: <1552642379.10179.138.camel@mhfsdcap03> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> <20190315092644.GG7752@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190315092644.GG7752@kuha.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Hi, On Fri, 2019-03-15 at 11:26 +0200, Heikki Krogerus wrote: > Hi Chunfeng, > > On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > > `usb_role_switch_register' > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > > `usb_role_switch_unregister' > > So you need to add dependency on USB_ROLE_SWITCH, right? Yes > > --- a/drivers/usb/mtu3/Kconfig > +++ b/drivers/usb/mtu3/Kconfig > @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE > bool "Dual Role mode" > depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) > depends on (EXTCON=y || EXTCON=USB_MTU3) > + depends on USB_ROLE_SWITCH > help > This is the default mode of working of MTU3 controller where > both host and gadget features are enabled. > > > the following patch has fixed the issue, but seems not get into kernel, > > [v3,08/12] usb: roles: Add usb role switch notifier. > > https://patchwork.kernel.org/patch/10836525/ > > I don't understand how that fixes the problem? That patch will in any > case be targeting v5.2. We are in the middle of merge window, so > nothing is happening until v5.1-rc1 is tagged. It provides some dummy inline functions when USB_ROLE_SWITCH is not enabled, this will avoid build error > > > thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun Message-Id: <1552642379.10179.138.camel@mhfsdcap03> Date: Fri, 15 Mar 2019 17:32:59 +0800 To: Heikki Krogerus Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: SGksCk9uIEZyaSwgMjAxOS0wMy0xNSBhdCAxMToyNiArMDIwMCwgSGVpa2tpIEtyb2dlcnVzIHdy b3RlOgo+IEhpIENodW5mZW5nLAo+IAo+IE9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDA1OjEzOjI0 UE0gKzA4MDAsIENodW5mZW5nIFl1biB3cm90ZToKPiA+IEkgZW5jb3VudGVyIGEgYnVpbGQgZXJy b3Igd2hlbiBDT05GSUdfVVNCX1JPTEVfU1dJVENIIGlzIG5vdCBlbmFibGVkLAo+ID4gCj4gPiBk cml2ZXJzL3VzYi9tdHUzL210dTNfZHIubzogSW4gZnVuY3Rpb24gYHNzdXNiX3JvbGVfc3dfcmVn aXN0ZXInOgo+ID4gLi9kcml2ZXJzL3VzYi9tdHUzL210dTNfZHIuYzo0NjA6IHVuZGVmaW5lZCBy ZWZlcmVuY2UgdG8KPiA+IGB1c2Jfcm9sZV9zd2l0Y2hfcmVnaXN0ZXInCj4gPiBkcml2ZXJzL3Vz Yi9tdHUzL210dTNfZHIubzogSW4gZnVuY3Rpb24gYHNzdXNiX290Z19zd2l0Y2hfZXhpdCc6Cj4g PiAuL2RyaXZlcnMvdXNiL210dTMvbXR1M19kci5jOjQ5MTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0 bwo+ID4gYHVzYl9yb2xlX3N3aXRjaF91bnJlZ2lzdGVyJwo+IAo+IFNvIHlvdSBuZWVkIHRvIGFk ZCBkZXBlbmRlbmN5IG9uIFVTQl9ST0xFX1NXSVRDSCwgcmlnaHQ/ClllcwoKPiAKPiAtLS0gYS9k cml2ZXJzL3VzYi9tdHUzL0tjb25maWcKPiArKysgYi9kcml2ZXJzL3VzYi9tdHUzL0tjb25maWcK PiBAQCAtNDMsNiArNDMsNyBAQCBjb25maWcgVVNCX01UVTNfRFVBTF9ST0xFCj4gICAgICAgICBi b29sICJEdWFsIFJvbGUgbW9kZSIKPiAgICAgICAgIGRlcGVuZHMgb24gKChVU0I9eSB8fCBVU0I9 VVNCX01UVTMpICYmIChVU0JfR0FER0VUPXkgfHwgVVNCX0dBREdFVD1VU0JfTVRVMykpCj4gICAg ICAgICBkZXBlbmRzIG9uIChFWFRDT049eSB8fCBFWFRDT049VVNCX01UVTMpCj4gKyAgICAgICBk ZXBlbmRzIG9uIFVTQl9ST0xFX1NXSVRDSAo+ICAgICAgICAgaGVscAo+ICAgICAgICAgICBUaGlz IGlzIHRoZSBkZWZhdWx0IG1vZGUgb2Ygd29ya2luZyBvZiBNVFUzIGNvbnRyb2xsZXIgd2hlcmUK PiAgICAgICAgICAgYm90aCBob3N0IGFuZCBnYWRnZXQgZmVhdHVyZXMgYXJlIGVuYWJsZWQuCj4g Cj4gPiB0aGUgZm9sbG93aW5nIHBhdGNoIGhhcyBmaXhlZCB0aGUgaXNzdWUsIGJ1dCBzZWVtcyBu b3QgZ2V0IGludG8ga2VybmVsLAo+ID4gW3YzLDA4LzEyXSB1c2I6IHJvbGVzOiBBZGQgdXNiIHJv bGUgc3dpdGNoIG5vdGlmaWVyLgo+ID4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRj aC8xMDgzNjUyNS8KPiAKPiBJIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoYXQgZml4ZXMgdGhlIHBy b2JsZW0/IFRoYXQgcGF0Y2ggd2lsbCBpbiBhbnkKPiBjYXNlIGJlIHRhcmdldGluZyB2NS4yLiBX ZSBhcmUgaW4gdGhlIG1pZGRsZSBvZiBtZXJnZSB3aW5kb3csIHNvCj4gbm90aGluZyBpcyBoYXBw ZW5pbmcgdW50aWwgdjUuMS1yYzEgaXMgdGFnZ2VkLgpJdCBwcm92aWRlcyBzb21lIGR1bW15IGlu bGluZSBmdW5jdGlvbnMgd2hlbiBVU0JfUk9MRV9TV0lUQ0ggaXMgbm90CmVuYWJsZWQsIHRoaXMg d2lsbCBhdm9pZCBidWlsZCBlcnJvcgoKPiAKPiAKPiB0aGFua3MsCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A394FC43381 for ; Fri, 15 Mar 2019 09:33:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71AE621872 for ; Fri, 15 Mar 2019 09:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uNIR2Ctw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71AE621872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Znj+CyN3rmVUac+DbQx3La4qnDgW990tJlylWDHLpKY=; b=uNIR2Ctw1m00ar 1as4iUKj20BDp7b3MlirYnyJc3psnWe3fygaX3MgUh/0imb3MMfWkHVAgWaKLFyoUqmx2DGyH/m+A Xny0G7yejC9wnAnUhEmqxM5lJAAlKkT/N3lgPDfOp3PRjvmS4COPW7o7dxAq7epxqdpF9Fep9IZLX W9+OsMgZ2JUVumsfKMOHTrK5xDadYB+eJsdxyM7WWKxZh6M6OXtiTsXdWEVinCKq9XR/3L4I9T+Oy IiXp4qTrqBdTGQBel3K6A8bB7DgS2/9VQDAvS9pSKZlZNRzByojfNOMJr7YHAuUgNzvnxjFY22RLm N9loEMVAW4Jhw+DXBjoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4jDC-0005uX-Ig; Fri, 15 Mar 2019 09:33:10 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4jD8-0005tO-Ij; Fri, 15 Mar 2019 09:33:07 +0000 X-UUID: 088828567e0c4d2e8ee550fd2ac16ece-20190315 X-UUID: 088828567e0c4d2e8ee550fd2ac16ece-20190315 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1068700573; Fri, 15 Mar 2019 01:33:04 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 02:33:02 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 17:33:00 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 17:33:00 +0800 Message-ID: <1552642379.10179.138.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Heikki Krogerus Date: Fri, 15 Mar 2019 17:32:59 +0800 In-Reply-To: <20190315092644.GG7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> <20190315092644.GG7752@kuha.fi.intel.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_023306_646485_9B852245 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 2019-03-15 at 11:26 +0200, Heikki Krogerus wrote: > Hi Chunfeng, > > On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > > `usb_role_switch_register' > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > > `usb_role_switch_unregister' > > So you need to add dependency on USB_ROLE_SWITCH, right? Yes > > --- a/drivers/usb/mtu3/Kconfig > +++ b/drivers/usb/mtu3/Kconfig > @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE > bool "Dual Role mode" > depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) > depends on (EXTCON=y || EXTCON=USB_MTU3) > + depends on USB_ROLE_SWITCH > help > This is the default mode of working of MTU3 controller where > both host and gadget features are enabled. > > > the following patch has fixed the issue, but seems not get into kernel, > > [v3,08/12] usb: roles: Add usb role switch notifier. > > https://patchwork.kernel.org/patch/10836525/ > > I don't understand how that fixes the problem? That patch will in any > case be targeting v5.2. We are in the middle of merge window, so > nothing is happening until v5.1-rc1 is tagged. It provides some dummy inline functions when USB_ROLE_SWITCH is not enabled, this will avoid build error > > > thanks, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23913C43381 for ; Fri, 15 Mar 2019 09:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB7E921872 for ; Fri, 15 Mar 2019 09:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728748AbfCOJdI (ORCPT ); Fri, 15 Mar 2019 05:33:08 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:27427 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727734AbfCOJdH (ORCPT ); Fri, 15 Mar 2019 05:33:07 -0400 X-UUID: d2543c6e789445dd85f0a8f32260a88c-20190315 X-UUID: d2543c6e789445dd85f0a8f32260a88c-20190315 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1849929349; Fri, 15 Mar 2019 17:33:02 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 17:33:00 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 17:33:00 +0800 Message-ID: <1552642379.10179.138.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Heikki Krogerus CC: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , "Mark Rutland" , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Min Guo , , , , , Date: Fri, 15 Mar 2019 17:32:59 +0800 In-Reply-To: <20190315092644.GG7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> <20190315092644.GG7752@kuha.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 2019-03-15 at 11:26 +0200, Heikki Krogerus wrote: > Hi Chunfeng, > > On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > > `usb_role_switch_register' > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > > `usb_role_switch_unregister' > > So you need to add dependency on USB_ROLE_SWITCH, right? Yes > > --- a/drivers/usb/mtu3/Kconfig > +++ b/drivers/usb/mtu3/Kconfig > @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE > bool "Dual Role mode" > depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) > depends on (EXTCON=y || EXTCON=USB_MTU3) > + depends on USB_ROLE_SWITCH > help > This is the default mode of working of MTU3 controller where > both host and gadget features are enabled. > > > the following patch has fixed the issue, but seems not get into kernel, > > [v3,08/12] usb: roles: Add usb role switch notifier. > > https://patchwork.kernel.org/patch/10836525/ > > I don't understand how that fixes the problem? That patch will in any > case be targeting v5.2. We are in the middle of merge window, so > nothing is happening until v5.1-rc1 is tagged. It provides some dummy inline functions when USB_ROLE_SWITCH is not enabled, this will avoid build error > > > thanks, >