All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/uboot-tools: Fix loop positional declaration build error
Date: Mon, 18 Mar 2019 17:36:58 +0200	[thread overview]
Message-ID: <1552923418-22447-1-git-send-email-email@gmail.com> (raw)

From: Vadim Kochan <vadim4j@gmail.com>

Move 'i' variable outside of the 'for' loop to separate declaration
in lib/crc16.c

Fixes:
	http://autobuild.buildroot.net/results/332c9d2232c03440bf71794ee7850b1f6fd51d11/

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 ...04-lib-crc16-Fix-loop-initial-declaration.patch | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/uboot-tools/0004-lib-crc16-Fix-loop-initial-declaration.patch

diff --git a/package/uboot-tools/0004-lib-crc16-Fix-loop-initial-declaration.patch b/package/uboot-tools/0004-lib-crc16-Fix-loop-initial-declaration.patch
new file mode 100644
index 0000000..65b4c2f
--- /dev/null
+++ b/package/uboot-tools/0004-lib-crc16-Fix-loop-initial-declaration.patch
@@ -0,0 +1,38 @@
+From 1f6e30d11d7f58b028e42291e112cd44fbdcdbe9 Mon Sep 17 00:00:00 2001
+From: Vadim Kochan <vadim4j@gmail.com>
+Date: Mon, 18 Mar 2019 17:26:36 +0200
+Subject: [PATCH] lib/crc16: Fix loop initial declaration
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fix build error:
+
+    ./tools/../lib/crc16.c:70:2: error: ?for? loop initial declarations are
+        only allowed in C99 or C11 mode
+
+by moving 'i' variable from 'for' loop to separate declaration.
+
+Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
+---
+ lib/crc16.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/lib/crc16.c b/lib/crc16.c
+index f46ba72..89d2cff 100644
+--- a/lib/crc16.c
++++ b/lib/crc16.c
+@@ -67,7 +67,9 @@ static const uint16_t crc16_tab[] = {
+ 
+ uint16_t crc16_ccitt(uint16_t cksum, const unsigned char *buf, int len)
+ {
+-	for (int i = 0;  i < len;  i++)
++	int i;
++
++	for (i = 0;  i < len;  i++)
+ 		cksum = crc16_tab[((cksum>>8) ^ *buf++) & 0xff] ^ (cksum << 8);
+ 
+ 	return cksum;
+-- 
+2.7.4
+
-- 
2.7.4

             reply	other threads:[~2019-03-18 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 15:36 Vadim Kochan [this message]
2019-03-18 16:12 ` [Buildroot] [PATCH 1/1] package/uboot-tools: Fix loop positional declaration build error Thomas Petazzoni
2019-03-18 16:22   ` Vadym Kochan
2019-03-25 10:59   ` Vadym Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552923418-22447-1-git-send-email-email@gmail.com \
    --to=vadim4j@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.